-
Notifications
You must be signed in to change notification settings - Fork 37.7k
test : improve mempool_accept_wtxid.py #22532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Concept ACK, thanks for picking this up! Needs a rebase and squash. |
@michaelfolkson gave me a tip in my first PR that might be helpful for you: You can do a reset on your branch to the current top commit on master, then re-adding your commit and force pushing. git reset --hard insert_current_top_commit_hash_on_master Then add a single commit on top and force pushing |
Concept ACK Did you consider also doing:
|
Concept ACK Thanks for picking this up and welcome as a new contributor! 🎉 |
(Also needs a squash) |
Improve mempool_accept_wtxid.py Improve mempool_accept_wtxid.py Improve mempool_accept_wtxid.py Improve mempool_accept_wtxid.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 91b0597
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
post-merge ACK 91b0597 🍺
nit: not a big issue, but next time, please take care of the commit message body, the 4x"Improve mempool_accept_wtxid.py" doesn't contain any information :)
Oh yes, thank you for the guidance. Will certainly take care of that in the future. |
91b0597 Improve mempool_accept_wtxid.py (naiza) Pull request description: Follow-up to bitcoin#22253 adding changes suggested in [bitcoin#22253 (review)](bitcoin#22253 (comment)) ACKs for top commit: glozow: utACK 91b0597 Tree-SHA512: 383064138a5b2160d769c9df370470fd585c91682083013a6fa15e14448a4b481bc09b3a0ed6e75554db2c378df6b2263c65f209f973c9e9d577e15814a4be1d
Follow-up to #22253 adding changes suggested in #22253 (review)