-
Notifications
You must be signed in to change notification settings - Fork 37.7k
test: whitelist rpc_rawtransaction peers to speed up tests #22447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: whitelist rpc_rawtransaction peers to speed up tests #22447
Conversation
in my testing from 45-55 seconds to 15.
(First 2 commits from #22437). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK a3d6ec5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK a3d6ec5 🐎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK a3d6ec5
From 01:12:77 to 00:24:92
ACK a3d6ec5 |
Summary: Backport of [[bitcoin/bitcoin#22447 | core#22447]]. Speeds up the test by ~3x on my machine. Sorry for the style, it's the original material. Test Plan: ./test/functional/test_runner.py rpc_rawtransaction Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D9828
…d up tests a3d6ec5 test: move rpc_rawtransaction tests to < 30s group (Jon Atack) 5a1ed96 test: whitelist rpc_rawtransaction peers to speed up tests (Jon Atack) Pull request description: Speed up the somewhat slow `rpc_rawtransaction.py` test by more than 3x (from 45-55 seconds to 15 seconds on a laptop running 2 x 2.5GHz). ACKs for top commit: mjdietzx: ACK a3d6ec5 kristapsk: ACK a3d6ec5 theStack: ACK a3d6ec5 🐎 brunoerg: tACK a3d6ec5 Tree-SHA512: f1d105594c9b5b257a7096b631a6fa5aeb50e330a351f75c2d6ffa7dd73abdb6e1f596a78c16d204a9bac3fe506e0519f9ad96bb8477ab6424c8e18125ccb659
Speed up the somewhat slow
rpc_rawtransaction.py
test by more than 3x (from 45-55 seconds to 15 seconds on a laptop running 2 x 2.5GHz).