Skip to content

Conversation

jonatack
Copy link
Member

Speed up the somewhat slow rpc_rawtransaction.py test by more than 3x (from 45-55 seconds to 15 seconds on a laptop running 2 x 2.5GHz).

@jonatack
Copy link
Member Author

jonatack commented Jul 14, 2021

(First 2 commits from #22437).

@fanquake fanquake added the Tests label Jul 14, 2021
Copy link
Contributor

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a3d6ec5

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a3d6ec5 🐎

Copy link
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK a3d6ec5

From 01:12:77 to 00:24:92

@mjdietzx
Copy link
Contributor

ACK a3d6ec5

@fanquake fanquake merged commit e2c4ac7 into bitcoin:master Jul 15, 2021
@jonatack jonatack deleted the speed-up-rpc_rawtransaction-test branch July 15, 2021 07:18
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jul 21, 2021
Summary:
Backport of [[bitcoin/bitcoin#22447 | core#22447]].

Speeds up the test by ~3x on my machine.
Sorry for the style, it's the original material.

Test Plan:
  ./test/functional/test_runner.py rpc_rawtransaction

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D9828
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 23, 2021
…d up tests

a3d6ec5 test: move rpc_rawtransaction tests to < 30s group (Jon Atack)
5a1ed96 test: whitelist rpc_rawtransaction peers to speed up tests (Jon Atack)

Pull request description:

  Speed up the somewhat slow `rpc_rawtransaction.py` test by more than 3x (from 45-55 seconds to 15 seconds on a laptop running 2 x 2.5GHz).

ACKs for top commit:
  mjdietzx:
    ACK a3d6ec5
  kristapsk:
    ACK a3d6ec5
  theStack:
    ACK a3d6ec5 🐎
  brunoerg:
    tACK a3d6ec5

Tree-SHA512: f1d105594c9b5b257a7096b631a6fa5aeb50e330a351f75c2d6ffa7dd73abdb6e1f596a78c16d204a9bac3fe506e0519f9ad96bb8477ab6424c8e18125ccb659
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants