Skip to content

Support multiple -*notify commands #22372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Support multiple -*notify commands #22372

wants to merge 2 commits into from

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Jun 29, 2021

Useful, intuitive, and avoids creating issues with #22354

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 30, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

This was referenced Jun 30, 2021
Merged
Merged
kristapsk
kristapsk reviewed Jul 1, 2021
View reviewed changes
@kristapsk
Copy link
Contributor

Concept ACK

1 similar comment
@benthecarman
Copy link
Contributor

Concept ACK

@benthecarman
Copy link
Contributor

Looks like this doesn't touch -startupnotify, does that support multiple already?

@luke-jr
Copy link
Member Author

luke-jr commented Jul 3, 2021

Whoops, fixed.

@DrahtBot DrahtBot mentioned this pull request Sep 9, 2021
Merged
@luke-jr luke-jr mentioned this pull request Nov 2, 2021
Merged
maflcko
maflcko reviewed Nov 10, 2021
View reviewed changes
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 14, 2021
@luke-jr
scripted-diff: test: rename strCmd to command
c83d8d7 
-BEGIN VERIFY SCRIPT-
sed -i 's/\bstrCmd\b/command/g' $(git grep -l strCmd)
-END VERIFY SCRIPT-

Github-Pull: bitcoin#22372
Rebased-From: 849c19a
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 14, 2021
@luke-jr
Support multiple -*notify commands
6c7304f 
Github-Pull: bitcoin#22372
Rebased-From: 54b25a8
@luke-jr
scripted-diff: test: rename strCmd to command
5498850 
-BEGIN VERIFY SCRIPT-
sed -i 's/\bstrCmd\b/command/g' $(git grep -l strCmd)
-END VERIFY SCRIPT-
@luke-jr
Support multiple -*notify commands
041b1ed
@luke-jr
Copy link
Member Author

luke-jr commented Dec 17, 2021

Rebased and addressed review comments

@DrahtBot
Copy link
Contributor

DrahtBot commented May 6, 2022

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@luke-jr luke-jr mentioned this pull request Sep 9, 2022
Merged
@achow101
Copy link
Member

Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

@achow101 achow101 closed this Oct 12, 2022
@kristapsk
Copy link
Contributor

Guess this was closed just because of no rebase after May 6 and lack of ACKs? Seems useful in context of #25975.

@luke-jr
Copy link
Member Author

luke-jr commented Nov 26, 2022

Feel free to reopen. As with most of my PRs, I continue to maintain it for Knots.

@bitcoin bitcoin locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@kristapsk kristapsk kristapsk left review comments

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Needs rebase Validation Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@luke-jr @DrahtBot @kristapsk @benthecarman @achow101 @maflcko