blockstorage: Add missing atomic include #22309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
ACK fa2d21f, I have reviewed the code and it looks OK, I agree it can be merged.
bitcoin/src/node/blockstorage.h
Lines 37 to 38 in 672870a
|
cr ACK fa2d21f |
ghost
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
crACK fa2d21f
Confirmed std::atomic_bool is used at Line 38 and 39 which requires #include <atomic>
https://www.cplusplus.com/reference/atomic/atomic/atomic/
https://en.cppreference.com/w/cpp/atomic/atomic
|
crACK fa2d21f |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 24, 2021
fa2d21f add missing atomic include (MarcoFalke) Pull request description: `std::atomic` is used in the file, so to avoid compile issues, add the missing include. ACKs for top commit: practicalswift: cr ACK fa2d21f jamesob: crACK bitcoin@fa2d21f hebasto: ACK fa2d21f, I have reviewed the code and it looks OK, I agree it can be merged. prayank23: crACK bitcoin@fa2d21f Tree-SHA512: 307b15abd62006be4457b2437fb65de517c296bf0417e8acd181904eb6056dba5655dd5bc43b834bf68a087d06637f5e99ba5a6bc8be3e12388cea470dc155d0
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::atomicis used in the file, so to avoid compile issues, add the missing include.