Skip to content

Update msvc and appveyor builds to use Qt5.12.11 binaries #22224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2021
Merged

Update msvc and appveyor builds to use Qt5.12.11 binaries #22224

merged 1 commit into from
Jun 14, 2021

Conversation

sipsorcery
Copy link
Contributor

Synchronises the Qt version used in the msvc and Appveyor builds with #22054.

I needed to use switch to the Visual Studio 2019 Preview Appveyor image because the compiler version on the non-preview image is too far behind and I had difficulty building a compatible Qt version for it. Once the main Appveyor Visual Studio 2019 image reaches version 16.10.1 it can be used.

@hebasto
Copy link
Member

hebasto commented Jun 11, 2021

Concept ACK.

@sipsorcery Many thanks!

@hebasto
Copy link
Member

hebasto commented Jun 11, 2021

@sipsorcery

I needed to use switch to the Visual Studio 2019 Preview Appveyor image because the compiler version on the non-preview image is too far behind and I had difficulty building a compatible Qt version for it.

Did I understand correctly that there are no difficulties with Qt 5.12.10?

@sipsorcery
Copy link
Contributor Author

Did I understand correctly that there are no difficulties with Qt 5.12.10?

The difficulty is not Qt it's the difference between the msbuild version on the machine I use to build the Qt binaries and the msbuild version in the Appveyor image. The Appveyor Visual Studio 2019 image is on version 16.9.5 and my machine is on 16.10.1.

I did install a separate msbuild 16.9.5 toolchain on my machine and while it built Qt 5.12.11 successfully the Appveyor image got a link error when it attempted to use it. I'm guessing the two msbuild installs aren't fully isolated somehow. From past experience these linker issues can take a while to solve and it seems more efficient to simply switch to the Appveyor Preview image.

For any devs wanting to use the Qt binaries to build locally it means they will need to update to the latest stable version of msbuild 16.10.1.

If there are any concerns I can dig deeper into the 16.9.5 version link issue.

@DrahtBot DrahtBot added the Tests label Jun 11, 2021
@hebasto
Copy link
Member

hebasto commented Jun 11, 2021

With a patch:

--- a/.appveyor.yml
+++ b/.appveyor.yml
@@ -47,7 +47,7 @@ before_build:
 build_script:
 - cmd: msbuild /p:TrackFileAccess=false build_msvc\bitcoin.sln /m /v:q /nologo
 after_build:
-#- 7z a bitcoin-%APPVEYOR_BUILD_VERSION%.zip %APPVEYOR_BUILD_FOLDER%\build_msvc\%platform%\%configuration%\*.exe
+- 7z a bitcoin-%APPVEYOR_BUILD_VERSION%.zip %APPVEYOR_BUILD_FOLDER%\build_msvc\%platform%\%configuration%\*.exe
 test_script:
 - cmd: src\test_bitcoin.exe -l test_suite
 - cmd: src\bench_bitcoin.exe > NUL
@@ -59,5 +59,5 @@ test_script:
 # https://github.com/bitcoin/bitcoin/issues/18623
 # - cmd: python test\functional\test_runner.py --ci --quiet --combinedlogslen=4000 --failfast --exclude feature_fee_estimation
 artifacts:
-#- path: bitcoin-%APPVEYOR_BUILD_VERSION%.zip
+- path: bitcoin-%APPVEYOR_BUILD_VERSION%.zip
 deploy: off

I got an artifact.

Running bitcoin-qt.exe from the downloaded archive, I got a terminal window open along with the GUI.

I don't think such behavior is expected.

@sipsorcery
Copy link
Contributor Author

Running bitcoin-qt.exe from the downloaded archive, I got a terminal window open along with the GUI.
I don't think such behavior is expected.

I haven't noticed that as I always test my builds by running the GUI from the command line, e.g. bitcoin-qt -regtest.

I'm not sure why it occurs. I know next to nothing about Qt except how to build it. I vaguely recall something like this cropping up years ago but I can't even remember what the context was. Apologies for bringing you in @fanquake but perhaps you recall? I seem to hazily remember you being somehow involved. I could be completely wrong about that.

Either way this PR does not introduce that behaviour. Builds from master do the same thing.

hebasto
hebasto approved these changes Jun 12, 2021
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e25ea54

@fanquake fanquake merged commit ad2ab88 into bitcoin:master Jun 14, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 14, 2021
@fanquake
Merge bitcoin#22224: Update msvc and appveyor builds to use Qt5.12.11…
e690585 
… binaries

e25ea54 Update msvc and appveyor builds to use Qt5.12.11 binaries. (Aaron Clauson)

Pull request description:

  Synchronises the Qt version used in the msvc and Appveyor builds with bitcoin#22054.

  I needed to use switch to the `Visual Studio 2019 Preview` Appveyor image because the compiler version on the non-preview image is too far behind and I had difficulty building a compatible Qt version for it. Once the main Appveyor `Visual Studio 2019` image reaches version `16.10.1` it can be used.

ACKs for top commit:
  hebasto:
    ACK e25ea54

Tree-SHA512: c5e8dcafa342df7cd8ff7c349a8186bee4cdf7fd748c5d94039e30698775058bae8099dd75a50a5079f3cbb5251e695be187bae615159e3cd45054a972c4e6bd
sipsorcery added a commit to sipsorcery/bitcoin that referenced this pull request Jun 14, 2021
@sipsorcery
Switch Appveyor CI to VS2019 stable image
aab7fd0 
The current appveyor config is using the VS2019 preview image so the latest prebuilt Qt5.12.11 binaries can be used, see bitcoin#22224.

Appveyor updated the Visual Studio 2019 image to msbuild v16.10.1 on 14th of June. This is the version used to build the latest Qt binaries and removes the need to use the Appveyor VS2019 preview image.
@sipsorcery sipsorcery mentioned this pull request Jun 14, 2021
Merged
fanquake added a commit that referenced this pull request Jun 15, 2021
@fanquake
Merge #22247: Switch Appveyor CI to VS2019 stable image
eb63b1d 
aab7fd0 Switch Appveyor CI to VS2019 stable image (Aaron Clauson)

Pull request description:

  The current appveyor config is using the VS2019 preview image so the latest prebuilt Qt5.12.11 binaries can be used, see #22224.

  Appveyor updated the Visual Studio 2019 image to msbuild v16.10.1 on 14th of June. This is the version used to build the latest Qt binaries and removes the need to use the Appveyor VS2019 preview image.

ACKs for top commit:
  MarcoFalke:
    review ACK aab7fd0 if green
  practicalswift:
    cr ACK aab7fd0: patch looks correct
  hebasto:
    ACK aab7fd0

Tree-SHA512: 42ea4e6e27a2099ddeed99a3352e8ff014df1e93fbcb1f0f2ebd6f22ec2fb71212275a2adb2a7858516203e566c6ba053367b4ac7e0b74457f7a35e941d6fdd4
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 16, 2021
@fanquake
Merge bitcoin#22247: Switch Appveyor CI to VS2019 stable image
a66cebb 
aab7fd0 Switch Appveyor CI to VS2019 stable image (Aaron Clauson)

Pull request description:

  The current appveyor config is using the VS2019 preview image so the latest prebuilt Qt5.12.11 binaries can be used, see bitcoin#22224.

  Appveyor updated the Visual Studio 2019 image to msbuild v16.10.1 on 14th of June. This is the version used to build the latest Qt binaries and removes the need to use the Appveyor VS2019 preview image.

ACKs for top commit:
  MarcoFalke:
    review ACK aab7fd0 if green
  practicalswift:
    cr ACK aab7fd0: patch looks correct
  hebasto:
    ACK aab7fd0

Tree-SHA512: 42ea4e6e27a2099ddeed99a3352e8ff014df1e93fbcb1f0f2ebd6f22ec2fb71212275a2adb2a7858516203e566c6ba053367b4ac7e0b74457f7a35e941d6fdd4
rebroad pushed a commit to rebroad/bitcoin that referenced this pull request Jun 23, 2021
@sipsorcery @rebroad
Switch Appveyor CI to VS2019 stable image
99905a2 
The current appveyor config is using the VS2019 preview image so the latest prebuilt Qt5.12.11 binaries can be used, see bitcoin#22224.

Appveyor updated the Visual Studio 2019 image to msbuild v16.10.1 on 14th of June. This is the version used to build the latest Qt binaries and removes the need to use the Appveyor VS2019 preview image.
rebroad pushed a commit to rebroad/bitcoin that referenced this pull request Jun 28, 2021
@sipsorcery @rebroad
Switch Appveyor CI to VS2019 stable image
3d3feb2 
The current appveyor config is using the VS2019 preview image so the latest prebuilt Qt5.12.11 binaries can be used, see bitcoin#22224.

Appveyor updated the Visual Studio 2019 image to msbuild v16.10.1 on 14th of June. This is the version used to build the latest Qt binaries and removes the need to use the Appveyor VS2019 preview image.
josibake pushed a commit to josibake/bitcoin that referenced this pull request Jul 21, 2021
@sipsorcery @josibake
Switch Appveyor CI to VS2019 stable image
4a3a4d7 
The current appveyor config is using the VS2019 preview image so the latest prebuilt Qt5.12.11 binaries can be used, see bitcoin#22224.

Appveyor updated the Visual Studio 2019 image to msbuild v16.10.1 on 14th of June. This is the version used to build the latest Qt binaries and removes the need to use the Appveyor VS2019 preview image.
@bitcoin bitcoin locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sipsorcery @hebasto @fanquake @DrahtBot