Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Jun 6, 2021

-lxcb-shm should follow -lxcb when linking libraries for Linux hosts.

Fixes #22105.

This change fixes configuring with Qt on Alpine Linux.
@ghost
Copy link

ghost commented Jun 7, 2021

Running Alpine as VM. Followed the steps mentioned in https://gist.github.com/hebasto/a7f08e44ddb79cc4cde2762cf9ec5688

Getting an error for make -C depends

image

@hebasto
Copy link
Member Author

hebasto commented Jun 7, 2021

@prayank23

$ sudo apk add pkgconf

?

@ghost
Copy link

ghost commented Jun 7, 2021

$ sudo apk add pkgconf

Thanks. It worked. Compiled successfully and bitcoin-qt works without any issues.

ACK a8bd5ea

image

@hebasto
Copy link
Member Author

hebasto commented Jun 7, 2021

@prayank23

$ sudo apk add pkgconf

Thanks. It worked. Compiled successfully and bitcoin-qt works without any issues.

Thanks for testing! I've updated https://gist.github.com/hebasto/a7f08e44ddb79cc4cde2762cf9ec5688.

@fanquake
Copy link
Member

fanquake commented Jun 9, 2021

Guix builds:

bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
c33941bd3d21ae2d0729be2bea4e845e64d4580cd6fe99cb087a994cd5729137  guix-build-a8bd5ea01720/output/aarch64-linux-gnu/bitcoin-a8bd5ea01720-aarch64-linux-gnu-debug.tar.gz
ecb455b447f1bfe8f6cc1b50efc3949e732e72eb59bb4e7e6de4fc9a37e69147  guix-build-a8bd5ea01720/output/aarch64-linux-gnu/bitcoin-a8bd5ea01720-aarch64-linux-gnu.tar.gz
cb5bdb49d625b5726cafed241820dc8c1b340ab12685ff22101853addff06866  guix-build-a8bd5ea01720/output/aarch64-linux-gnu/inputs.SHA256SUMS
17253913b7562fc3301bb40fe1a0e31ab6cb9100f6aa5a20ea3c582173ee2990  guix-build-a8bd5ea01720/output/arm-linux-gnueabihf/bitcoin-a8bd5ea01720-arm-linux-gnueabihf-debug.tar.gz
8290f60d16d89ddb77bdff5b584d7362ce5382526c1ddc339be06e2550a56757  guix-build-a8bd5ea01720/output/arm-linux-gnueabihf/bitcoin-a8bd5ea01720-arm-linux-gnueabihf.tar.gz
cb5bdb49d625b5726cafed241820dc8c1b340ab12685ff22101853addff06866  guix-build-a8bd5ea01720/output/arm-linux-gnueabihf/inputs.SHA256SUMS
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-a8bd5ea01720/output/dist-archive/SKIPATTEST.TAG
f37513d317311107f23877f4e9b42658586dc6bd2a32fab32679c62222986276  guix-build-a8bd5ea01720/output/dist-archive/bitcoin-a8bd5ea01720.tar.gz
c3027aa748850163c19744b4f8867785acc49ffeccd66dc79213c5669c083686  guix-build-a8bd5ea01720/output/powerpc64-linux-gnu/bitcoin-a8bd5ea01720-powerpc64-linux-gnu-debug.tar.gz
848e84c5b1389e791e737288d2ece86de1dc8150b6598cbf80d772a4c8f323f9  guix-build-a8bd5ea01720/output/powerpc64-linux-gnu/bitcoin-a8bd5ea01720-powerpc64-linux-gnu.tar.gz
cb5bdb49d625b5726cafed241820dc8c1b340ab12685ff22101853addff06866  guix-build-a8bd5ea01720/output/powerpc64-linux-gnu/inputs.SHA256SUMS
4a8922124c2fe52da464e51ab4bf213d1bd111a9c2faeb8d61320617004aadba  guix-build-a8bd5ea01720/output/powerpc64le-linux-gnu/bitcoin-a8bd5ea01720-powerpc64le-linux-gnu-debug.tar.gz
7e991b0d67b9d3c57daa0f487507a6d4b71009f492e5a369b987fbc1885180bc  guix-build-a8bd5ea01720/output/powerpc64le-linux-gnu/bitcoin-a8bd5ea01720-powerpc64le-linux-gnu.tar.gz
cb5bdb49d625b5726cafed241820dc8c1b340ab12685ff22101853addff06866  guix-build-a8bd5ea01720/output/powerpc64le-linux-gnu/inputs.SHA256SUMS
a62ea81d1c989b9bd70404d6c9b69cd6a6f2d5c0965af007b0cc7d393b3cd832  guix-build-a8bd5ea01720/output/riscv64-linux-gnu/bitcoin-a8bd5ea01720-riscv64-linux-gnu-debug.tar.gz
11bb8039da30f7bfdf0bd19c2f5cc1c51159f5be1618d5e92b34c59ad1598549  guix-build-a8bd5ea01720/output/riscv64-linux-gnu/bitcoin-a8bd5ea01720-riscv64-linux-gnu.tar.gz
cb5bdb49d625b5726cafed241820dc8c1b340ab12685ff22101853addff06866  guix-build-a8bd5ea01720/output/riscv64-linux-gnu/inputs.SHA256SUMS
ff719bf7526043f4d0887a0b7ad9e1211c7f5fe1fa88b6e97496dc92570164a0  guix-build-a8bd5ea01720/output/x86_64-apple-darwin18/bitcoin-a8bd5ea01720-osx-unsigned.dmg
919986e94fc47d63bf3cde4ba813eda3446809fc183d05a200e4fbf163fee583  guix-build-a8bd5ea01720/output/x86_64-apple-darwin18/bitcoin-a8bd5ea01720-osx-unsigned.tar.gz
9f3a04127b64b4d94a42394a7c39fd5e562a607288b814ccfa84ea9e46a214d2  guix-build-a8bd5ea01720/output/x86_64-apple-darwin18/bitcoin-a8bd5ea01720-osx64.tar.gz
cb5bdb49d625b5726cafed241820dc8c1b340ab12685ff22101853addff06866  guix-build-a8bd5ea01720/output/x86_64-apple-darwin18/inputs.SHA256SUMS
27d043d6728f2284d13746a3e0391cba5c8d6a6e90ac6db81003633b3d8f85b8  guix-build-a8bd5ea01720/output/x86_64-linux-gnu/bitcoin-a8bd5ea01720-x86_64-linux-gnu-debug.tar.gz
1e7dded2772d8aa34e8040d2340824521d6e9090370c73065d814251096f89f1  guix-build-a8bd5ea01720/output/x86_64-linux-gnu/bitcoin-a8bd5ea01720-x86_64-linux-gnu.tar.gz
cb5bdb49d625b5726cafed241820dc8c1b340ab12685ff22101853addff06866  guix-build-a8bd5ea01720/output/x86_64-linux-gnu/inputs.SHA256SUMS
f18c15f228e3074235fa00031b854359c9ebc77a15af410a2f2f7419ec8e679e  guix-build-a8bd5ea01720/output/x86_64-w64-mingw32/bitcoin-a8bd5ea01720-win-unsigned.tar.gz
7981983e17aa5e750d546c23e20af40b4ddb0e518284dfc32a6775b158bb0a47  guix-build-a8bd5ea01720/output/x86_64-w64-mingw32/bitcoin-a8bd5ea01720-win64-debug.zip
d0a7de5f9ce1953e8cb8277fabc759e3d3694b49ffbea3e1661396a170d8891c  guix-build-a8bd5ea01720/output/x86_64-w64-mingw32/bitcoin-a8bd5ea01720-win64-setup-unsigned.exe
5fd16269fcccbb542388acf091283e95ec072b25c427647ad3f11d10d42b0302  guix-build-a8bd5ea01720/output/x86_64-w64-mingw32/bitcoin-a8bd5ea01720-win64.zip
cb5bdb49d625b5726cafed241820dc8c1b340ab12685ff22101853addff06866  guix-build-a8bd5ea01720/output/x86_64-w64-mingw32/inputs.SHA256SUMS

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a8bd5ea

@fanquake fanquake merged commit fe51145 into bitcoin:master Jun 9, 2021
@hebasto hebasto deleted the 210606-order branch June 9, 2021 12:01
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 9, 2021
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 28, 2022
… hosts

a8bd5ea build, qt: Fix libraries linking order for Linux hosts (Hennadii Stepanov)

Pull request description:

  `-lxcb-shm` should follow `-lxcb` when linking libraries for Linux hosts.

  Fixes bitcoin#22105.

ACKs for top commit:
  prayank23:
    ACK bitcoin@a8bd5ea
  fanquake:
    ACK a8bd5ea

Tree-SHA512: 6ea2a1ba5440dd01e64428e5c3aa3e7a6e1380b723071ad38a0516b23b56dc252cb2a6544e014b13a0b2f89b3fe45c04a82e498669b5cc74a5f9b70d9c270926
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 28, 2022
… hosts

a8bd5ea build, qt: Fix libraries linking order for Linux hosts (Hennadii Stepanov)

Pull request description:

  `-lxcb-shm` should follow `-lxcb` when linking libraries for Linux hosts.

  Fixes bitcoin#22105.

ACKs for top commit:
  prayank23:
    ACK bitcoin@a8bd5ea
  fanquake:
    ACK a8bd5ea

Tree-SHA512: 6ea2a1ba5440dd01e64428e5c3aa3e7a6e1380b723071ad38a0516b23b56dc252cb2a6544e014b13a0b2f89b3fe45c04a82e498669b5cc74a5f9b70d9c270926
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: alpine qt from depends not configuring
2 participants