Skip to content

Conversation

jonatack
Copy link
Member

@jonatack jonatack commented Jun 3, 2021

"invokable" is a valid word that means to be callable, but the linter is raising on it:

$ test/lint/lint-spelling.sh 
contrib/guix/guix-attest:18: invokable ==> invocable
contrib/guix/guix-clean:18: invokable ==> invocable
contrib/guix/guix-verify:18: invokable ==> invocable
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt

@michaelfolkson
Copy link

michaelfolkson commented Jun 3, 2021

Concept ACK. I think this should be doc: in the title rather than script:?

@jonatack jonatack changed the title script: fix spelling linter raising spuriously on "invokable" doc: fix spelling linter raising spuriously on "invokable" Jun 3, 2021
@jonatack
Copy link
Member Author

jonatack commented Jun 3, 2021

Changed to doc though I think it should be script (the linter script) or test.

@jonatack jonatack changed the title doc: fix spelling linter raising spuriously on "invokable" script: fix spelling linter raising spuriously on "invokable" Jun 3, 2021
@jonatack
Copy link
Member Author

jonatack commented Jun 3, 2021

Back to script 😄

@michaelfolkson
Copy link

michaelfolkson commented Jun 3, 2021

You are right, sorry :)

I thought script was a prefix for changes to Bitcoin script but appears not! That would be consensus

script for changes to the scripts and tools https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#creating-the-pull-request

@DrahtBot DrahtBot added the Tests label Jun 3, 2021
@maflcko
Copy link
Member

maflcko commented Jun 3, 2021

cr ACK 8050eb4

@maflcko maflcko merged commit d331e26 into bitcoin:master Jun 3, 2021
@jonatack jonatack deleted the fix-spurious-linter-spelling branch June 3, 2021 12:44
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 3, 2021
…n "invokable"

8050eb4 script: fix spelling linter raising spuriously on "invokable" (Jon Atack)

Pull request description:

  "invokable" is a valid word that means to be callable, but the linter is raising on it:
  ```
  $ test/lint/lint-spelling.sh
  contrib/guix/guix-attest:18: invokable ==> invocable
  contrib/guix/guix-clean:18: invokable ==> invocable
  contrib/guix/guix-verify:18: invokable ==> invocable
  ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt
  ```

ACKs for top commit:
  MarcoFalke:
    cr ACK 8050eb4

Tree-SHA512: 43f8dc7b7adb00ae563ccfe04a64a7ceb50237f24ff87209062bf57b2564b4d38a409df80e0183aa4f40ab306b5e07d7a5fad1600d41705bd3c443ed66a6d1c1
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants