scripted-diff: rename GetSystemTimeInSeconds to GetTimeSeconds #22107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-BEGIN VERIFY SCRIPT- sed -i -e 's/GetSystemTimeInSeconds/GetTimeSeconds/g' $(git grep -l GetSystemTimeInSeconds src) -END VERIFY SCRIPT-
|
Concept ACK |
2 similar comments
|
Concept ACK |
|
Concept ACK |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
promag
reviewed
May 31, 2021
|
cr ACK feb72e5: patch looks correct |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply renames
GetSystemTimeInSecondstoGetTimeSeconds, for uniformity amongst our time handling functions (GetTimeMillis,GetTimeMicros). I have a branch that does a chunk ofGetTime()->GetSystemTimeInSeconds(GetTimeSeconds) /GetTime<T>migration, so we can eventually remove the (2 year) deprecatedGetTime().However, splitting this off and doing the renaming first while the number of
GetSystemTimeInSecondsinstances is small seems worthwhile.