build: Use Qt archive of the same version as the compiled binaries #22063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes broken Android APK build when the `depends/sources` directory contains Qt source archives of different versions (e.g., Qt version update pull request in CI with the cached `depends/sources` directory).
|
Android APK build of the #22054 on top of this PR: https://cirrus-ci.com/task/6725312600866816. |
|
review ACK cb7eba2 |
|
Good catch! This was kind of ugly; I always symlink the Code review ACK cb7eba2 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 27, 2021
… compiled binaries cb7eba2 build: Use Qt archive of the same version as the compiled binaries (Hennadii Stepanov) Pull request description: This PR fixes broken Android APK build when the `depends/sources` directory contains Qt source archives of different versions (e.g., Qt version update [pull request](bitcoin#22054) in CI with the cached `depends/sources` directory). This is an alternative to bitcoin#22058. ACKs for top commit: MarcoFalke: review ACK cb7eba2 laanwj: Code review ACK cb7eba2 Tree-SHA512: cf63a9809fba5cb13719d7e7bb5afc718a2cff5233b0670d30d30a0018d91278fcfc2a1b9ae8b84e8e3a52c95157bc465603cc754bb8a9d1a3d62415f01ad70f
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes broken Android APK build when the
depends/sourcesdirectory contains Qt source archives of different versions (e.g., Qt version update pull request in CI with the cacheddepends/sourcesdirectory).This is an alternative to #22058.