Skip to content

rpc: add period_start to version bits statistics #22016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

rpc: add period_start to version bits statistics #22016

wants to merge 1 commit into from

Conversation

Sjors
Copy link
Member

@Sjors Sjors commented May 21, 2021 •
edited
Loading

This PR adds period_start to the softfork statistics.

This makes it easier to draw green squares.

Admittedly this is trivial to calculate: $height - ($height mod $period)

@Sjors Sjors force-pushed the 2021/05/versionbits_period_start branch from e4842cc to 6321cf7 Compare May 21, 2021 16:24
@Sjors
Copy link
Member Author

Sjors commented May 21, 2021

Alternatively we could add retarget_period_start to the main getblockchaininfo dictionary.

@DrahtBot
Copy link
Contributor

DrahtBot commented May 22, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #23508 (Add getdeploymentinfo RPC by ajtowns)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request May 22, 2021
Merged
@luke-jr
Copy link
Member

luke-jr commented Jun 11, 2021

Could also do height - elapsed? At the very least, I think it'd be better to keep it out of BIP9Stats and just do the math in the RPC interface...

@Sjors Sjors force-pushed the 2021/05/versionbits_period_start branch from 6321cf7 to 04ce309 Compare June 16, 2021 09:46
@Sjors
Copy link
Member Author

Sjors commented Jun 16, 2021

@luke-jr good point, done. It makes the change a lot smaller and limited to RPC code.

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Jun 27, 2021
@Sjors @luke-jr
rpc: add period_start to version bits statistics
7c2cd06 
Github-Pull: bitcoin#22016
Rebased-From: 04ce309
@Sjors
Copy link
Member Author

Sjors commented Jul 21, 2021

Rebased after #21934

@Sjors Sjors force-pushed the 2021/05/versionbits_period_start branch from 04ce309 to b2773c7 Compare July 21, 2021 08:17
@DrahtBot DrahtBot mentioned this pull request Aug 25, 2021
Merged
@Sjors Sjors force-pushed the 2021/05/versionbits_period_start branch from b2773c7 to 70d7e08 Compare September 23, 2021 10:35
luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 10, 2021
@Sjors @luke-jr
rpc: add period_start to version bits statistics
d6d1a1b 
Github-Pull: bitcoin#22016
Rebased-From: b2773c7
This was referenced Nov 14, 2021
Merged
Closed
@DrahtBot DrahtBot mentioned this pull request Dec 8, 2021
Merged
@Sjors Sjors force-pushed the 2021/05/versionbits_period_start branch from 70d7e08 to 1898b9b Compare December 9, 2021 12:33
@laanwj
Copy link
Member

laanwj commented Dec 15, 2021

Do we need to reconsider this after #23508?

@Sjors
Copy link
Member Author

Sjors commented Dec 16, 2021

I might just rebase it after that, yes.

@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@Sjors
Copy link
Member Author

Sjors commented Jan 28, 2022

Green squares have already been made trivial with #23508, so closing this.

@Sjors Sjors closed this Jan 28, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs rebase RPC/REST/ZMQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sjors @DrahtBot @luke-jr @laanwj @fanquake