Skip to content

Conversation

jonatack
Copy link
Member

No description provided.

@DrahtBot DrahtBot added the Docs label Apr 30, 2021
@hebasto
Copy link
Member

hebasto commented Apr 30, 2021

It'd be nice to update the doc/files.md as well:

fs::path path{GetDataDir() / "indexes" / "coinstats"};

@jonatack
Copy link
Member Author

Good idea @hebasto. Thanks, done.

@jonatack jonatack changed the title doc: fixup -coinstatsindex help, update bitcoin.conf doc: fixup -coinstatsindex help, update bitcoin.conf and files.md Apr 30, 2021
Copy link
Contributor

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR-ACK 15796fb

@jonatack jonatack force-pushed the add-coinstatsindex-to-bitcoin-conf branch from 15796fb to 54133c5 Compare May 1, 2021 12:00
@jonatack jonatack mentioned this pull request May 1, 2021
@Sjors
Copy link
Member

Sjors commented May 1, 2021

utACK 54133c5

@maflcko
Copy link
Member

maflcko commented May 1, 2021

cr ACK 54133c5

@clarkmoody
Copy link

utACK 54133c5

@fanquake fanquake merged commit 5986970 into bitcoin:master May 2, 2021
@jonatack jonatack deleted the add-coinstatsindex-to-bitcoin-conf branch May 2, 2021 07:03
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 2, 2021
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jun 13, 2022
Summary:
This is a backport of [[bitcoin/bitcoin#19521 | core#19521]] [5/17]
bitcoin/bitcoin@3c914d5
partial  bitcoin/bitcoin@6a4c0c0

The functional test only checks that "-coinstatsindex" argument does not break anything. The rest of the functional test from commit 6a4c0c09ab is not yet applicable and will be added in the next commit.

This includes also minor documentation fixups from [[ bitcoin/bitcoin#21818 | core#21818]]

Depends on D11598 and D11595

Test Plan: `ninja all check-all`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11599
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jun 13, 2022
Summary:
- update files.md
- test touchup

Note: the rest of the fixups are applied where applicable (D11599 and D11600)

This is a backport of [[bitcoin/bitcoin#21818 | core#21818]]
Depends on D11610

Test Plan: NA

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11611
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants