test: Fix intermittent issue in p2p_addr_relay.py #21785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can be reviewed with |
|
Thanks for the fix and Concept ACK. See #21707 (comment) - there is another occurrence in |
|
Concept ACK, hit this issue today. |
There was a problem hiding this comment.
ACK fa5211d, thanks for this fix. agree with mzumsande's #21785 (comment), ready to reACK if you incorporate. also left some wording suggestions to consider.
|
ACK faa51ef |
1 similar comment
|
ACK faa51ef |
|
ACK faa51ef. Looks good. Thanks Marco. |
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 27, 2021
Github-Pull: bitcoin#21785 Rebased-From: faa51ef
Fabcien
added a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 21, 2022
Summary: ``` This extends the functional test p2p_addr_relay.py. It adds test coverage for address relay involving outbound peers, tests for both outgoing and incoming GETADDR requests and tests for -blocksonly mode. ``` Backport of [[bitcoin/bitcoin#21707 | core#21707]], [[bitcoin/bitcoin#21785 | core#21785]] (fix intermittent failure in the test) and [[bitcoin/bitcoin#22306 | core#22306]] (improvements to p2p_addr_relay.py, also fixes an intermittent issue). Note to reviewers: you can look at the file after #22306 to get the final version of the test. Depends on D10860. Ref T1696. Test Plan: ninja check-functional Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Subscribers: PiRK Maniphest Tasks: T1696 Differential Revision: https://reviews.bitcoinabc.org/D10861
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/bitcoin/bitcoin/pull/21707/files#r621048952