Skip to content

Conversation

dongcarl
Copy link
Contributor

@dongcarl dongcarl commented Apr 16, 2021

Based on: #21462

Keeping the README in one file so that it's easy to search through. Will add more jumping links later so navigation is easier.

Current TODOs:

  • Shell installer option: prompt user to re-login for /etc/profile.d entry to be picked up
  • Binary tarball option: prompt user to create /etc/profile.d entry and re-login
  • Fanquake docker option: complete section
  • Arch Linux AUR option: prompt to start guix-daemon-latest unit after finishing "optional setup" section
  • Building from source option: Insert dependency tree diagram that I made
  • Building from source option: redo sectioning, kind of a mess right now
  • Optional setup: make clear which parts are only needed if building from source
  • Workaround 1 for GnuTLS: perhaps mention how to remove Guix build farm's key
  • Overall (after everything): Make the links work.

Note to self: wherever possible, tell user how to check that something is true rather than branching by installation option.

Copy link

@78051301012 78051301012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@fanquake fanquake added this to the 22.0 milestone Jun 16, 2021
@fanquake
Copy link
Member

@dongcarl can you rebase this and address the current batch of comments?

@dongcarl dongcarl force-pushed the 2021-03-guix-docs branch from 57684ed to 5ae2760 Compare June 17, 2021 22:07
@dongcarl
Copy link
Contributor Author

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 18, 2021

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko
Copy link
Member

maflcko commented Jun 18, 2021

Shouldn't this also update release-process.md?

Copy link
Member

@achow101 achow101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

More docs more good

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ACK

Couple of notes. I assume you are already working on an update for 1.3.0 so I will re-review when it's updated

@dongcarl
Copy link
Contributor Author

dongcarl commented Jul 6, 2021

The documentation is very close to being done, just some final polishing and making the links work. Please let me know if I'm missing any crucial details!

@dongcarl dongcarl force-pushed the 2021-03-guix-docs branch 2 times, most recently from 63e8fce to 5016091 Compare July 7, 2021 20:33
@dongcarl dongcarl marked this pull request as ready for review July 7, 2021 20:33
@dongcarl
Copy link
Contributor Author

dongcarl commented Jul 7, 2021

This PR is ready for review as of 5016091

Thanks @jarolrod for the diligent reviews, I will address the nits after others agree that I haven't missed anything crucial!

Copy link
Member

@achow101 achow101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5016091

@fanquake fanquake mentioned this pull request Jul 8, 2021
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

Looks pretty good. Maybe a little too much detail in some cases, i.e some things feel a bit repetitive, but I think that's ok for now.

In release-process.md, there are still two mentions of gitian in the Update packaging repo section.

In guix-attest, can you address this comment from #22182.

I am running through doing a build using a Ubuntu:Hirsute container, using the following:

docker run -it --rm --privileged ubuntu:hirsute /bin/bash
apt update -y && apt upgrade -y && apt install curl git guix make -y

addgroup guixbuild
useradd -g guixbuild -G guixbuild -d /var/empty -s $(which nologin) -c "Guix build user" --system "guixbuilder"
guix-daemon --no-substitutes --build-users-group=guixbuild &

git clone https://github.com/bitcoin/bitcoin
cd bitcoin
HOSTS="x86_64-linux-gnu" ./contrib/guix/guix-build

I've also updated my Alpine based dockerfile to use Alpine 3.14, and am currently running through a from-scratch build using that. Using a build invocation like:
time BASE_CACHE="/guix/base_cache" SOURCES_PATH="/guix/sources" SDK_PATH="/guix/SDKs" ./contrib/guix/guix-build.

@dongcarl dongcarl force-pushed the 2021-03-guix-docs branch 2 times, most recently from 6a4f6b6 to d766580 Compare July 12, 2021 16:55
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK, running through the Build from source instructions now

dongcarl added a commit to dongcarl/bitcoin that referenced this pull request Jul 15, 2021
@dongcarl dongcarl force-pushed the 2021-03-guix-docs branch from d766580 to 181ba75 Compare July 15, 2021 00:27
@laanwj
Copy link
Member

laanwj commented Jul 15, 2021

ACK 181ba75

Copy link
Contributor

@kallewoof kallewoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 181ba75

Will attempt to follow instructions on my Mac.

dongcarl added 6 commits July 19, 2021 18:24
- Added detailed Guix bootstrap/installation instructions
That way we can easily combine the document and detached signature to
produce cleartext signature files for upload during the release process.

See subsequent commits which modify doc/release-process.md for more
details.
Also, clean up release-process.md
@dongcarl dongcarl force-pushed the 2021-03-guix-docs branch from 181ba75 to fac4814 Compare July 19, 2021 22:25
@dongcarl
Copy link
Contributor Author

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fac4814 - going to go ahead and merge this now. It's a lot of documentation, and could probably be nit-picked / improved further, however, that can continue over the next few weeks. I'm sure more (backportable) improvements / clarifications will be made while we progress through RCs towards a new release.

@fanquake fanquake merged commit e7441a6 into bitcoin:master Jul 20, 2021
<!-- ``` -->
<!-- apt update -->
<!-- apt show guile-git -->
<!-- ``` -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

systems to build packages from source will be helpful. *hic sunt dracones.*

I strongly urge you to at least skim through the entire section once before you
start issuing commands, as it will save you a lot of unncessary pain and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: unncessary ==> unnecessary


For reference, the graphic below outlines Guix v1.3.0's dependency graph:

![boostrap map](https://user-images.githubusercontent.com/6399679/125064185-a9a59880-e0b0-11eb-82c1-9b8e5dc9950d.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: boostrap ==> bootstrap

josibake pushed a commit to josibake/bitcoin that referenced this pull request Jul 21, 2021
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jul 22, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 23, 2021
janus pushed a commit to BitgesellOfficial/bitgesell that referenced this pull request Nov 5, 2021
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.