build: Do not opt-in unused CoreWLAN stuff in depends for macOS #21497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitian build:Guix build: |
fanquake
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
ACK 810b131 - Only obvious difference I could see in the build is skipping a configure check.
Guix:
53f9ccf344e82e5bd76fa1ddb84be659f026ee267741f480869ae97dc103518c output/bitcoin-810b1310d617-osx-unsigned.dmg
be07fd079ed96c5c760783ce10119a3101cf92cf8175f56d6f2858c387943ad5 output/bitcoin-810b1310d617-osx-unsigned.tar.gz
2cf3e1028d96322b1f263d57d6a3f5a3a8d736600c1a16ec21627c2dc31d08f7 output/bitcoin-810b1310d617-osx64.tar.gz
8b1865ec89b25183c6fb7a7b4bdaf5c35d0645235d409badce6cb2e38364fb13 output/src/bitcoin-810b1310d617.tar.gzGitian
Generating report
8b390310dc632a6da8325bf9128097c108abab69c3f2eac3870128f58c518ed7 bitcoin-810b1310d617-osx-unsigned.dmg
4dc59bd29edccbca1b1d4ab6f206997d8afbc2304fc7f939d1047684c47b89c2 bitcoin-810b1310d617-osx-unsigned.tar.gz
64e63902ef654b89d1039068a2605b90a16d8a1d07bfa233c52ea75627d04e70 bitcoin-810b1310d617-osx64.tar.gz
8b1865ec89b25183c6fb7a7b4bdaf5c35d0645235d409badce6cb2e38364fb13 src/bitcoin-810b1310d617.tar.gz
ce11429fd567c1bc27cd091138fe78396614361bd3efb32498fbaf695f0dcdc9 bitcoin-core-osx-22-res.yml
Done.|
Concept ACK Dependencies are part of the attack surface in some sense, and attack surface reduction is good by definition :) |
This is because |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 23, 2021
…pends for macOS 810b131 build: Do not build unused CoreWLAN stuff in depends for macOS (Hennadii Stepanov) Pull request description: We [do not use](https://github.com/bitcoin/bitcoin/blob/d2a78ee9288e4d3bace9125bcfae6b7747f85982/contrib/devtools/symbol-check.py#L96-L111) any macOS CoreWLAN Framework stuff. Changes in Qt Configure summary with `HOST=x86_64-apple-darwin18`: ```diff --- wlan-master/summary2021-03-22 00:26:04.377387806 +0200 +++ wlan-pr/summary2021-03-22 00:37:07.060997990 +0200 @@ -49,7 +49,7 @@ slog2 ................................ no Using system PCRE2 ..................... no Qt Network: - CoreWLan ............................... yes + CoreWLan ............................... no getifaddrs() ........................... yes IPv6 ifname ............................ yes libproxy ............................... no ``` ACKs for top commit: fanquake: ACK 810b131 - Only obvious difference I could see in the build is skipping a configure check. Tree-SHA512: 54e177c4ad528ef48cc80c3a39ab1b66267dd0ca4fe6cc4f70579c87b74051a04ebeeca1a26afee7fc29f750af456804578abbe7e8a9ad2717297291f206547e
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 17, 2022
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 18, 2022
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 25, 2022
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 25, 2022
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 26, 2022
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not use any macOS CoreWLAN Framework stuff.
Changes in Qt Configure summary with
HOST=x86_64-apple-darwin18: