Skip to content

Conversation

jonatack
Copy link
Member

@jonatack jonatack commented Mar 7, 2021

No description provided.

@fanquake fanquake added the Docs label Mar 7, 2021
@jonatack jonatack changed the title doc: add signet to share/examples/bitcoin.conf doc: add signet to bitcoin.conf documentation Mar 7, 2021
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4a28510 🥃

Clean addition of signet to bitcoin-conf.md and the example bitcoin.conf file

I do think 21b6a23 should mention that you make a small text fix-up unrelated to signet on line 11 of the example bitcoin.conf file.

Copy link
Contributor

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4a28510

@maflcko maflcko merged commit e797388 into bitcoin:master Mar 8, 2021
@jonatack jonatack deleted the add-signet-to-bitcoin-conf branch March 8, 2021 07:35
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 8, 2021
@jonatack
Copy link
Member Author

Should this be backported to 0.21.1?

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Mar 21, 2021
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Mar 21, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants