Skip to content

build: Make AM_CONDITIONAL([ENABLE_EXTERNAL_SIGNER]) unconditional #21339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2021
Merged

build: Make AM_CONDITIONAL([ENABLE_EXTERNAL_SIGNER]) unconditional #21339

merged 2 commits into from
Mar 3, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Mar 2, 2021

#16546 introduced a regression in the configure:

$ ./autogen.sh
$ ./configure --disable-wallet --without-utils --without-daemon --without-gui --disable-tests --disable-bench
...
checking whether to build test_bitcoin... no
checking whether to reduce exports... no
checking that generated files are newer than configure... done
configure: error: conditional "ENABLE_EXTERNAL_SIGNER" was never defined.
Usually this means the macro was only invoked conditionally.

This PR fixes this bug, and refactors indentation to make easier to spot similar bugs in the future.

hebasto added 2 commits March 2, 2021 18:55
@hebasto
build, refactor: Fix indentation for if..then..fi
9fef209 
This makes easier to spot conditional macros.
@hebasto
build: Make AM_CONDITIONAL([ENABLE_EXTERNAL_SIGNER]) unconditional
a412813 
This change fixes an error when the value of the "use_boost" variable is
equal to "no".
@hebasto hebasto mentioned this pull request Mar 2, 2021
Merged
2 tasks
@hebasto
Copy link
Member Author

hebasto commented Mar 2, 2021

cc @Sjors

@Sjors
Copy link
Member

Sjors commented Mar 2, 2021

utACK a412813

@hebasto hebasto mentioned this pull request Mar 2, 2021
Closed
fanquake
fanquake approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a412813 - this fixes the bug described, and improves readability.

@fanquake fanquake merged commit 4f223e9 into bitcoin:master Mar 3, 2021
@hebasto hebasto deleted the 210302-signer branch March 3, 2021 06:30
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 3, 2021
@fanquake
Merge bitcoin#21339: build: Make AM_CONDITIONAL([ENABLE_EXTERNAL_SIGN…
6dcbd09 
…ER]) un…
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanquake fanquake fanquake approved these changes

Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hebasto @Sjors @fanquake @maflcko @DrahtBot