guix: Update darwin native packages dependencies #21337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guix build: |
|
cr ACK d8b4e3b: patch looks correct |
|
Updated d8b4e3b -> 7bbb409 (pr21337.01 -> pr21337.02, diff): |
|
Guix build: |
fanquake
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
ACK 7bbb409 - thanks for noticing the leftovers. This looks ok to me. Guix builds look like they are matching:
bash-5.1# find output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
ff897bb2b361a3e6e8d9a96add8010061b09bb5c0f880a7e86dd716da18d8f4a output/bitcoin-7bbb409314c6-osx-unsigned.dmg
1b60543e7b9e5e4ea40cf4e454cea1d7570e7b814760b142a7f0f4de428e96d8 output/bitcoin-7bbb409314c6-osx-unsigned.tar.gz
c2a7960e19f06ed2f78b50e88c099956e590c4559026f2f68e92d1d7b28d5eba output/bitcoin-7bbb409314c6-osx64.tar.gz
fb01097e36dc0b594c267bbd7ed222a24ce34f98c32be533eaaa8aab462189b1 output/src/bitcoin-7bbb409314c6.tar.gz|
Concept ACK 7bbb409 Lovely! |
|
Updated 7bbb409 -> c967fb7 (pr21337.02 -> pr21337.03, diff):
Guix build: |
fanquake
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
ACK c967fb7
Guix builds at c967fb7:
bash-5.1# find output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
2cece5e8cc7c5e97ea9691788b02fcc2b7b5a791db12de8e0ef0655ecbfe694d output/bitcoin-c967fb7fb97a-osx-unsigned.dmg
b3c4f71a656ac1873a12b4a080d2cbc93b7e221ea298ebdb393b397c2c36d76e output/bitcoin-c967fb7fb97a-osx-unsigned.tar.gz
b0244e16d42f606f91de9dc455c33b01341f03733a0c48c9b2db27a98d02afb7 output/bitcoin-c967fb7fb97a-osx64.tar.gz
2f8d12a78e03f9a3d2971fb9bc8ff9794587557b02a6773992df860041e989d3 output/src/bitcoin-c967fb7fb97a.tar.gz
It looks like my |
|
@laanwj that same difference is also popping up elsewhere, and iirc is related to the last Guix update. It should be fixed in the one of the next Guix PRs, but shouldn't block changes here. |
|
Ok, good to know, will continue to merge this then. I just hoped posting the output would be useful to resolve determinism issues. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 4, 2021
c967fb7 guix: Remove libcap from manifest (Hennadii Stepanov) 7bbb409 guix: Update darwin native packages dependencies (Hennadii Stepanov) Pull request description: It is a bitcoin#20470 follow up. ACKs for top commit: fanquake: ACK c967fb7 Tree-SHA512: 66ce05770f578ba61a44c58747c5a2669f425a989ed987838058bd86e3b49e342ac5a4f8852fc49f2b3a86b58fb6a340fdf3e34c1fc19bdab910729febba4bc7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a #20470 follow up.