guix: Bump time-machine, glibc, and linux-headers #21298

dongcarl · 2021-02-25T03:02:39Z

On bumping the time-machine:

A few changes which are useful for us:

1. 'gnu: cross-gcc-arguments: Enable 128 bit long double for POWER9.' is
   now merged into master.
2. gnutls is bumped to 3.6.15 and the temporal test failure in
   status-request-revoked is fixed. Note that this does not fix the case
   where one has installed Guix v1.2.0 and is running a substitute-less
   bootstrap build, since the `guix time-machine` command itself has a
   dependency on gnutls v3.6.12 (the one with the broken test) and will
   thus try to build it before attempting to jump forwards in time. This
   does however, mean that those who build a version of Guix that also
   contains this fix will not go backwards in time to build the broken
   gnutls v3.6.12.

On bumping the rest:

Bump glibc and linux-headers to match those of our Gitian counterparts.

We also require a glibc >= 2.28 for the test-symbol-check scripts to
work properly.

The default BASE-GCC-FOR-LIBC also has to be bumped since glibc 2.31
requires a gcc >= 6.2

This is a prerequisite for #20980

A few changes which are useful for us: 1. 'gnu: cross-gcc-arguments: Enable 128 bit long double for POWER9.' is now merged into master. 2. gnutls is bumped to 3.6.15 and the temporal test failure in status-request-revoked is fixed. Note that this does not fix the case where one has installed Guix v1.2.0 and is running a substitute-less bootstrap build, since the `guix time-machine` command itself has a dependency on gnutls v3.6.12 (the one with the broken test) and will thus try to build it before attempting to jump forwards in time. This does however, mean that those who build a version of Guix that also contains this fix will not go backwards in time to build the broken gnutls v3.6.12.

Bump glibc and linux-headers to match those of our Gitian counterparts. We also require a glibc >= 2.28 for the test-symbol-check scripts to work properly. The default BASE-GCC-FOR-LIBC also has to be bumped since glibc 2.31 requires a gcc >= 6.2

laanwj · 2021-02-25T08:17:10Z

'gnu: cross-gcc-arguments: Enable 128 bit long double for POWER9.' is now merged into master.

This is about the floating point type, right, not uint128? I don't think that's useful to us.

Concept ACK otherwise of course, will do a build.

DrahtBot · 2021-02-25T08:34:06Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

guix: Add codesignature attachment support for osx+win #21239 (guix: Add codesignature attachment support for osx+win by dongcarl)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake · 2021-02-25T09:15:00Z

Builds at c33b199:

bash-5.1# guix describe
Generation 6	Feb 23 2021 03:15:31	(current)
  guix 11f11d7
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 11f11d7ecb817d1421f8b5340bcced59396d8708

bash-5.1# git rev-parse HEAD
c33b199456e57d83c21eacd36d3c56d0a123b0d0

bash-5.1# find output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
bb2b44203b4af1625e1c9b07f4e85c22b5e337090c5e765bc574b5502cd77f92  output/bitcoin-c33b199456e5-aarch64-linux-gnu-debug.tar.gz
6f60c9a48099338900db97095a7e583282335f8c423e0ad9eb25c33243be09e8  output/bitcoin-c33b199456e5-aarch64-linux-gnu.tar.gz
6cd56b320a8ff3daf79d3939485bb39c0d8c55b9296e2af09739cd3e47c522b6  output/bitcoin-c33b199456e5-arm-linux-gnueabihf-debug.tar.gz
8e26711bc2619f2fda91f0b9182ee3a8b80766b8e9c9a21cbe56a897dc87aa06  output/bitcoin-c33b199456e5-arm-linux-gnueabihf.tar.gz
35df83ad514e980e734680136ae58eb8ec2bd8db8147d55c66a4fc6ee4fd80d2  output/bitcoin-c33b199456e5-osx-unsigned.dmg
6b1b69b3831b2af5702713aa28e733397d4560a173f5da86b5b42aee5a3507de  output/bitcoin-c33b199456e5-osx-unsigned.tar.gz
febde5b7d1844ab686716fe9532111c8628e8be31e9ca3768baf54d758f63075  output/bitcoin-c33b199456e5-osx64.tar.gz
5768f5eda41aaf5b443f13aa81d1c78111cdb3ca606374254473e13e2ecf2efe  output/bitcoin-c33b199456e5-powerpc64-linux-gnu-debug.tar.gz
b6a0af9a6164e7482ccca85b55fc49d6873734667fca0ce8f620e35137712cf2  output/bitcoin-c33b199456e5-powerpc64-linux-gnu.tar.gz
90f8d024ca5a13cba084caba4548cb98254639e2eb7918e75862a34688e4b63a  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu-debug.tar.gz
5278e69c06416c905f0fb4f15145a707ca90d555e82c1c96b988249a1ec9b5de  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu.tar.gz
e4900927db72cc735cd1c221671b1edcfff84236246dd1e352571f102e2173f6  output/bitcoin-c33b199456e5-riscv64-linux-gnu-debug.tar.gz
1658fc94fce4568dd5b67af6b7a9dd2f063093273bc0f23a6255b912d600f69e  output/bitcoin-c33b199456e5-riscv64-linux-gnu.tar.gz
f65ef72789ab07352b5bd979ae18ff9f7a6ac01149e6f6c55329deb89516c4bf  output/bitcoin-c33b199456e5-win-unsigned.tar.gz
8aaef7683c89f3eaca7938fed7db22b298d8604c4c684ab627425d5adfc0aabf  output/bitcoin-c33b199456e5-win64-debug.zip
a8bc78c942f2393186763668806a93b0e931f5d7572be4e471a77de6283ca507  output/bitcoin-c33b199456e5-win64-setup-unsigned.exe
85675b096b3d15e1d8ceb4b085ec13f161c323143f949a42701b9676e6e0ce7d  output/bitcoin-c33b199456e5-win64.zip
cc97540d65f31ee492af9d30f687f7ea93dcd18f256f5430427f370560798069  output/bitcoin-c33b199456e5-x86_64-linux-gnu-debug.tar.gz
6565c7fc7fa6604150a0dbb54438493ae2acf1bdb1a2e846cef87894e79202ac  output/bitcoin-c33b199456e5-x86_64-linux-gnu.tar.gz
30a584b15c406e76e784bc81aace6db7eac0642da8c289bd3009d071510266d9  output/src/bitcoin-c33b199456e5.tar.gz

maflcko · 2021-02-25T13:39:09Z

I am wondering what is the best way to review this. Maybe you could share a command that prints the diff of the packages we use in the build that are affected as part of the bump?

dongcarl · 2021-02-25T16:05:59Z

'gnu: cross-gcc-arguments: Enable 128 bit long double for POWER9.' is now merged into master.

This is about the floating point type, right, not uint128? I don't think that's useful to us.

Actually, according to the comment in that commit, we do need it: "on POWER9 (little endian) glibc needs the 128 bit long double type." I've also ran into this problem before when naively compiling powerpc64le glibc with a gcc that was not configured with --with-long-double-128.

dongcarl · 2021-02-25T16:08:37Z

I am wondering what is the best way to review this. Maybe you could share a command that prints the diff of the packages we use in the build that are affected as part of the bump?

I've asked on #guix IRC, and there doesn't seem to be a built-in way to do this yet. The only close approximation is:

$ guix time-machine --commit=6c9d16db962a6f7155571b36eced681fd2889e23 \
                    --url=https://github.com/dongcarl/guix.git \
                    -- pull --dry-run --news \
                            --commit=490e39ff303f4f6873a04bfb8253755bdae1b29c \
                            --url=https://github.com/dongcarl/guix.git

However that shows the news for every single package changed between two commits...

I will add this to my notes, as I suspect what you're asking for can be scripted in Guile without too many modifications to Guix itself.

sipa · 2021-02-26T01:12:46Z

Ubuntu 21.04 on x86_64 machine; guix 1.2.0 installed through package manager.


$ find output/ -type f -print | fgrep c33b199456e5 | env LC_ALL=C sort | xargs sha256sum
bb2b44203b4af1625e1c9b07f4e85c22b5e337090c5e765bc574b5502cd77f92  output/bitcoin-c33b199456e5-aarch64-linux-gnu-debug.tar.gz
6f60c9a48099338900db97095a7e583282335f8c423e0ad9eb25c33243be09e8  output/bitcoin-c33b199456e5-aarch64-linux-gnu.tar.gz
6cd56b320a8ff3daf79d3939485bb39c0d8c55b9296e2af09739cd3e47c522b6  output/bitcoin-c33b199456e5-arm-linux-gnueabihf-debug.tar.gz
8e26711bc2619f2fda91f0b9182ee3a8b80766b8e9c9a21cbe56a897dc87aa06  output/bitcoin-c33b199456e5-arm-linux-gnueabihf.tar.gz
35df83ad514e980e734680136ae58eb8ec2bd8db8147d55c66a4fc6ee4fd80d2  output/bitcoin-c33b199456e5-osx-unsigned.dmg
6b1b69b3831b2af5702713aa28e733397d4560a173f5da86b5b42aee5a3507de  output/bitcoin-c33b199456e5-osx-unsigned.tar.gz
febde5b7d1844ab686716fe9532111c8628e8be31e9ca3768baf54d758f63075  output/bitcoin-c33b199456e5-osx64.tar.gz
5768f5eda41aaf5b443f13aa81d1c78111cdb3ca606374254473e13e2ecf2efe  output/bitcoin-c33b199456e5-powerpc64-linux-gnu-debug.tar.gz
b6a0af9a6164e7482ccca85b55fc49d6873734667fca0ce8f620e35137712cf2  output/bitcoin-c33b199456e5-powerpc64-linux-gnu.tar.gz
90f8d024ca5a13cba084caba4548cb98254639e2eb7918e75862a34688e4b63a  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu-debug.tar.gz
5278e69c06416c905f0fb4f15145a707ca90d555e82c1c96b988249a1ec9b5de  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu.tar.gz
e4900927db72cc735cd1c221671b1edcfff84236246dd1e352571f102e2173f6  output/bitcoin-c33b199456e5-riscv64-linux-gnu-debug.tar.gz
1658fc94fce4568dd5b67af6b7a9dd2f063093273bc0f23a6255b912d600f69e  output/bitcoin-c33b199456e5-riscv64-linux-gnu.tar.gz
f65ef72789ab07352b5bd979ae18ff9f7a6ac01149e6f6c55329deb89516c4bf  output/bitcoin-c33b199456e5-win-unsigned.tar.gz
8aaef7683c89f3eaca7938fed7db22b298d8604c4c684ab627425d5adfc0aabf  output/bitcoin-c33b199456e5-win64-debug.zip
a8bc78c942f2393186763668806a93b0e931f5d7572be4e471a77de6283ca507  output/bitcoin-c33b199456e5-win64-setup-unsigned.exe
85675b096b3d15e1d8ceb4b085ec13f161c323143f949a42701b9676e6e0ce7d  output/bitcoin-c33b199456e5-win64.zip
cc97540d65f31ee492af9d30f687f7ea93dcd18f256f5430427f370560798069  output/bitcoin-c33b199456e5-x86_64-linux-gnu-debug.tar.gz
6565c7fc7fa6604150a0dbb54438493ae2acf1bdb1a2e846cef87894e79202ac  output/bitcoin-c33b199456e5-x86_64-linux-gnu.tar.gz
30a584b15c406e76e784bc81aace6db7eac0642da8c289bd3009d071510266d9  output/src/bitcoin-c33b199456e5.tar.gz

laanwj · 2021-02-26T15:19:49Z

My build output. Checked they match @sipa and @fanquake's

bb2b44203b4af1625e1c9b07f4e85c22b5e337090c5e765bc574b5502cd77f92  output/bitcoin-c33b199456e5-aarch64-linux-gnu-debug.tar.gz
6f60c9a48099338900db97095a7e583282335f8c423e0ad9eb25c33243be09e8  output/bitcoin-c33b199456e5-aarch64-linux-gnu.tar.gz
6cd56b320a8ff3daf79d3939485bb39c0d8c55b9296e2af09739cd3e47c522b6  output/bitcoin-c33b199456e5-arm-linux-gnueabihf-debug.tar.gz
8e26711bc2619f2fda91f0b9182ee3a8b80766b8e9c9a21cbe56a897dc87aa06  output/bitcoin-c33b199456e5-arm-linux-gnueabihf.tar.gz
35df83ad514e980e734680136ae58eb8ec2bd8db8147d55c66a4fc6ee4fd80d2  output/bitcoin-c33b199456e5-osx-unsigned.dmg
6b1b69b3831b2af5702713aa28e733397d4560a173f5da86b5b42aee5a3507de  output/bitcoin-c33b199456e5-osx-unsigned.tar.gz
febde5b7d1844ab686716fe9532111c8628e8be31e9ca3768baf54d758f63075  output/bitcoin-c33b199456e5-osx64.tar.gz
5768f5eda41aaf5b443f13aa81d1c78111cdb3ca606374254473e13e2ecf2efe  output/bitcoin-c33b199456e5-powerpc64-linux-gnu-debug.tar.gz
b6a0af9a6164e7482ccca85b55fc49d6873734667fca0ce8f620e35137712cf2  output/bitcoin-c33b199456e5-powerpc64-linux-gnu.tar.gz
90f8d024ca5a13cba084caba4548cb98254639e2eb7918e75862a34688e4b63a  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu-debug.tar.gz
5278e69c06416c905f0fb4f15145a707ca90d555e82c1c96b988249a1ec9b5de  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu.tar.gz
e4900927db72cc735cd1c221671b1edcfff84236246dd1e352571f102e2173f6  output/bitcoin-c33b199456e5-riscv64-linux-gnu-debug.tar.gz
1658fc94fce4568dd5b67af6b7a9dd2f063093273bc0f23a6255b912d600f69e  output/bitcoin-c33b199456e5-riscv64-linux-gnu.tar.gz
f65ef72789ab07352b5bd979ae18ff9f7a6ac01149e6f6c55329deb89516c4bf  output/bitcoin-c33b199456e5-win-unsigned.tar.gz
8aaef7683c89f3eaca7938fed7db22b298d8604c4c684ab627425d5adfc0aabf  output/bitcoin-c33b199456e5-win64-debug.zip
a8bc78c942f2393186763668806a93b0e931f5d7572be4e471a77de6283ca507  output/bitcoin-c33b199456e5-win64-setup-unsigned.exe
85675b096b3d15e1d8ceb4b085ec13f161c323143f949a42701b9676e6e0ce7d  output/bitcoin-c33b199456e5-win64.zip
cc97540d65f31ee492af9d30f687f7ea93dcd18f256f5430427f370560798069  output/bitcoin-c33b199456e5-x86_64-linux-gnu-debug.tar.gz
6565c7fc7fa6604150a0dbb54438493ae2acf1bdb1a2e846cef87894e79202ac  output/bitcoin-c33b199456e5-x86_64-linux-gnu.tar.gz
30a584b15c406e76e784bc81aace6db7eac0642da8c289bd3009d071510266d9  output/src/bitcoin-c33b199456e5.tar.gz

sipa · 2021-02-26T21:18:29Z

My Debian VM with guix-master-branch-built-from-source has a mismatch on output/bitcoin-c33b199456e5-osx-unsigned.tar.gz. This appears to be purely due to codesign_allocate and pagestuff differing, which are files we don't need anymore (right, @achow101?).

@dongcarl is looking into what is causing the difference.

achow101 · 2021-02-26T21:32:12Z

Since even gitian is using signapple, and using the version that doesn't rely on codesign_allocate, codesign_allocate and pagestuff are entirely unnecessary now.

DrahtBot · 2021-02-28T18:35:14Z

Guix builds

File	commit `5ba5bec` (master)	commit `d45a567` (master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`5f74435231e17632...`	`9bbcd3416285050b...`
*-aarch64-linux-gnu.tar.gz	`a71e54c9b627c295...`	`5158fcf379a24458...`
*-arm-linux-gnueabihf-debug.tar.gz	`adf10a3ead42e9ba...`	`a7b70cb21514f233...`
*-arm-linux-gnueabihf.tar.gz	`382c9a8f3d796ba3...`	`156cbbcfa4f6877f...`
*-osx-unsigned.dmg	`751e49d27e9dccd4...`	`6101e0e8d010ca70...`
*-osx-unsigned.tar.gz	`4a9c99658847a4cc...`	`8875444fa9d290e1...`
*-osx64.tar.gz	`6151d4880a9f291d...`	`b21c4af729caf48f...`
*-powerpc64-linux-gnu-debug.tar.gz	`4b78706c37822742...`	`e151deee4853e646...`
*-powerpc64-linux-gnu.tar.gz	`9a4d5bf59567ef5d...`	`e0e08931d3484a99...`
*-powerpc64le-linux-gnu-debug.tar.gz	`f2e6b7c6ab0370e4...`	`da66361b3d52385f...`
*-powerpc64le-linux-gnu.tar.gz	`335d84ca8cba4211...`	`ab2f5fffd3c270bc...`
*-riscv64-linux-gnu-debug.tar.gz	`e7eb25c4573e8cce...`	`313b0ffba6c45eae...`
*-riscv64-linux-gnu.tar.gz	`f41946c7ae5c3350...`	`5d2bc853455ed879...`
*-win-unsigned.tar.gz	`243be5c40837f82e...`	`7e3c6d4e9544ea4d...`
*-win64-debug.zip	`5f954f624f268072...`	`1b5a81d3e94239c6...`
*-win64-setup-unsigned.exe	`780312bdd9940cfb...`	`d99a842436eaf144...`
*-win64.zip	`2e3e1e98973df7de...`	`6b59e4f9cc960965...`
*-x86_64-linux-gnu-debug.tar.gz	`83181be936b817e5...`	`9371d69561cee941...`
*-x86_64-linux-gnu.tar.gz	`b79145fbd0267974...`	`8fd197adf6ea9b58...`
*.tar.gz	`0784b3d773e5761f...`	`38b1ff0110161e67...`
guix_build.log	`752e44aa2f570812...`	`1b255b82545af90f...`
guix_build.log.diff		`4754f5613e222976...`

fanquake

ACK c33b199 - I think going ahead with this now and to sycn back up to gitian is fine. It will also unblock #20980. Potential code signing related issues can be sorted out in #21239 and later PRs.

dongcarl · 2021-03-02T01:35:53Z

I think this PR is ready for merge, I've noted two things that needs attention that are separate from this PR:

Native depends binaries have a non-reproducibility in their RUNPATH section, most likely due to Guix's ld wrapper for native binaries not being disabled for darwin. This does not affect us at all once we remove the two tools from our unsigned tarball and use applesign, but I will investigate with upstream.
Nice-to-have: a way to review derivation changes as a result of time-machine bumps but limited to one manifest and not the whole Guix package set.

hebasto · 2021-03-02T10:55:44Z

$ lsb_release -dc
Description:	Ubuntu Hirsute Hippo (development branch)
Codename:	hirsute
$ dpkg --status guix | head -9
Package: guix
Status: install ok installed
Priority: optional
Section: admin
Installed-Size: 261656
Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
Architecture: amd64
Multi-Arch: foreign
Version: 1.2.0-3
$ git clean -xdff --exclude='/depends/SDKs/*'
$ time ./contrib/guix/guix-build.sh
...
real	237m47,159s
user	514m29,652s
sys	45m14,712s
$ find output -type f -print0 | sort -z | xargs -r0 sha256sum
bb2b44203b4af1625e1c9b07f4e85c22b5e337090c5e765bc574b5502cd77f92  output/bitcoin-c33b199456e5-aarch64-linux-gnu-debug.tar.gz
6f60c9a48099338900db97095a7e583282335f8c423e0ad9eb25c33243be09e8  output/bitcoin-c33b199456e5-aarch64-linux-gnu.tar.gz
6cd56b320a8ff3daf79d3939485bb39c0d8c55b9296e2af09739cd3e47c522b6  output/bitcoin-c33b199456e5-arm-linux-gnueabihf-debug.tar.gz
8e26711bc2619f2fda91f0b9182ee3a8b80766b8e9c9a21cbe56a897dc87aa06  output/bitcoin-c33b199456e5-arm-linux-gnueabihf.tar.gz
febde5b7d1844ab686716fe9532111c8628e8be31e9ca3768baf54d758f63075  output/bitcoin-c33b199456e5-osx64.tar.gz
35df83ad514e980e734680136ae58eb8ec2bd8db8147d55c66a4fc6ee4fd80d2  output/bitcoin-c33b199456e5-osx-unsigned.dmg
095fb20b17783a0672c3c742721de2df9348299ce98204e63eb9b20922211eea  output/bitcoin-c33b199456e5-osx-unsigned.tar.gz
90f8d024ca5a13cba084caba4548cb98254639e2eb7918e75862a34688e4b63a  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu-debug.tar.gz
5278e69c06416c905f0fb4f15145a707ca90d555e82c1c96b988249a1ec9b5de  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu.tar.gz
5768f5eda41aaf5b443f13aa81d1c78111cdb3ca606374254473e13e2ecf2efe  output/bitcoin-c33b199456e5-powerpc64-linux-gnu-debug.tar.gz
b6a0af9a6164e7482ccca85b55fc49d6873734667fca0ce8f620e35137712cf2  output/bitcoin-c33b199456e5-powerpc64-linux-gnu.tar.gz
e4900927db72cc735cd1c221671b1edcfff84236246dd1e352571f102e2173f6  output/bitcoin-c33b199456e5-riscv64-linux-gnu-debug.tar.gz
1658fc94fce4568dd5b67af6b7a9dd2f063093273bc0f23a6255b912d600f69e  output/bitcoin-c33b199456e5-riscv64-linux-gnu.tar.gz
8aaef7683c89f3eaca7938fed7db22b298d8604c4c684ab627425d5adfc0aabf  output/bitcoin-c33b199456e5-win64-debug.zip
a8bc78c942f2393186763668806a93b0e931f5d7572be4e471a77de6283ca507  output/bitcoin-c33b199456e5-win64-setup-unsigned.exe
85675b096b3d15e1d8ceb4b085ec13f161c323143f949a42701b9676e6e0ce7d  output/bitcoin-c33b199456e5-win64.zip
f65ef72789ab07352b5bd979ae18ff9f7a6ac01149e6f6c55329deb89516c4bf  output/bitcoin-c33b199456e5-win-unsigned.tar.gz
cc97540d65f31ee492af9d30f687f7ea93dcd18f256f5430427f370560798069  output/bitcoin-c33b199456e5-x86_64-linux-gnu-debug.tar.gz
6565c7fc7fa6604150a0dbb54438493ae2acf1bdb1a2e846cef87894e79202ac  output/bitcoin-c33b199456e5-x86_64-linux-gnu.tar.gz
30a584b15c406e76e784bc81aace6db7eac0642da8c289bd3009d071510266d9  output/src/bitcoin-c33b199456e5.tar.gz

hebasto · 2021-06-27T04:56:27Z

We also require a glibc >= 2.28 for the test-symbol-check scripts to
work properly.

Does this sound a little dubious just to me?

dongcarl · 2021-06-28T18:50:35Z

@hebasto Sorry, I should have been more specific, here is the check that fails:

bitcoin/contrib/devtools/test-symbol-check.py

Lines 12 to 45 in 3f56ef7

    
           def call_symbol_check(cc, source, executable, options): 
        
               subprocess.run([cc,source,'-o',executable] + options, check=True) 
        
               p = subprocess.run(['./contrib/devtools/symbol-check.py',executable], stdout=subprocess.PIPE, universal_newlines=True) 
        
               os.remove(source) 
        
               os.remove(executable) 
        
               return (p.returncode, p.stdout.rstrip()) 
        
           class TestSymbolChecks(unittest.TestCase): 
        
               def test_ELF(self): 
        
                   source = 'test1.c' 
        
                   executable = 'test1' 
        
                   cc = 'gcc' 
        
                   # renameat2 was introduced in GLIBC 2.28, so is newer than the upper limit 
        
                   # of glibc for all platforms 
        
                   with open(source, 'w', encoding="utf8") as f: 
        
                       f.write(''' 
        
                           #define _GNU_SOURCE 
        
                           #include <stdio.h> 
        
                           #include <linux/fs.h> 
        
                           int renameat2(int olddirfd, const char *oldpath, 
        
                               int newdirfd, const char *newpath, unsigned int flags); 
        
                           int main() 
        
                           { 
        
                               renameat2(0, "test", 0, "test_", RENAME_EXCHANGE); 
        
                               return 0; 
        
                           } 
        
                   ''') 
        
                   self.assertEqual(call_symbol_check(cc, source, executable, []), 
        
                           (1, executable + ': symbol renameat2 from unsupported version GLIBC_2.28\n' + 
        
                               executable + ': failed IMPORTED_SYMBOLS'))

The call to symbol-check.py is supposed to return an error code because renameat2 is referenced"

bitcoin/contrib/devtools/test-symbol-check.py

Line 14 in 3f56ef7

    
           p = subprocess.run(['./contrib/devtools/symbol-check.py',executable], stdout=subprocess.PIPE, universal_newlines=True)

but when building against a toolchain with glibc < 2.28, the compilation will fail earlier:

bitcoin/contrib/devtools/test-symbol-check.py

Line 13 in 3f56ef7

subprocess.run([cc,source,'-o',executable] + options, check=True)

dongcarl added 2 commits February 24, 2021 21:14

guix: Bump glibc and linux-headers

c33b199

Bump glibc and linux-headers to match those of our Gitian counterparts. We also require a glibc >= 2.28 for the test-symbol-check scripts to work properly. The default BASE-GCC-FOR-LIBC also has to be bumped since glibc 2.31 requires a gcc >= 6.2

fanquake added Build system DrahtBot Guix build requested labels Feb 25, 2021

DrahtBot mentioned this pull request Feb 25, 2021

guix: Add codesignature attachment support for osx+win #21239

Merged

DrahtBot removed the DrahtBot Guix build requested label Feb 28, 2021

fanquake approved these changes Mar 2, 2021

View reviewed changes

fanquake merged commit a28c053 into bitcoin:master Mar 2, 2021

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 2, 2021

Merge bitcoin#21298: guix: Bump time-machine, glibc, and linux-headers

f1e0f4f

maflcko mentioned this pull request Apr 24, 2021

Guix Release Transition Plan for 22.0 #21145

Closed

15 tasks

bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022

guix: Bump time-machine, glibc, and linux-headers #21298

guix: Bump time-machine, glibc, and linux-headers #21298

Uh oh!

Conversation

dongcarl commented Feb 25, 2021

Uh oh!

laanwj commented Feb 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Feb 25, 2021

Conflicts

Uh oh!

fanquake commented Feb 25, 2021

Uh oh!

maflcko commented Feb 25, 2021

Uh oh!

dongcarl commented Feb 25, 2021

Uh oh!

dongcarl commented Feb 25, 2021

Uh oh!

sipa commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Feb 26, 2021

Uh oh!

sipa commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

achow101 commented Feb 26, 2021

Uh oh!

DrahtBot commented Feb 28, 2021

Guix builds

Uh oh!

fanquake left a comment

Choose a reason for hiding this comment

Uh oh!

dongcarl commented Mar 2, 2021

Uh oh!

hebasto commented Mar 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Jun 27, 2021

Uh oh!

dongcarl commented Jun 28, 2021

Uh oh!

Uh oh!

laanwj commented Feb 25, 2021 •

edited

Loading

sipa commented Feb 26, 2021 •

edited

Loading

sipa commented Feb 26, 2021 •

edited

Loading

hebasto commented Mar 2, 2021 •

edited

Loading