Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Feb 23, 2021

Close #20104.

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK faa06ec

Should be a smooth bump

@laanwj
Copy link
Member

laanwj commented Feb 26, 2021

Code review ACK faa06ec

@DrahtBot
Copy link
Contributor

Gitian builds

File commit e491174
(master)
commit 0f05fa9
(master and this pull)
bitcoin-core-linux-22-res.yml b9850adaf9f27982... 4092722e289ea6a1...
bitcoin-core-osx-22-res.yml 8f4c8e3ecd95fdb4... df6b606aeb399dff...
bitcoin-core-win-22-res.yml 59bb108c34ab3b30... d568f227691a9f18...
*-aarch64-linux-gnu-debug.tar.gz 2f8c5e874767048e... ee5a5b156a968447...
*-aarch64-linux-gnu.tar.gz 3f458d5458ca7473... 77b0dcdad4974a51...
*-arm-linux-gnueabihf-debug.tar.gz 050351b02e3cc5f3... a74cfa08281ee995...
*-arm-linux-gnueabihf.tar.gz 13fc85186764f69e... dc56d1c14a76272a...
*-osx-unsigned.dmg fd9e494a5e930369... 39559f21bd7075fd...
*-osx64.tar.gz e6ee47f0a3afa9bb... e8eae1f6180a1aad...
*-powerpc64-linux-gnu-debug.tar.gz 306a8e93142d7513... 856a72d78acb628f...
*-powerpc64-linux-gnu.tar.gz 805c27ed96afe625... 0381efa3bd4527f0...
*-powerpc64le-linux-gnu-debug.tar.gz 5fc166a2ae1460c1... 60418bf10d2e491d...
*-powerpc64le-linux-gnu.tar.gz 3c625482160d6dcb... 886b4db2e26bb4cb...
*-riscv64-linux-gnu-debug.tar.gz 8c04cc3cd05fc965... b75a14c0dcacab2f...
*-riscv64-linux-gnu.tar.gz 68917240c47f8df4... c817254c9766e77a...
*-win64-debug.zip 4b9e9ab881581e9a... cb0167212732a7d5...
*-win64-setup-unsigned.exe bc114ee020582a81... f93ac7f7ee129572...
*-win64.zip 98ad412d7173db47... 03356ce9b99d3564...
*-x86_64-linux-gnu-debug.tar.gz dfaed490268534e6... 2286a52dbf817b05...
*-x86_64-linux-gnu.tar.gz c3073d99069a38d5... 3fac69d3590960f1...
*.tar.gz 7de28abb89c8d5e0... f387a081b3e63f02...
linux-build.log 66532e7c9f4900c1... cb055812c36f3cfe...
osx-build.log 563ba182fefab33c... d1fc44b82b46f37b...
win-build.log 9ce23f7489c3448d... 4ac6e85c204b9bfa...
bitcoin-core-linux-22-res.yml.diff 3598035eeadeb1c5...
bitcoin-core-osx-22-res.yml.diff fedcc1c833a73a43...
bitcoin-core-win-22-res.yml.diff 72bc170dd5c99283...
linux-build.log.diff c78430ab322635d0...
osx-build.log.diff 8abaa19bac5ca3ac...
win-build.log.diff 7ea7163905fb4926...

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK faa06ec - this should be ok to do now.

@fanquake fanquake merged commit e52ce9f into bitcoin:master Feb 28, 2021
@hebasto hebasto deleted the 210223-qtmin branch February 28, 2021 06:54
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 28, 2021
@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 1, 2021

Guix builds

File commit 5ba5bec
(master)
commit 12babf6
(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz 5f74435231e17632... 28d969a25e215ce4...
*-aarch64-linux-gnu.tar.gz a71e54c9b627c295... 92cf21ba642fb0b8...
*-arm-linux-gnueabihf-debug.tar.gz adf10a3ead42e9ba... c562e1119ea36963...
*-arm-linux-gnueabihf.tar.gz 382c9a8f3d796ba3... 32b25b632a6b87be...
*-osx-unsigned.dmg 751e49d27e9dccd4... 72094a9acb15ef2b...
*-osx-unsigned.tar.gz 4a9c99658847a4cc... 2ed9931044734fc6...
*-osx64.tar.gz 6151d4880a9f291d... cb50f693536b28d6...
*-powerpc64-linux-gnu-debug.tar.gz 4b78706c37822742... d1916b998767e700...
*-powerpc64-linux-gnu.tar.gz 9a4d5bf59567ef5d... bb2b1e0e682158e0...
*-powerpc64le-linux-gnu-debug.tar.gz f2e6b7c6ab0370e4... 43a5c55f162405d8...
*-powerpc64le-linux-gnu.tar.gz 335d84ca8cba4211... 9d1662ea65fa16ff...
*-riscv64-linux-gnu-debug.tar.gz e7eb25c4573e8cce... 3f78955cc798355b...
*-riscv64-linux-gnu.tar.gz f41946c7ae5c3350... 6f080f0d264b928f...
*-win-unsigned.tar.gz 243be5c40837f82e... dc46a3e822e8cee7...
*-win64-debug.zip 5f954f624f268072... 24aefa146db5c652...
*-win64-setup-unsigned.exe 780312bdd9940cfb... 1b8074549d53cffa...
*-win64.zip 2e3e1e98973df7de... 4fc4c8e6456edc52...
*-x86_64-linux-gnu-debug.tar.gz 83181be936b817e5... 9224ffe83742bf71...
*-x86_64-linux-gnu.tar.gz b79145fbd0267974... 4d65f519fbc23c9c...
*.tar.gz 0784b3d773e5761f... 44f9d4f37f35560a...
guix_build.log 752e44aa2f570812... 374c62f72616a5ba...
guix_build.log.diff da791863e96701a5...

hebasto added a commit to bitcoin-core/gui that referenced this pull request Apr 20, 2021
16c157d qt, refactor: Use better QMenu::addAction overloaded function (Hennadii Stepanov)
7931175 qt: Do not assign Alt+<KEY> shortcuts to context menu actions (Hennadii Stepanov)
963e120 qt: Drop menu separator that separates nothing (Hennadii Stepanov)
1398a65 qt, refactor: Make AddressBookPage::deleteAction a local variable (Hennadii Stepanov)

Pull request description:

  This PR:
  1. removes useless `Alt` + `<KEY>` shortcuts from context menu items
  2. replaces 3 lines of code with the only call of [`QMenu::addAction`](https://doc.qt.io/qt-5/qmenu.html#addAction-5) for each context menu item (it became possible since bitcoin/bitcoin#21286 was merged)
  3. makes other minor cleanups

  No behavior change.

ACKs for top commit:
  kristapsk:
    ACK 16c157d
  promag:
    Code review ACK 16c157d. Nice code cleanup that takes advantage of more recent Qt API.
  jarolrod:
    ACK 16c157d

Tree-SHA512: e5555fe957058cc67b351aaf9f09fe3635edb2d07a2223d3093913a25607ae538f0a2fde84c0b0cd43e7475b248949548eb4a5d4b21d8f7391fa2fa8541c04ff
hebasto added a commit to bitcoin-core/gui that referenced this pull request May 10, 2021
…connections

cdbc2bd qt: Use template function qOverload in signal-slot connections (Hennadii Stepanov)

Pull request description:

  A nice template function [`qOverload`](https://doc.qt.io/qt-5/qtglobal.html#qOverload) is available for us now (bitcoin/bitcoin#20413, bitcoin/bitcoin#21286).

  Its usage makes code much more readable.

  This PR does not change behavior.

ACKs for top commit:
  Talkless:
    utACK cdbc2bd.
  promag:
    Code review ACK cdbc2bd.

Tree-SHA512: 72002aa646b1a79bab62d498825b3f245dc7ebdc189280f8bd3b4076e1bb50be8802c02bc872ff6f70c1ea81faec66d3bec36471119dd98c9e70d87b990396ae
fanquake added a commit to bitcoin-core/gui that referenced this pull request Mar 7, 2022
956f732 build: Bump minimum Qt version to 5.11.3 (Hennadii Stepanov)
e22d10b ci: Switch from bionic to buster (Hennadii Stepanov)

Pull request description:

  The current minimum Qt version is 5.9.5 which has been set in bitcoin/bitcoin#21286.

  Distro support:
  - centos 7 -- unsupported since bitcoin/bitcoin#23511
  - centos 8 -- [5.15.2](http://mirror.centos.org/centos/8/AppStream/x86_64/os/Packages/qt5-qtbase-5.15.2-3.el8.x86_64.rpm)
  - buster -- [5.11.3](https://packages.debian.org/buster/libqt5core5a)
  - bullseye  -- [5.15.2](https://packages.debian.org/bullseye/libqt5core5a)
  - _bionic_ -- [5.9.5](https://packages.ubuntu.com/bionic/libqt5core5a)
  - focal -- [5.12.8](https://packages.ubuntu.com/focal/libqt5core5a)

  As another Ubuntu LTS is coming soon, it seems unreasonable to stick to Qt 5.9 which support [ended](https://www.qt.io/blog/2017/06/07/renewed-qt-support-services) on 2020-05-31. Anyway, it's still possible to build Bitcoin Core GUI with depends on bionic system.

  Bumping the minimum Qt version allows to make code safer and more reliable, e.g.:
  - functor-parameter overload of [`QMetaObject::invokeMethod`](https://doc.qt.io/qt-5/qmetaobject.html#invokeMethod-4)
  - fixed https://bugreports.qt.io/browse/QTBUG-10907

  An example of the patch using the functor-overload of `QMetaObject::invokeMethod`:
  ```diff
  --- a/src/qt/walletmodel.cpp
  +++ b/src/qt/walletmodel.cpp
  @@ -349,7 +349,7 @@ bool WalletModel::changePassphrase(const SecureString &oldPass, const SecureStri
   static void NotifyUnload(WalletModel* walletModel)
   {
       qDebug() << "NotifyUnload";
  -    bool invoked = QMetaObject::invokeMethod(walletModel, "unload");
  +    bool invoked = QMetaObject::invokeMethod(walletModel, &WalletModel::unload);
       assert(invoked);
   }

  ```
  It uses the same new syntax as signal-slot connection with compile-time check. Also see bitcoin/bitcoin#16348.

  This PR is intended to be merged early [after](bitcoin/bitcoin#22969) branching `23.x` off.

ACKs for top commit:
  MarcoFalke:
    cr ACK 956f732
  fanquake:
    ACK 956f732

Tree-SHA512: 3d652bcdcd990ce785ad412ed70234d4f27743895e535a53ed44b35d4afc3052e066c4c84f417e30bc53d0a3dd9ebed62444c57b7c765cb1e9aa687fbf866877
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] qt: Minimum required Qt5
6 participants