Skip to content

Conversation

dongcarl
Copy link
Contributor

@dongcarl dongcarl commented Feb 5, 2021

This allows depends-built packages to be cached.

This allows depends-built packages to be cached.
@dongcarl dongcarl force-pushed the 2020-12-guix-base-cache branch from b0c610a to 901f543 Compare February 16, 2021 17:18
@dongcarl
Copy link
Contributor Author

Pushed b0c610a -> 901f543


Set the depends tree cache for built packages. This is passed through to the
depends tree. Setting this to the same directory across multiple builds of the
depends tree can eliminate unnecessary building of packages.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this mention that the folder should be unique per major version of Bitcoin Core? See #17248

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess long term the goal is to move the depends cache to the guix gnu store anyway?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maflcko
Copy link
Member

maflcko commented Feb 16, 2021

Approach ACK 901f543

might test some day

@fanquake
Copy link
Member

ACK 901f543

Builds at 901f543:

# guix describe
Generation 3	Feb 17 2021 00:52:36	(current)
  guix 8fc36d8
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 8fc36d82271946bf5e327b0f2feef9f65ce91701

# git rev-parse HEAD
901f54321b386258a1682423160bfdfa35ea4c39

# find output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
86e97b0328838ac6ff3c3aed317943df261b1ff6aa52f8a2f145f8deffe404eb  output/bitcoin-901f54321b38-aarch64-linux-gnu-debug.tar.gz
6bcb4997317595dbef7d43636bc452d66cc6a570a5545a849342a75f3accbabf  output/bitcoin-901f54321b38-aarch64-linux-gnu.tar.gz
275761cce916f9d0be8449f16532c5c72ace7de48396a20ba27e7d72f6ca60b6  output/bitcoin-901f54321b38-arm-linux-gnueabihf-debug.tar.gz
59f1b242cdf474d8f17dfd38c95d7edfc4eb9ef42cb11e7af9cb6fbeeb59b122  output/bitcoin-901f54321b38-arm-linux-gnueabihf.tar.gz
3472e5792b6ee74d000a5335349867b09a5ad94a369743f8cfe547969f8328d9  output/bitcoin-901f54321b38-osx-unsigned.dmg
b84b85b38101d71f2e4f4a7b92a3c70dc83161fa6821b48419448f4a9a76785b  output/bitcoin-901f54321b38-osx-unsigned.tar.gz
9cbb4a0da4bf9384fe172203054d4b8fbdc3249ea0702e054c55245510745db1  output/bitcoin-901f54321b38-osx64.tar.gz
1f16a73254a83da30545ad386f91c8e816ca7af2330ba17f613c6425c938b6ce  output/bitcoin-901f54321b38-riscv64-linux-gnu-debug.tar.gz
b32c65c4c64fd687d80885a9a10797fcb66eb64af89194042936aefa65a84e37  output/bitcoin-901f54321b38-riscv64-linux-gnu.tar.gz
95c23a5ed33b1f1a588ed15e8ee5e99b62da0949cd4f1034f3a6a78fcf899d11  output/bitcoin-901f54321b38-win-unsigned.tar.gz
086e93373b6042942ccd98be074e2f563928d528ea4ff68d9ca38f6ef0c4ea2d  output/bitcoin-901f54321b38-win64-debug.zip
980bfeed88b6d74a8c9e83415c18f09c8766bed81cd59e3879ce6947240c1b21  output/bitcoin-901f54321b38-win64-setup-unsigned.exe
e7a8ff07065990980dc3ad71e401fc26aa8fee3c8609c08dc81cc148b52b0846  output/bitcoin-901f54321b38-win64.zip
19c25c58adb03cdf780007b05c80ce66bb988e631c37e7a548a9d34ec057b8f6  output/bitcoin-901f54321b38-x86_64-linux-gnu-debug.tar.gz
4e7192c25e97adee4c0dd7011944e6ec058d5209fea5ccc73aab68676337a989  output/bitcoin-901f54321b38-x86_64-linux-gnu.tar.gz
dadee4929b3c57476581277e2c6a25fd35833b08e62346bffc17c3c01974d3cb  output/src/bitcoin-901f54321b38.tar.gz

@fanquake fanquake merged commit 36be9b8 into bitcoin:master Feb 17, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 17, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants