Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Feb 2, 2021

This was missed in #20419, and the update before that, so just make this non-versioned so that we don't have to worry about it. This is fine, because it's just for downloading sources.

This was missed in bitcoin#20419, and the update before that, so just
make this un-versioned so that we don't have to worry about it.
This is fine, because it's just for downloading sources.
@RandyMcMillan
Copy link
Contributor

Tested with:
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/
/Users/git/bitcoin-core/depends/work/build/x86_64-apple-darwin18.7.0/

Screen Shot 2021-02-02 at 2 20 55 PM

ACK f22a3ec

@dongcarl
Copy link
Contributor

dongcarl commented Feb 3, 2021

utACK f22a3ec

@fanquake fanquake merged commit 5f18080 into bitcoin:master Feb 4, 2021
@fanquake fanquake deleted the correct_host_download_osx branch February 4, 2021 02:11
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 4, 2021
f22a3ec build: make macOS HOST in download-osx generic (fanquake)

Pull request description:

  This was missed in bitcoin#20419, and the update before that, so just make this non-versioned so that we don't have to worry about it. This is fine, because it's just for downloading sources.

ACKs for top commit:
  RandyMcMillan:
    ACK f22a3ec
  dongcarl:
    utACK f22a3ec

Tree-SHA512: 3a6993a69594a793a5185e4ba48858443a1002a37b96ff881d39ca7719c79432b35d709bd9a9379f8046bdbeb716c5e1598f273a7e7e3f3bf528b6a807abe5ec
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
f22a3ec build: make macOS HOST in download-osx generic (fanquake)

Pull request description:

  This was missed in bitcoin#20419, and the update before that, so just make this non-versioned so that we don't have to worry about it. This is fine, because it's just for downloading sources.

ACKs for top commit:
  RandyMcMillan:
    ACK f22a3ec
  dongcarl:
    utACK f22a3ec

Tree-SHA512: 3a6993a69594a793a5185e4ba48858443a1002a37b96ff881d39ca7719c79432b35d709bd9a9379f8046bdbeb716c5e1598f273a7e7e3f3bf528b6a807abe5ec
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
f22a3ec build: make macOS HOST in download-osx generic (fanquake)

Pull request description:

  This was missed in bitcoin#20419, and the update before that, so just make this non-versioned so that we don't have to worry about it. This is fine, because it's just for downloading sources.

ACKs for top commit:
  RandyMcMillan:
    ACK f22a3ec
  dongcarl:
    utACK f22a3ec

Tree-SHA512: 3a6993a69594a793a5185e4ba48858443a1002a37b96ff881d39ca7719c79432b35d709bd9a9379f8046bdbeb716c5e1598f273a7e7e3f3bf528b6a807abe5ec
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
f22a3ec build: make macOS HOST in download-osx generic (fanquake)

Pull request description:

  This was missed in bitcoin#20419, and the update before that, so just make this non-versioned so that we don't have to worry about it. This is fine, because it's just for downloading sources.

ACKs for top commit:
  RandyMcMillan:
    ACK f22a3ec
  dongcarl:
    utACK f22a3ec

Tree-SHA512: 3a6993a69594a793a5185e4ba48858443a1002a37b96ff881d39ca7719c79432b35d709bd9a9379f8046bdbeb716c5e1598f273a7e7e3f3bf528b6a807abe5ec
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
f22a3ec build: make macOS HOST in download-osx generic (fanquake)

Pull request description:

  This was missed in bitcoin#20419, and the update before that, so just make this non-versioned so that we don't have to worry about it. This is fine, because it's just for downloading sources.

ACKs for top commit:
  RandyMcMillan:
    ACK f22a3ec
  dongcarl:
    utACK f22a3ec

Tree-SHA512: 3a6993a69594a793a5185e4ba48858443a1002a37b96ff881d39ca7719c79432b35d709bd9a9379f8046bdbeb716c5e1598f273a7e7e3f3bf528b6a807abe5ec
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
f22a3ec build: make macOS HOST in download-osx generic (fanquake)

Pull request description:

  This was missed in bitcoin#20419, and the update before that, so just make this non-versioned so that we don't have to worry about it. This is fine, because it's just for downloading sources.

ACKs for top commit:
  RandyMcMillan:
    ACK f22a3ec
  dongcarl:
    utACK f22a3ec

Tree-SHA512: 3a6993a69594a793a5185e4ba48858443a1002a37b96ff881d39ca7719c79432b35d709bd9a9379f8046bdbeb716c5e1598f273a7e7e3f3bf528b6a807abe5ec
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
f22a3ec build: make macOS HOST in download-osx generic (fanquake)

Pull request description:

  This was missed in bitcoin#20419, and the update before that, so just make this non-versioned so that we don't have to worry about it. This is fine, because it's just for downloading sources.

ACKs for top commit:
  RandyMcMillan:
    ACK f22a3ec
  dongcarl:
    utACK f22a3ec

Tree-SHA512: 3a6993a69594a793a5185e4ba48858443a1002a37b96ff881d39ca7719c79432b35d709bd9a9379f8046bdbeb716c5e1598f273a7e7e3f3bf528b6a807abe5ec
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 16, 2021
f22a3ec build: make macOS HOST in download-osx generic (fanquake)

Pull request description:

  This was missed in bitcoin#20419, and the update before that, so just make this non-versioned so that we don't have to worry about it. This is fine, because it's just for downloading sources.

ACKs for top commit:
  RandyMcMillan:
    ACK f22a3ec
  dongcarl:
    utACK f22a3ec

Tree-SHA512: 3a6993a69594a793a5185e4ba48858443a1002a37b96ff881d39ca7719c79432b35d709bd9a9379f8046bdbeb716c5e1598f273a7e7e3f3bf528b6a807abe5ec
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants