doc: add xorriso to macOS depends packages #20985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in bitcoin#20470.
hebasto
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
ACK 5b41d84, tested on Linux Mint 20.1 (x86_64).
Without installed xorriso package:
$ make deploy
...
/usr/bin/mkdir -p dist/.background
/usr/bin/tiffcp -c none dpi36.background.tiff dpi72.background.tiff dist/.background/background.tiff
xorrisofs -D -l -V "Bitcoin-Core" -no-pad -r -dir-mode 0755 -o Bitcoin-Core.temp.iso dist --
/bin/bash: xorrisofs: command not found
make: *** [Makefile:1303: Bitcoin-Core.temp.iso] Error 127
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 22, 2021
5b41d84 doc: add xorriso to macOS depends packages (fanquake) Pull request description: This was missed in bitcoin#20470. ACKs for top commit: hebasto: ACK 5b41d84, tested on Linux Mint 20.1 (x86_64). Tree-SHA512: bcfd8468a099c69175f8a9d295c1466764ab25d6a61121b28675a09c3e96f45b6309e1523d341f4cb21d0ddee4945f00ba060ba02da835f2f0db7e694fd6c44b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in #20470.