Skip to content

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Jan 17, 2021

Detect version conflicts between the run-time BerkeleyDB library and the one used during compilation.

This is very unsafe (can result in anything from crashes to corruption) so shut down when one is detected.

@laanwj laanwj added the Wallet label Jan 17, 2021
@laanwj laanwj force-pushed the 2021-01-berkeleydb-sanity-check branch from d93befd to 620326b Compare January 17, 2021 16:27
Detect version conflicts between the run-time BerkeleyDB library and the one used during compilation.

This is very unsafe (can result in anything from crashes to corruption) so shut down when one is detected.
@laanwj laanwj force-pushed the 2021-01-berkeleydb-sanity-check branch from 620326b to ad57fb7 Compare January 17, 2021 17:11
Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ad57fb7

@laanwj laanwj requested review from adamjonas and ajtowns January 18, 2021 10:29
@laanwj
Copy link
Member Author

laanwj commented Jan 18, 2021

@adamjonas whoops wrong aj 🙂

Copy link
Contributor

@meshcollider meshcollider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK ad57fb7

@decryp2kanon
Copy link
Contributor

decryp2kanon commented Jan 19, 2021

utACK ad57fb7

good idea.

@achow101
Copy link
Member

ACK ad57fb7

@meshcollider meshcollider merged commit 80486e7 into bitcoin:master Jan 20, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 20, 2021
…nit time

ad57fb7 wallet: Add BerkeleyDB version sanity check at init time (Wladimir J. van der Laan)

Pull request description:

  Detect version conflicts between the run-time BerkeleyDB library and the one used during compilation.

  This is very unsafe (can result in anything from crashes to corruption) so shut down when one is detected.

ACKs for top commit:
  decryp2kanon:
    utACK ad57fb7
  achow101:
    ACK ad57fb7
  theStack:
    utACK ad57fb7
  meshcollider:
    Code review ACK ad57fb7

Tree-SHA512: 99cd7d836bffbdeb3d4e14053f7139cc85a6d42e631a3f9a3058a848042446b364faee127500f5acb374616e6a61ab2bedebfac1ba9bc993b4d6227114c2a6c2
luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Jan 29, 2021
Detect version conflicts between the run-time BerkeleyDB library and the one used during compilation.

This is very unsafe (can result in anything from crashes to corruption) so shut down when one is detected.

Github-Pull: bitcoin#20952
Rebased-From: ad57fb7
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants