net: Move SocketSendData lock annotation to header #20864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. If you're moving things around in net.h to add lock annotations, might be worth moving Moving It would be nice if there were some easy way to review pointer-becomes-reference changes. |
Apart from
Thanks, done |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jan 6, 2021
Closed
This was referenced Jan 6, 2021
|
ACK fad2e1f |
|
Rebased, should be trivial to re-ACK with git range-diff or from scratch |
added 2 commits
January 7, 2021 09:40
Can be reviewed with --color-moved=dimmed-zebra --patience
Also, add lock annotation to SendMessages Can be reviewed with "--word-diff-regex=."
|
utACK fa21068 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 7, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 25, 2022
Summary: ``` Can be reviewed with --color-moved=dimmed-zebra --patience ``` This is a move only change, no change in behavior. Partial backport of [[bitcoin/bitcoin#20864 | core#20864]]: bitcoin/bitcoin@fa0a717 Depends on D10879. Ref T1696. Test Plan: ninja all check-all Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Maniphest Tasks: T1696 Differential Revision: https://reviews.bitcoinabc.org/D10880
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 25, 2022
Summary: ``` Also, add lock annotation to SendMessages Can be reviewed with "--word-diff-regex=." ``` Completes backport of [[bitcoin/bitcoin#20864 | core#20864]]: bitcoin/bitcoin@fa21068 Depends on D10880. Ref T1696. Test Plan: ninja all check-all Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Maniphest Tasks: T1696 Differential Revision: https://reviews.bitcoinabc.org/D10881
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock annotations must be in the header, otherwise the will have limited or no effect