cli -netinfo peer connections dashboard updates 🎄 ✨ #20764

jonatack · 2020-12-24T19:35:30Z

Merry Bitcoin Christmas! Ho ho ho 🎄 ✨

This PR updates -netinfo to:

use the getpeerinfo connection_type field (and no longer use getpeerinfo relaytxes for block-relay detection)
display manual peers count, if any, in the outbound row
display the block relay counts in the outbound row only
display high-bandwidth BIP152 compact block relay peers (hb column, to . and from *)
add support for displaying I2P network peers, if any are present

Testing and review welcome! How to test:

to run the full live dashboard (on Linux): $ watch --interval 1 --no-title ./src/bitcoin-cli -netinfo 4
to run the full dashboard: $ ./src/bitcoin-cli -netinfo 4
to see the help: $ ./src/bitcoin-cli -netinfo help
to see the help summary: $ ./src/bitcoin-cli -help | grep -A4 netinfo

DrahtBot · 2020-12-25T00:10:11Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

netinfo: user help and argument parsing improvements #20877 (netinfo: user help and argument parsing improvements by jonatack)
Add I2P support using I2P SAM #20685 (Add I2P support using I2P SAM by vasild)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

sipa · 2020-12-27T05:21:54Z

Concept ACK

michaelfolkson · 2020-12-27T15:11:45Z

Concept ACK. Is this ready to move out of draft? Would perhaps get more review if out of draft?

practicalswift · 2020-12-27T19:58:20Z

Concept ACK

-netinfo is great! :)

jonatack · 2020-12-27T23:07:45Z

Moved out of draft and ready for review with updated PR description and "how to test" suggestions. The last commit that adds displaying BIP152 high-bandwidth peers can't be backported to rc4, but the other commits, including the user help, could be if desired.

New help doc

$ ./src/bitcoin-cli -netinfo help
-netinfo level "help" 

Returns a network peer connections dashboard with information from the remote server.
Under the hood, -netinfo fetches the data by calling getpeerinfo and getnetworkinfo.
An optional integer argument from 0 to 4 can be passed for different peers listings.
Pass "help" to see this detailed help documentation.
If more than one argument is passed, only the first one is read and parsed.
Suggestion: use with the Linux watch command for a live dashboard; see example below.

Arguments:
1. level (integer 0-4, optional)  Specify the info level of the peers dashboard (default 0):
                                  0 - Connection counts and local addresses
                                  1 - Like 0 but with a detailed peers listing (without address or version columns)
                                  2 - Like 1 but with an address column
                                  3 - Like 1 but with a version column
                                  4 - Like 1 but with both address and version columns
2. help (string "help", optional) Print this help documentation instead of the dashboard.

The detailed peers listing in levels 1-4 displays all of the peers, sorted by direction and minimum ping time.

Column   Description
------   -----------
<->      Direction
         "in"  - inbound connections are those initiated by the peer
         "out" - outbound connections are those initiated by us
type     Type of peer connection
         "full"   - full relay, the default
         "block"  - block relay; like full relay but does not relay transactions or addresses
         "manual" - peer we manually added using RPC addnode or the -addnode/-connect config options
         "feeler" - short-lived connection for testing addresses
         "addr"   - address fetch; short-lived connection for requesting addresses
net      Network the peer connected through ("ipv4", "ipv6", "onion", "i2p", or "cjdns")
mping    Minimum observed ping time in milliseconds (ms)
ping     Ping time in milliseconds (ms)
send     Time since last message sent to the peer, in seconds
recv     Time since last message received from the peer, in seconds
txn      Time since last novel transaction received from the peer and accepted into our mempool, in minutes
blk      Time since last novel block passing initial validity checks received from the peer, in minutes
hb       High-bandwidth BIP152 compact block relay
         "." (to)   - we selected the peer as a high-bandwidth peer
         "*" (from) - the peer selected us as a high-bandwidth peer
age      Duration of connection to the peer, in minutes
asmap    Mapped AS (Autonomous System) number in the BGP route to the peer, used for diversifying peer selection
         (only displayed if the -asmap config option is set)
id       Peer index, in increasing order of peer connections since node startup
address  IP address and port of the peer
version  Peer version and subversion concatenated, e.g. "70016/Satoshi:21.0.0/"

Examples:

Connection counts and local addresses only
> bitcoin-cli -netinfo

Compact peers listing
> bitcoin-cli -netinfo 1

Full dashboard
> bitcoin-cli -netinfo 4

Full live dashboard, adjust --interval or --no-title as needed (Linux)
> watch --interval 1 --no-title ./src/bitcoin-cli -netinfo 4

See this help
> bitcoin-cli -netinfo help

jonasschnelli · 2020-12-28T20:06:02Z

Neat!
Concept ACK

glozow

Concept ACK, I tried it out - very nice :)

An idea - you could omit the txn column during IBD since the node isn't validating (and shouldn't be receiving) txns at all.

The second table should be mentioned in help imo, and in general just seems really weird to me. We have a column after the "overall totals" and it has a slot for inbound block-relay-only, which doesn't exist afaik? Seems like it would make more sense for block/manual to be rows instead or have a separate table or something.

src/bitcoin-cli.cpp

jonatack · 2020-12-29T21:28:59Z

Thanks for your ideas @glozow!

The second table should be mentioned in help imo, and in general just seems really weird to me. We have a column after the "overall totals" and it has a slot for inbound block-relay-only, which doesn't exist afaik? Seems like it would make more sense for block/manual to be rows instead or have a separate table or something.

This is valuable, as I don't have a fresh perspective. I'd like to keep the connection counts in as compact a format as we can, but any ideas welcome. How about this?

Edit: updated the screenshot in the PR description to this

jonatack · 2020-12-29T23:10:18Z

Updated:

Rewrote the help, adding suggestions by @glozow and improved formatting
Display the block relay and manual counts in the outbound row only

jonatack · 2020-12-29T23:13:04Z

Updated help doc

$ ./src/bitcoin-cli -netinfo help
-netinfo level|"help" 

Returns a network peer connections dashboard with information from the remote server.
Under the hood, -netinfo fetches the data by calling getpeerinfo and getnetworkinfo.
An optional integer argument from 0 to 4 can be passed for different peers listings.
Pass "help" to see this detailed help documentation.
If more than one argument is passed, only the first one is read and parsed.
Suggestion: use with the Linux watch(1) command for a live dashboard; see example below.

Arguments:
1. level (integer 0-4, optional)  Specify the info level of the peers dashboard (default 0):
                                  0 - Connection counts and local addresses
                                  1 - Like 0 but with a peers listing (without address or version columns)
                                  2 - Like 1 but with an address column
                                  3 - Like 1 but with a version column
                                  4 - Like 1 but with both address and version columns
2. help (string "help", optional) Print this help documentation instead of the dashboard.

Result:

* The peers listing in levels 1-4 displays all of the peers sorted by direction and minimum ping time:

  Column   Description
  ------   -----------
  <->      Direction
           "in"  - inbound connections are those initiated by the peer
           "out" - outbound connections are those initiated by us
  type     Type of peer connection
           "full"   - full relay, the default
           "block"  - block relay; like full relay but does not relay transactions or addresses
           "manual" - peer we manually added using RPC addnode or the -addnode/-connect config options
           "feeler" - short-lived connection for testing addresses
           "addr"   - address fetch; short-lived connection for requesting addresses
  net      Network the peer connected through ("ipv4", "ipv6", "onion", "i2p", or "cjdns")
  mping    Minimum observed ping time, in milliseconds (ms)
  ping     Last observed ping time, in milliseconds (ms)
  send     Time since last message sent to the peer, in seconds
  recv     Time since last message received from the peer, in seconds
  txn      Time since last novel transaction received from the peer and accepted into our mempool, in minutes
  blk      Time since last novel block passing initial validity checks received from the peer, in minutes
  hb       High-bandwidth BIP152 compact block relay
           "." (to)   - we selected the peer as a high-bandwidth peer
           "*" (from) - the peer selected us as a high-bandwidth peer
  age      Duration of connection to the peer, in minutes
  asmap    Mapped AS (Autonomous System) number in the BGP route to the peer, used for diversifying
           peer selection (only displayed if the -asmap config option is set)
  id       Peer index, in increasing order of peer connections since node startup
  address  IP address and port of the peer
  version  Peer version and subversion concatenated, e.g. "70016/Satoshi:21.0.0/"

* The connection counts table displays the number of peers by direction, network, and the totals
  for each, as well as two special outbound columns for block relay peers and manual peers.

* The local addresses table lists each local address broadcast by the node, the port, and the score.

Examples:

Connection counts and local addresses only
> bitcoin-cli -netinfo

Compact peers listing
> bitcoin-cli -netinfo 1

Full dashboard
> bitcoin-cli -netinfo 4

Full live dashboard, adjust --interval or --no-title as needed (Linux)
> watch --interval 1 --no-title bitcoin-cli -netinfo 4

See this help
> bitcoin-cli -netinfo help

theStack · 2021-01-04T13:28:16Z

Very nice that Santa Claus also came to present a gift to Bitcoin Core ;) 🎅
Concept ACK, plan to review this within the next days.

jonatack · 2021-01-05T22:58:10Z

Rebased on top of #20829 (the first commit, "netinfo: add user help documentation").

6f2c4fd netinfo: add user help documentation (Jon Atack) Pull request description: This is the help doc commit of #20764 without the rest of the PR or anything new since the 0.21.0 branch-off in order to target giving users a -netinfo help doc for 0.21. - to test the new help ``` $ ./src/bitcoin-cli -netinfo help ``` - to see the updated short help ``` $ ./src/bitcoin-cli -help | grep -A4 netinfo ``` <details><summary><code>-netinfo</code> help doc</summary><p> ``` $ ./src/bitcoin-cli -netinfo help -netinfo level "help" Returns a network peer connections dashboard with information from the remote server. Under the hood, -netinfo fetches the data by calling getpeerinfo and getnetworkinfo. An optional integer argument from 0 to 4 can be passed for different peers listings. Pass "help" to see this detailed help documentation. If more than one argument is passed, only the first one is read and parsed. Suggestion: use with the Linux watch(1) command for a live dashboard; see example below. Arguments: 1. level (integer 0-4, optional) Specify the info level of the peers dashboard (default 0): 0 - Connection counts and local addresses 1 - Like 0 but with a peers listing (without address or version columns) 2 - Like 1 but with an address column 3 - Like 1 but with a version column 4 - Like 1 but with both address and version columns 2. help (string "help", optional) Print this help documentation instead of the dashboard. Result: * The peers listing in levels 1-4 displays all of the peers sorted by direction and minimum ping time: Column Description ------ ----------- <-> Direction "in" - inbound connections are those initiated by the peer "out" - outbound connections are those initiated by us type Type of peer connection "full" - full relay, the default "block" - block relay; like full relay but does not relay transactions or addresses net Network the peer connected through ("ipv4", "ipv6", "onion", "i2p", or "cjdns") mping Minimum observed ping time, in milliseconds (ms) ping Last observed ping time, in milliseconds (ms) send Time since last message sent to the peer, in seconds recv Time since last message received from the peer, in seconds txn Time since last novel transaction received from the peer and accepted into our mempool, in minutes blk Time since last novel block passing initial validity checks received from the peer, in minutes age Duration of connection to the peer, in minutes asmap Mapped AS (Autonomous System) number in the BGP route to the peer, used for diversifying peer selection (only displayed if the -asmap config option is set) id Peer index, in increasing order of peer connections since node startup address IP address and port of the peer version Peer version and subversion concatenated, e.g. "70016/Satoshi:21.0.0/" * The connection counts table displays the number of peers by direction, network, and the totals for each, as well as a column for block relay peers. * The local addresses table lists each local address broadcast by the node, the port, and the score. Examples: Connection counts and local addresses only > bitcoin-cli -netinfo Compact peers listing > bitcoin-cli -netinfo 1 Full dashboard > bitcoin-cli -netinfo 4 Full live dashboard, adjust --interval or --no-title as needed (Linux) > watch --interval 1 --no-title ./src/bitcoin-cli -netinfo 4 See this help > bitcoin-cli -netinfo help ``` </p></details> ACKs for top commit: laanwj: ACK 6f2c4fd Tree-SHA512: dd49b1ce65546dacfb8ba9f9d57de0eae55560fd05533cf26c0b5d6ec65bf1de789c3287e90a0e2f47707532fab2fe62919a4192a7ffd58ac8eec18293e9aaeb

6f2c4fd netinfo: add user help documentation (Jon Atack) Pull request description: This is the help doc commit of bitcoin#20764 without the rest of the PR or anything new since the 0.21.0 branch-off in order to target giving users a -netinfo help doc for 0.21. - to test the new help ``` $ ./src/bitcoin-cli -netinfo help ``` - to see the updated short help ``` $ ./src/bitcoin-cli -help | grep -A4 netinfo ``` <details><summary><code>-netinfo</code> help doc</summary><p> ``` $ ./src/bitcoin-cli -netinfo help -netinfo level "help" Returns a network peer connections dashboard with information from the remote server. Under the hood, -netinfo fetches the data by calling getpeerinfo and getnetworkinfo. An optional integer argument from 0 to 4 can be passed for different peers listings. Pass "help" to see this detailed help documentation. If more than one argument is passed, only the first one is read and parsed. Suggestion: use with the Linux watch(1) command for a live dashboard; see example below. Arguments: 1. level (integer 0-4, optional) Specify the info level of the peers dashboard (default 0): 0 - Connection counts and local addresses 1 - Like 0 but with a peers listing (without address or version columns) 2 - Like 1 but with an address column 3 - Like 1 but with a version column 4 - Like 1 but with both address and version columns 2. help (string "help", optional) Print this help documentation instead of the dashboard. Result: * The peers listing in levels 1-4 displays all of the peers sorted by direction and minimum ping time: Column Description ------ ----------- <-> Direction "in" - inbound connections are those initiated by the peer "out" - outbound connections are those initiated by us type Type of peer connection "full" - full relay, the default "block" - block relay; like full relay but does not relay transactions or addresses net Network the peer connected through ("ipv4", "ipv6", "onion", "i2p", or "cjdns") mping Minimum observed ping time, in milliseconds (ms) ping Last observed ping time, in milliseconds (ms) send Time since last message sent to the peer, in seconds recv Time since last message received from the peer, in seconds txn Time since last novel transaction received from the peer and accepted into our mempool, in minutes blk Time since last novel block passing initial validity checks received from the peer, in minutes age Duration of connection to the peer, in minutes asmap Mapped AS (Autonomous System) number in the BGP route to the peer, used for diversifying peer selection (only displayed if the -asmap config option is set) id Peer index, in increasing order of peer connections since node startup address IP address and port of the peer version Peer version and subversion concatenated, e.g. "70016/Satoshi:21.0.0/" * The connection counts table displays the number of peers by direction, network, and the totals for each, as well as a column for block relay peers. * The local addresses table lists each local address broadcast by the node, the port, and the score. Examples: Connection counts and local addresses only > bitcoin-cli -netinfo Compact peers listing > bitcoin-cli -netinfo 1 Full dashboard > bitcoin-cli -netinfo 4 Full live dashboard, adjust --interval or --no-title as needed (Linux) > watch --interval 1 --no-title ./src/bitcoin-cli -netinfo 4 See this help > bitcoin-cli -netinfo help ``` </p></details> ACKs for top commit: laanwj: ACK 6f2c4fd Tree-SHA512: dd49b1ce65546dacfb8ba9f9d57de0eae55560fd05533cf26c0b5d6ec65bf1de789c3287e90a0e2f47707532fab2fe62919a4192a7ffd58ac8eec18293e9aaeb

felipsoarez

Concept ACK, not tested

Good job, more information for better adaptations -netinfo is great

jonatack · 2021-01-06T16:46:39Z

Rebased after the merge of #20829. The diff is now much smaller and this should be ready for final review.

jonatack · 2021-01-10T19:31:04Z

Dropped commit 97127a8 "netinfo: only display outbound block relay peers count."

jonatack · 2021-01-18T19:40:44Z

Added a commit to support displaying connections to peers via the I2P network. An i2p peer counts column is displayed if the user is connected to any I2P peers. Otherwise there is no user-facing change, and this change is compatible with current master.

jonatack · 2021-02-02T15:47:12Z

Updated connection type handling to display inbounds without a "full" or "block" type description from fRelayTxes.

Will give this a few days and if still no ACKs will close in favor of proposing the changes individually in separate pulls.

michaelfolkson · 2021-02-02T17:31:18Z

You haven't started splitting this into separate pulls have you @jonatack? If no I will review this tomorrow. Otherwise I will wait for the separate pulls.

jonatack · 2021-02-02T17:42:04Z

Thanks 🙏 leaving as-is for now, one merge is easier than several 🐇 🐢

laanwj · 2021-02-03T08:16:39Z

Code review and shallowly tested ACK ~~9628f99~~
re-ACK 747cb5b

I am a bit divided on adding I2P support here before #20685 is merged, but also don't see it as a problem that the client can already handle this.

src/bitcoin-cli.cpp

the i2p peer counts column is displayed iff the node is connected to at least one i2p peer, so this doesn't add clutter for users who are not running an i2p service

jonatack · 2021-02-03T13:42:27Z

Updated the last commit to only display block relay peer counts in the outbound row, and simplified it and commit netinfo: display manual peers count by persisting the counts in a member variable instead of in the m_counts 2D array.

@laanwj Thanks for reviewing! I apologize for pushing again after. I think this is finally done.

michaelfolkson · 2021-02-04T17:39:03Z

ACK 747cb5b

I really like it (obviously) and I've only done limited testing (no Tor or I2P connections)

display high-bandwidth BIP152 compact block relay peers (hb column, to . and from *)

Maybe it is just me but I feel as if I'm going to have to look at the help every time to remember what . and * represents. Presumably there were no better options than . and *? Obviously in and out are already taken and to and from took up too much space?

My understanding is a little hazy of BIP 152 selection process too so maybe I personally just wouldn't care about this. I can look it up though!

jonatack · 2021-02-04T21:40:04Z

Thanks @michaelfolkson for reviewing! The idea is . for an outgoing signal ("to"; we selected the peer) and * for an inbound signal ("from"; the peer selected us). Kind of like a train with a bright headlight and a muted tail light. Though if you see them as starships instead I suppose an argument could be made for the inverse 😄

jonasschnelli · 2021-02-05T08:42:19Z

~~Should this also be compatible with -testnet (and eventually -regtest)?~~

never-mind: it is.

jonasschnelli

Tested ACK 747cb5b - works nicely. Great that this PR only changes bitcoin-cli.

747cb5b netinfo: display only outbound block relay counts (Jon Atack) 76d198a netinfo: add i2p network (Jon Atack) 9d6aeca netinfo: add bip152 high-bandwidth to/from fields (Jon Atack) 5de7a6c netinfo: display manual peers count (Jon Atack) d3cca3b netinfo: update to use peer connection types (Jon Atack) 62bf5b7 netinfo: add ConnectionTypeForNetinfo member helper function (Jon Atack) Pull request description: Merry Bitcoin Christmas! Ho ho ho 🎄 ✨ This PR updates `-netinfo` to: - use the getpeerinfo `connection_type` field (and no longer use getpeerinfo `relaytxes` for block-relay detection) - display manual peers count, if any, in the outbound row - display the block relay counts in the outbound row only - display high-bandwidth BIP152 compact block relay peers (`hb` column, to `.` and from `*`) - add support for displaying I2P network peers, if any are present Testing and review welcome! How to test: - to run the full live dashboard (on Linux): `$ watch --interval 1 --no-title ./src/bitcoin-cli -netinfo 4` - to run the full dashboard: ``$ ./src/bitcoin-cli -netinfo 4`` - to see the help: `$ ./src/bitcoin-cli -netinfo help` - to see the help summary: `$ ./src/bitcoin-cli -help | grep -A4 netinfo` ACKs for top commit: laanwj: re-ACK 747cb5b michaelfolkson: ACK 747cb5b jonasschnelli: Tested ACK 747cb5b - works nicely. Great that this PR only changes bitcoin-cli. Tree-SHA512: 48fe23dddf3005a039190fcbc84167cd25b0a63489617fe14ea5db9a641a829b46b6e8dc7924aab6577d82a13909d157e82f715bd2ed3a8a15071957c35c19f3

7d3343f cli: update -netinfo help doc following the merge of 882ce25 (Jon Atack) ef614bb cli: small -netinfo simplification and performance improvement (Jon Atack) 6b45ef3 cli: improve -netinfo invalid argument error message (Jon Atack) 3732404 cli: warn in help that -netinfo is not intended to be a stable API (Jon Atack) 7afdd72 cli: enable -netinfo help to run without a remote server (Jon Atack) Pull request description: A few updates, some per IRC discussion today at http://www.erisian.com.au/bitcoin-core-dev/log-2021-01-07.html#l-87 with respect to -netinfo: - enable `-netinfo help` to run without a remote server - warn in `-netinfo help` that -netinfo is not intended to be a stable API - improve the -netinfo invalid argument error message - make a performance improvement and simplification I noticed after the merge of #20764 - update the -netinfo help doc following the merge of #21192 ----- How to test manually: 🔬 🧪 📈 1. check out and build this branch locally; if you need help, don't hesitate to refer to https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core#pull-down-the-code-locally or https://jonatack.github.io/articles/how-to-compile-bitcoin-core-and-run-the-tests 2. while it is compiling, look at the code changes 3. stop signet (if it is running) with `./src/bitcoin-cli -signet stop` 4. once the build is completed, run `./src/bitcoin-cli -signet -netinfo help` 5. the help should be printed even though the signet server is not running 6. near the top you should see the new warning, "This human-readable interface will change regularly and is not intended to be a stable API" as well as a bit more description about the integer argument values. 7. start signet with `./src/bitcoind -signet` 8. test the improved invalid argument error message if you run `./src/bitcoin-cli -signet -netinfo 256` or `./src/bitcoin-cli -signet -netinfo a` (valid values are from 0 to 255) 9. leave review feedback or `ACK <commit hash>` -- done 🍻 ACKs for top commit: michaelfolkson: Re-ACK 7d3343f pinheadmz: RE-ACK 7d3343f Tree-SHA512: 28c5e9f295ffccba5c2a70faac4987d45f35d4758cf8f10daa767e83212316c4cfc65930e4066f7ad627e9d15b92d43439d1ba9c2f755dfde61885c6a70aa155

DrahtBot mentioned this pull request Dec 25, 2020

Add I2P support using I2P SAM #20685

Merged

jonatack mentioned this pull request Dec 25, 2020

Peer details: replace Direction with Connection Type bitcoin-core/gui#163

Merged

jonatack force-pushed the netinfo-updates-dec-2020 branch from 30a5dfb to 962ec9f Compare December 26, 2020 12:04

jonatack marked this pull request as ready for review December 27, 2020 22:56

jonatack force-pushed the netinfo-updates-dec-2020 branch from 962ec9f to f095dd3 Compare December 27, 2020 22:57

jonatack mentioned this pull request Dec 28, 2020

Net: Move ping data to net_processing #20721

Merged

glozow reviewed Dec 29, 2020

View reviewed changes

src/bitcoin-cli.cpp Outdated Show resolved Hide resolved

src/bitcoin-cli.cpp Outdated Show resolved Hide resolved

src/bitcoin-cli.cpp Show resolved Hide resolved

jonatack force-pushed the netinfo-updates-dec-2020 branch from f095dd3 to 8fd58ed Compare December 29, 2020 23:08

This was referenced Jan 2, 2021

doc: add -netinfo help #20829

Merged

p2p: standardize outbound full/block relay connection type naming #20729

Closed

jonatack force-pushed the netinfo-updates-dec-2020 branch from 8fd58ed to aab4d1a Compare January 5, 2021 22:56

jonatack force-pushed the netinfo-updates-dec-2020 branch from aab4d1a to 6d660c9 Compare January 5, 2021 22:58

DrahtBot added the Needs rebase label Jan 6, 2021

felipsoarez reviewed Jan 6, 2021

View reviewed changes

jonatack force-pushed the netinfo-updates-dec-2020 branch from 6d660c9 to 0f37bed Compare January 6, 2021 16:43

DrahtBot removed the Needs rebase label Jan 6, 2021

This was referenced Jan 7, 2021

netinfo: user help and argument parsing improvements #20877

Merged

Add Type column to peers window, update peer details name/tooltip bitcoin-core/gui#179

Merged

jonatack force-pushed the netinfo-updates-dec-2020 branch from 0f37bed to 69fa034 Compare January 10, 2021 19:18

netinfo: add ConnectionTypeForNetinfo member helper function

62bf5b7

jonatack force-pushed the netinfo-updates-dec-2020 branch from 5fc8be4 to 9628f99 Compare February 2, 2021 15:42

maflcko reviewed Feb 3, 2021

View reviewed changes

src/bitcoin-cli.cpp Show resolved Hide resolved

jonatack force-pushed the netinfo-updates-dec-2020 branch from 9628f99 to a2dd891 Compare February 3, 2021 08:50

jonatack added 5 commits February 3, 2021 14:17

netinfo: update to use peer connection types

d3cca3b

netinfo: display manual peers count

5de7a6c

netinfo: add bip152 high-bandwidth to/from fields

9d6aeca

netinfo: add i2p network

76d198a

the i2p peer counts column is displayed iff the node is connected to at least one i2p peer, so this doesn't add clutter for users who are not running an i2p service

netinfo: display only outbound block relay counts

747cb5b

jonatack force-pushed the netinfo-updates-dec-2020 branch from a2dd891 to 747cb5b Compare February 3, 2021 13:28

jonasschnelli approved these changes Feb 5, 2021

View reviewed changes

laanwj merged commit b829894 into bitcoin:master Feb 5, 2021

jonatack deleted the netinfo-updates-dec-2020 branch February 5, 2021 14:04

jonatack mentioned this pull request Feb 5, 2021

gui: ensure inbound block relay peers have relevant services bitcoin-core/gui#201

Closed

bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022

cli -netinfo peer connections dashboard updates 🎄 ✨ #20764

cli -netinfo peer connections dashboard updates 🎄 ✨ #20764

Uh oh!

Conversation

jonatack commented Dec 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Dec 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

sipa commented Dec 27, 2020

Uh oh!

michaelfolkson commented Dec 27, 2020

Uh oh!

practicalswift commented Dec 27, 2020

Uh oh!

jonatack commented Dec 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonasschnelli commented Dec 28, 2020

Uh oh!

glozow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonatack commented Dec 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonatack commented Dec 29, 2020

Uh oh!

jonatack commented Dec 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theStack commented Jan 4, 2021

Uh oh!

jonatack commented Jan 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

felipsoarez left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack commented Jan 6, 2021

Uh oh!

jonatack commented Jan 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonatack commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonatack commented Feb 2, 2021

Uh oh!

michaelfolkson commented Feb 2, 2021

Uh oh!

jonatack commented Feb 2, 2021

Uh oh!

laanwj commented Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jonatack commented Feb 3, 2021

Uh oh!

michaelfolkson commented Feb 4, 2021

Uh oh!

jonatack commented Feb 4, 2021

Uh oh!

jonasschnelli commented Feb 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonasschnelli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonatack commented Dec 24, 2020 •

edited

Loading

DrahtBot commented Dec 25, 2020 •

edited

Loading

jonatack commented Dec 27, 2020 •

edited

Loading

jonatack commented Dec 29, 2020 •

edited

Loading

jonatack commented Dec 29, 2020 •

edited

Loading

jonatack commented Jan 5, 2021 •

edited

Loading

jonatack commented Jan 10, 2021 •

edited

Loading

jonatack commented Jan 18, 2021 •

edited

Loading

laanwj commented Feb 3, 2021 •

edited

Loading

jonasschnelli commented Feb 5, 2021 •

edited

Loading