qa: Correct epoll_ctl data race suppression #20745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixup of bitcoin#20218. Comments must start from the beginning of the line.
|
thanks review ACK d71e29e |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 22, 2021
Summary: > It seems the data race in epoll_ctl could be false positive, and be caused by clang tsan instrumentation code (e.g., https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20131007/190642.html). But not for sure, of course. This is a backport of [[bitcoin/bitcoin#20218 | core#20218]] and [[bitcoin/bitcoin#20745 | core#20745]] Note: I wasn't able to reproduce it today in a loop of 10 `ninja check-functional`, but I have seen this race in the past. I have a log file locally with a `ThreadSanitizer` data race involving `epoll_ctl`. Test Plan: With TSAN: ``` for i in `seq 10`; do ninja check-functional; done ``` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10722
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup of #20218. Comments must start from the beginning of the line.
See ThreadSanitizerSuppressions docs: