rpc: Add missing description of vout in getrawtransaction help text #20731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Dec 21, 2020
a7db009 to
b23349b
Compare
|
ACK b23349b 🏯 Show signature and timestampSignature: Timestamp of file with hash |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 21, 2020
Github-Pull: bitcoin#20731 Rebased-From: b23349b
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 21, 2020
Github-Pull: bitcoin#20731 Rebased-From: b23349b
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 21, 2020
…ansaction help text b23349b rpc: Add missing description of vout in getrawtransaction help text (Ben Carman) Pull request description: In `getrawtransaction` the vout did not have a description. I gave it the same description as the one used in `decoderawtransaction`. ACKs for top commit: MarcoFalke: ACK b23349b 🏯 Tree-SHA512: 3833b97c82a46dfeb7ac825d4b2514b4b05ce54ac41f2144a8e2f2093b3411fe1d090c1e5b0c3d09200a2ea164c8d17ece12cdb43bbaeaeccc51a9da6dd7b7a3
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 22, 2020
Github-Pull: bitcoin#20731 Rebased-From: b23349b
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 22, 2020
Github-Pull: bitcoin#20731 Rebased-From: b23349b
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jan 5, 2021
Github-Pull: bitcoin#20731 Rebased-From: b23349b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
getrawtransactionthe vout did not have a description. I gave it the same description as the one used indecoderawtransaction.