fuzz: Hide script_assets_test_minimizer #20663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
requested by @practicalswift in bitcoin-core/qa-assets#30 (comment) |
|
Can be tested by running |
|
Wouldn't it be better to leave it as-is, and just exclude it from being listed, or exclude it test-runner.py? That way you don't need to modify the source code in order to use it. |
faa2f9e to
fa857db
Compare
|
Concept ACK: thanks for addressing this! |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
fa857db to
fa0a7a2
Compare
fa0a7a2 to
fa8ed3f
Compare
added 2 commits
February 8, 2021 10:11
Can be reviewed with --ignore-all-space
fa8ed3f to
fac726b
Compare
|
cr ACK fac726b: patch looks correct and touches only |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 11, 2021
fac726b doc: Fixup docs in fuzz/script_assets_test_minimizer.cpp (MarcoFalke) fafca47 fuzz: Hide script_assets_test_minimizer (MarcoFalke) Pull request description: This is not an actual fuzz target. It is a hack to exploit the built-in capability of fuzz engines to measure coverage. ACKs for top commit: practicalswift: cr ACK fac726b: patch looks correct and touches only `src/test/fuzz/` Tree-SHA512: 0652dd8d9e95746b0906be4044467435d8204a34a30366ae9bdb75b9cb0788d429db7cedf2760fd543565d9d4f7ee206873ed10a29dd715a792a26337f65b53c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an actual fuzz target. It is a hack to exploit the built-in capability of fuzz engines to measure coverage.