Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 14, 2020

The comment was previously attached to m_addr_known, but now it is attached to id, which is wrong.

Fix that by moving the comment to RelayAddrsWithConn.

Can be reviewed with
--ignore-all-space --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
@maflcko maflcko changed the title doc: Move add relay comment in net to correct place doc: Move addr relay comment in net to correct place Dec 14, 2020
@practicalswift
Copy link
Contributor

cr ACK fa86217: patch looks correct

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK fa86217 🌳
The comment was first introduced in 430f489 (#15759)

@jnewbery
Copy link
Contributor

ACK fa86217

@maflcko maflcko merged commit a35a346 into bitcoin:master Dec 15, 2020
@maflcko maflcko deleted the 2012-docNetAddrRelay branch December 15, 2020 16:59
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 15, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants