Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 10, 2020

primitives should only be used for the raw datastructures (parsing and format). It is not the right place to document relay policy.

Also remove extraneous whitespace, should be reviewed with --ignore-all-space
@@ -90,25 +90,32 @@ CAmount GetDustThreshold(const CTxOut& txout, const CFeeRate& dustRelayFee);
bool IsDust(const CTxOut& txout, const CFeeRate& dustRelayFee);

bool IsStandard(const CScript& scriptPubKey, TxoutType& whichType);
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indentation was weird!

@laanwj
Copy link
Member

laanwj commented Dec 10, 2020

Agree that primitives.h is for consensus data structures only.
Code review ACK fade619

@lontivero
Copy link
Contributor

Concept ACK fade619

@luke-jr
Copy link
Member

luke-jr commented Dec 14, 2020

Concept ACK

@laanwj laanwj merged commit dff0f6f into bitcoin:master Dec 15, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 15, 2020
@maflcko maflcko deleted the 2012-mvTxStandardVersion branch December 16, 2020 06:32
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants