Skip to content

contrib: add symbol check test for PE binaries #20608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

contrib: add symbol check test for PE binaries #20608

merged 1 commit into from
Dec 10, 2020

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Dec 9, 2020

Follow up to #20476. Adds a test for the PE symbol check. One failing case where we link against -lpdh and a pass case.

@laanwj
Copy link
Member

laanwj commented Dec 9, 2020

Code review ACK ae9b489
The ARM failure seems unrelated.

@dongcarl
Copy link
Contributor

dongcarl commented Dec 9, 2020

Code Review ACK ae9b489

Currently this doesn't run in Guix containers due to the debian-specific --no-* flags. Will patch our binutils in Guix to enable these flags.

@fanquake
Copy link
Member Author

Currently this doesn't run in Guix containers due to the debian-specific --no-* flags.

Worth noting that these flags are unavailable in Ubuntu 20.04LTS, as the binutils-mingw-w64-x86-64 package is version 8.8, and the commit to restore the --no-* flags (related discussion in #18629) is in 8.9. The flags are present again in 20.10+ (Groovy).

@fanquake fanquake merged commit 0547106 into bitcoin:master Dec 10, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 10, 2020
@fanquake
Merge bitcoin#20608: contrib: add symbol check test for PE binaries
bb1ae29 
ae9b489 contrib: add symbol check test for PE (fanquake)

Pull request description:

  Follow up to bitcoin#20476. Adds a test for the PE symbol check. One failing case where we link against `-lpdh` and a pass case.

ACKs for top commit:
  laanwj:
    Code review ACK ae9b489
  dongcarl:
    Code Review ACK ae9b489

Tree-SHA512: 14109d2c7cb98fb445fe1a7f3078e1e88c49fd29583529c53c75bb625f3060d43df0c64542df72272cff81e1b073f74ce6e437ad0e6617ba2bcccacfd1dc8e53
@fanquake fanquake deleted the symbol_check_test_pe branch February 9, 2021 06:45
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Scripts and tools Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanquake @laanwj @dongcarl