build: use more legible (q)make commands in qt package #20504
Conversation
Rather than using cd to jump all over the place, move up out of qtbase first, and perform all commands from the top level directory.
|
Concept ACK on removing fences of |
|
cr ACK 944b126: patch looks correct |
|
Thanks! |
|
EDITED: nm, |
|
The macOS build has thrown a spanner in the works: x86_64-apple-darwin18-ar cq ../../../lib/libqtlibpng.a .obj/png.o .obj/pngerror.o .obj/pngget.o .obj/pngmem.o .obj/pngpread.o .obj/pngread.o .obj/pngrio.o .obj/pngrtran.o .obj/pngrutil.o .obj/pngset.o .obj/pngtrans.o .obj/pngwio.o .obj/pngwrite.o .obj/pngwtran.o .obj/pngwutil.o
make[2]: x86_64-apple-darwin18-ar: Command not found
Sure. I'll look at that while fixing the macOS issue. |
Mind testing along with #19882? |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
@fanquake |
|
Simple yet meaningful! It makes it easier to read and understand. 100% support this PR |
|
Going to close this in favour of #20673, which includes this change + another. |
87fe104 depends: Use more legible qmake commands in qt package (Hennadii Stepanov) bf35a8d depends: Do not set build_subdir for qt package (Hennadii Stepanov) Pull request description: Rather than using `cd` to jump all over the place, perform all `(q)make` commands from the top level directory. Looking at bash like `cd ../../../..` gives me a headache. Credits to **fanquake**. This PR is an alternative to #20504 that works without any additional [non-trivial hack](bitcoin/bitcoin#20504 (comment)). ACKs for top commit: promag: Tested ACK 87fe104. fanquake: ACK 87fe104 Tree-SHA512: 1d2a13b5358fc7406c5363ddd62fd363dbc0ec5ace68946e4d3e6e8620419afaa64ef2837488aaed226174e01e8897495085540f7126b80f8b2372d21b5b29f9
…ackage 87fe104 depends: Use more legible qmake commands in qt package (Hennadii Stepanov) bf35a8d depends: Do not set build_subdir for qt package (Hennadii Stepanov) Pull request description: Rather than using `cd` to jump all over the place, perform all `(q)make` commands from the top level directory. Looking at bash like `cd ../../../..` gives me a headache. Credits to **fanquake**. This PR is an alternative to bitcoin#20504 that works without any additional [non-trivial hack](bitcoin#20504 (comment)). ACKs for top commit: promag: Tested ACK 87fe104. fanquake: ACK 87fe104 Tree-SHA512: 1d2a13b5358fc7406c5363ddd62fd363dbc0ec5ace68946e4d3e6e8620419afaa64ef2837488aaed226174e01e8897495085540f7126b80f8b2372d21b5b29f9
Rather than using
cdto jump all over the place, move up out ofqtbase first, and perform all
(q)makecommands from thetop level directory. This is worst in the config commands.
Looking at bash like
cd ../../../..gives me a headache.