Skip to content

test: run mempool_spend_coinbase.py even with wallet disabled #20385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2020
Merged

test: run mempool_spend_coinbase.py even with wallet disabled #20385

merged 1 commit into from
Nov 19, 2020

Conversation

mjdietzx
Copy link
Contributor

Run the mempool spend coinbase test even when the wallet was not compiled, as proposed in #20078.

@fanquake fanquake added the Tests label Nov 13, 2020
maflcko
maflcko approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK

promag
promag reviewed Nov 14, 2020
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK.

maflcko
maflcko approved these changes Nov 15, 2020
View reviewed changes
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Could squash and rebase

@mjdietzx mjdietzx force-pushed the mempool-tests-to-miniwallet branch from 650ba88 to 57f65ff Compare November 15, 2020 18:21
@maflcko
Copy link
Member

maflcko commented Nov 16, 2020

Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

@mjdietzx mjdietzx force-pushed the mempool-tests-to-miniwallet branch from 57f65ff to 21f2433 Compare November 16, 2020 15:06
@mjdietzx
Copy link
Contributor Author

I squashed the commits as requested. Going forward with these MiniWallet test "refactors", should I continue to make one PR per test file rewrite, or should I batch multiple test file rewrites in each PR?

@laanwj
Copy link
Member

laanwj commented Nov 19, 2020

ACK 21f2433

@laanwj laanwj merged commit 04670ef into bitcoin:master Nov 19, 2020
@maflcko
Copy link
Member

maflcko commented Nov 19, 2020

should I continue to make one PR per test file rewrite, or should I batch multiple test file rewrites in each PR?

Whatever makes more sense to you

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 19, 2020
@laanwj
Merge bitcoin#20385: test: run mempool_spend_coinbase.py even with wa…
a705f27 
…llet di…
@mjdietzx mjdietzx deleted the mempool-tests-to-miniwallet branch November 19, 2020 19:21
@Sjors Sjors mentioned this pull request Nov 15, 2021
Merged
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 11, 2022
@PiRK
test: run mempool_spend_coinbase.py even with wallet disabled
452c543 
Summary:
mempool_spend_coinbase.py is not a wallet test, so it should run even when the wallet is not compiled.

This is a backport of [[bitcoin/bitcoin#20385 | core#20385]]

Test Plan: `ninja check-functional`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10805
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@promag promag promag left review comments

@maflcko maflcko maflcko approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mjdietzx @maflcko @laanwj @promag @fanquake