test: Fix intermittent issue in wallet_listsinceblock #20322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nit: would be nice to include the failure output, for reference |
|
The blocks won't sync and the utxo can't be spent. The mempool rejects it with "prevout not found" https://cirrus-ci.com/task/5827051938643968?command=functional_test#L823 |
|
Code Review ACK 4444128 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 10, 2020
…block 4444128 test: Fix intermittent issue in wallet_listsinceblock (MarcoFalke) Pull request description: ACKs for top commit: Empact: Code Review ACK bitcoin@4444128 Tree-SHA512: 86d47b1e3c8681dd479654589c894016ac81a3c96a34c3b4a75278b2af85054ea8c6f768e518a5322a4928d82d5e99105bbce0f4fa6a7a18c40e3e0799f9ab54
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 13, 2021
Summary: Generate a privkey in the test framework instead of using dumpprivkey so that descriptor wallets work in this test. This is a backport of [[bitcoin/bitcoin#18788 | core#18788]] [4/16] & [[bitcoin/bitcoin#20322 | core#20322]] (adds a `sync_all`) bitcoin/bitcoin@c2711e4 bitcoin/bitcoin@4444128 I also had to add a `key_to_p2pkh_cashaddr` function to get the address in the correct format. This has the added benefit of adding coverage for `cashaddr.encode[_full]` which was unused before this commit, as far as I can tell. Test Plan: `test/functional/test_runner.py wallet_listsinceblock` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D10656
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.