Skip to content

cirrus: Skip tasks on the gui repo main branch #20328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2020
Merged

cirrus: Skip tasks on the gui repo main branch #20328

merged 1 commit into from
Nov 6, 2020

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Nov 6, 2020

No need to run every build twice, once in the main repo and then in the read-only gui mirror repo

@fanquake fanquake added the Tests label Nov 6, 2020
@hebasto
Copy link
Member

hebasto commented Nov 6, 2020

Concept ACK. Why do we need to create tasks in such cases at all? Maybe s/skip/only_if?

@maflcko
Copy link
Member Author

maflcko commented Nov 6, 2020

I haven't tried only_if, I suspect the only difference is whether the tasks are shown on the website. Probably doesn't matter much as long as they are not run, which is the goal of this pr.

hebasto
hebasto approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 66667ac, though still preferring only_if as showing skipped tasks as successful ones seems a bit confused.

@decryp2kanon
Copy link
Contributor

ACK 66667ac

@maflcko maflcko merged commit 4727c1c into bitcoin:master Nov 6, 2020
@maflcko maflcko deleted the 2011-cirrusSkip branch November 6, 2020 17:10
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 7, 2020
Merge bitcoin#20328: cirrus: Skip tasks on the gui repo main branch
eb5c2f9 
66667ac cirrus: Skip tasks on the gui repo main branch (MarcoFalke)

Pull request description:

  No need to run every build twice, once in the main repo and then in the read-only gui mirror repo

ACKs for top commit:
  decryp2kanon:
    ACK 66667ac
  hebasto:
    ACK 66667ac, though still preferring `only_if` as showing skipped tasks as successful ones seems a bit confused.

Tree-SHA512: 0d35bd115152e06ba4dc5f364130ba5496167d960c44eac2c76192ff9bf7c51f46ab72e2d054dcc6a91818a18dffbbc262f8a4c4483857158c0af4f55dfe9b28
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maflcko @hebasto @decryp2kanon @fanquake