Remove references to CreateWalletFromFile #20285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Approach ACK 54ac7c8
bitcoin/test/sanitizer_suppressions/tsan
Line 35 in c5ec036
|
Concept ACK: thanks for removing old cruft, but please remove the entry from |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
54ac7c8 to
64ffbba
Compare
Done. |
dergoegge
approved these changes
Nov 7, 2020
There was a problem hiding this comment.
ACK 64ffbba - All the references to CreateWalletFromFile were removed, except the ones in the release notes.
Before:
[niklas:~/workspace/bitcoin] c5ec0367d* ± ag "CreateWalletFromFile" .
test/sanitizer_suppressions/tsan
35:deadlock:wallet_tests::CreateWalletFromFile
doc/release-notes/release-notes-0.19.0.1.md
491:- #16745 Translate all initErrors in CreateWalletFromFile (MarcoFalke)
495:- #16796 Fix segfault in CreateWalletFromFile (MarcoFalke)
src/wallet/test/wallet_tests.cpp
691://! Test CreateWalletFromFile function and its behavior handling potential race
709:BOOST_FIXTURE_TEST_CASE(CreateWalletFromFile, TestChain100Setup)
src/init.cpp
1148: // High fee check is done afterward in CWallet::CreateWalletFromFile()
After:
[niklas:~/workspace/bitcoin] createwalletfromfilenomore* ± ag "CreateWalletFromFile" .
doc/release-notes/release-notes-0.19.0.1.md
491:- #16745 Translate all initErrors in CreateWalletFromFile (MarcoFalke)
495:- #16796 Fix segfault in CreateWalletFromFile (MarcoFalke)
hebasto
reviewed
Nov 7, 2020
CWallet::CreateWalletFromFile() was removed in 8b5e729 but these references remain.
dc2c22e to
c82336c
Compare
hebasto
approved these changes
Nov 12, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 12, 2020
c82336c Remove references to CreateWalletFromFile (fanquake) Pull request description: `CWallet::CreateWalletFromFile()` was removed in 8b5e729 but these references remain. ACKs for top commit: hebasto: ACK c82336c Tree-SHA512: 3dd50fe0cd5a60bbc96d265107d4739f3e08f943435f3772038963ac4be9e4a87a863412ac0d571226ea66d71550b17b52f01b9d46a6282d49feae1508fd682e
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 23, 2021
Summary: `CWallet::CreateWalletFromFile()` was removed in D10228 but these references remain. This is a backport of [[bitcoin/bitcoin#20285 | core#20285]] Test Plan: `grep -r CreateWalletFromFile` With TSAN: `ninja check check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10724
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CWallet::CreateWalletFromFile()was removed in 8b5e729 but these references remain.