tests: don't export in6addr_loopback #20129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't export `in6addr_loopback` because that upsets `contrib/devtools/symbol-check.py` Fixes bitcoin#20127
|
Either the patch in this PR or the following should fix the problem (as mentioned in #20127 (comment)): diff --git i/contrib/devtools/symbol-check.py w/contrib/devtools/symbol-check.py
index 6949cb7ce..5178ac0d4 100755
--- i/contrib/devtools/symbol-check.py
+++ w/contrib/devtools/symbol-check.py
@@ -45,13 +45,13 @@ MAX_VERSIONS = {
# See here for a description of _IO_stdin_used:
# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=634261#109
# Ignore symbols that are exported as part of every executable
IGNORE_EXPORTS = {
'_edata', '_end', '__end__', '_init', '__bss_start', '__bss_start__', '_bss_end__', '__bss_end__', '_fini', '_IO_stdin_used', 'stdin', 'stdout', 'stderr',
-'environ', '_environ', '__environ',
+'environ', '_environ', '__environ', 'in6addr_loopback',
}
READELF_CMD = os.getenv('READELF', '/usr/bin/readelf')
CPPFILT_CMD = os.getenv('CPPFILT', '/usr/bin/c++filt')
OBJDUMP_CMD = os.getenv('OBJDUMP', '/usr/bin/objdump')
OTOOL_CMD = os.getenv('OTOOL', '/usr/bin/otool')
|
|
Concept ACK, but I do wonder, why do we run the symbol check on the unit tests? Edit: oh I guess because they are shipped in the binary release. Never mind. |
|
utACK 8e4d622 |
hebasto
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
ACK 8e4d622
https://www.man7.org/linux/man-pages/man7/ipv6.7.html:
The IPv6 loopback address (::1) is available in the global in6addr_loopback variable. For initializations, IN6ADDR_LOOPBACK_INIT should be used.
Guix builds
|
Gitian builds |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 11, 2021
Summary: ``` Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). Add support for ADDRv2 format in `CAddress` (un)serialization. ``` Partial backport (2/4) of core [[bitcoin/bitcoin#19954 | PR19954]]: bitcoin/bitcoin@201a459 Includes a fix for the symbol check that would cause the gitian build to fail: Backport of core [[bitcoin/bitcoin#20129 | PR20129]]. and a fix for a mismatch initialization order in the `CAddress` class (reversal of `nTime` and `nServices` to match core). Depends on D9190 and D9198. Test Plan: ninja all check-all Run the Linux Gitian build. Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9199
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Aug 30, 2021
8e4d622 tests: don't export in6addr_loopback (Vasil Dimov) Pull request description: Don't export `in6addr_loopback` because that upsets `contrib/devtools/symbol-check.py` Fixes bitcoin#20127 ACKs for top commit: sipa: utACK 8e4d622 hebasto: ACK 8e4d622 Tree-SHA512: 216ffb53df55d2888317a81d18745308aaf93a3f3b45aa778166f7c91edb9741c28424d6333b35cefb5ece42b74e20ea21c761d93d8432798e7ec12097c2758f
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Sep 7, 2021
8e4d622 tests: don't export in6addr_loopback (Vasil Dimov) Pull request description: Don't export `in6addr_loopback` because that upsets `contrib/devtools/symbol-check.py` Fixes bitcoin#20127 ACKs for top commit: sipa: utACK 8e4d622 hebasto: ACK 8e4d622 Tree-SHA512: 216ffb53df55d2888317a81d18745308aaf93a3f3b45aa778166f7c91edb9741c28424d6333b35cefb5ece42b74e20ea21c761d93d8432798e7ec12097c2758f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't export
in6addr_loopbackbecause that upsetscontrib/devtools/symbol-check.pyFixes #20127