Skip to content

util: Do not use gArgs global in ArgsManager member functions #20092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

util: Do not use gArgs global in ArgsManager member functions #20092

merged 1 commit into from
Oct 7, 2020

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Oct 6, 2020

No description provided.

promag
promag reviewed Oct 6, 2020
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also drop gArgs from ReadConfigFiles?

@hebasto hebasto changed the title util: Do not use gArgs global in ArgsManager::GetHelpMessage util: Do not use gArgs global in ArgsManager member functions Oct 6, 2020
@hebasto
Copy link
Member Author

hebasto commented Oct 6, 2020

Updated 7d3c3fe -> d103484 (pr20092.01 -> pr20092.02, diff):

Could also drop gArgs from ReadConfigFiles?

@practicalswift
Copy link
Contributor

ACK d103484: patch looks correct

@maflcko maflcko merged commit 283a73d into bitcoin:master Oct 7, 2020
@promag
Copy link
Contributor

promag commented Oct 7, 2020

ACK d103484.

@hebasto hebasto deleted the 201006-gargs branch October 7, 2020 07:49
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 3, 2021
@hebasto @PiRK
util: Do not use gArgs global in ArgsManager member functions
1b705e9 
Summary: This is a backport of [[bitcoin/bitcoin#20092 | core#20092]]

Test Plan: `ninja all check-all`

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D10429
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@promag promag promag left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Utils/log/libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hebasto @practicalswift @promag @fanquake @maflcko