test: Check that invalid peer traffic is accounted for #20028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasild
approved these changes
Sep 28, 2020
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Sep 28, 2020
|
ACK faa94cb: patch looks correct |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 29, 2020
…ed for faa94cb test: Check that invalid peer traffic is accounted for (MarcoFalke) fae243f test: Remove confusing cast to same type (int to int) (MarcoFalke) Pull request description: Couldn't find a test for this and it seems something we should test, so I wrote one. ACKs for top commit: vasild: ACK faa94cb practicalswift: ACK faa94cb: patch looks correct Tree-SHA512: efcdd35960045cdfbd14480e16e0d1d09e81eb01670ac541ac2b105e1a63818a157c95853270242234a224880873e79957832bf4231374d7fe81de30f35e3abf
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 15, 2021
Summary: > Couldn't find a test for this and it seems something we should test, so I wrote one. Commits: > test: Remove confusing cast to same type (int to int) > test: Check that invalid peer traffic is accounted for This is a backport of [[bitcoin/bitcoin#20028 | core#20028]] Backport notes: - we ban for a bad checksum (see D2289), so the change in `test_checksum` is not applicable - the change in indentation for `self.nodes[0].disconnect_p2ps()` on line 144 was supposed to be done in D9530. It does not affect the behavior, it just moves a cleanup disconnection outside the assertion scope Test Plan: `test/functional/test_runner.py p2p_invalid_messages` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10348
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't find a test for this and it seems something we should test, so I wrote one.