Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Apr 28, 2024

Set minimum required glibc to 2.31.
The glibc 2.31 branch is still maintained: https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/release/2.31/master.

Remove the stack-protector check from test-security-check, as the test
no-longer fails, and given the control we have of the end, the actual
security-check test seems sufficient (this might also be applied to some
of the other checks).

Drops runtime support for Ubuntu Bionic 18.04 and RHEL-8 from the release binaries.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 28, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan
Concept ACK laanwj, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #27038 (security-check: test for _FORTIFY_SOURCE usage in release binaries by fanquake)
  • #24123 (guix: Pointer Authentication and Branch Target Identification for aarch64 Linux (Guix) by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@laanwj
Copy link
Member

laanwj commented Apr 28, 2024

Concept ACK.

For context: 2.31 is the version in Ubuntu 20.04 LTS: https://packages.ubuntu.com/search?keywords=libc6&searchon=names&suite=focal&section=all

@hebasto
Copy link
Member

hebasto commented Apr 28, 2024

Concept ACK.

@DrahtBot
Copy link
Contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File commit 3aaf732
(master)
commit f7476db
(master and this pull)
SHA256SUMS.part 8ce4f4b597436a2f... e9203b2d7289235e...
*-aarch64-linux-gnu-debug.tar.gz 19c81ef4929cb615... 225aeb49b50cda0e...
*-aarch64-linux-gnu.tar.gz ff703ec621a73e3d... a16c03cc9a6483af...
*-arm-linux-gnueabihf-debug.tar.gz c94e8a9a48ba461d... 38e2f9eda7afcf35...
*-arm-linux-gnueabihf.tar.gz fae274acd21e12a5... 9fab28af22a4520d...
*-arm64-apple-darwin-unsigned.tar.gz 7f6368310d01f063... 101efbfa96e21ee3...
*-arm64-apple-darwin-unsigned.zip a13f6058d091c9c4... 222710293e3b3984...
*-arm64-apple-darwin.tar.gz b67f21e1175a1474... 1f06a3da97ff99eb...
*-powerpc64-linux-gnu-debug.tar.gz 6784df54895f62f1... ba331003298af9e9...
*-powerpc64-linux-gnu.tar.gz 76186c9b67fc37b9... 86383b946efcecbb...
*-riscv64-linux-gnu-debug.tar.gz 37407f08315cb072... 890e8e119c743ec5...
*-riscv64-linux-gnu.tar.gz c850f117f2c47f30... bfdd2fa0afe3c50a...
*-x86_64-apple-darwin-unsigned.tar.gz 864a4371d95076e4... 509c743cfc870db8...
*-x86_64-apple-darwin-unsigned.zip f83ac30e770da990... 7fa43da8ef969d2a...
*-x86_64-apple-darwin.tar.gz af4aa412d08a1fe4... 89e6c3ea23bdb034...
*-x86_64-linux-gnu-debug.tar.gz e33e9a3326fa8005... 8e7df665dc995689...
*-x86_64-linux-gnu.tar.gz 40cfaebaff94fed3... 14dae8ea1b16b505...
*.tar.gz 9c9a35e818ddc287... 052832cd94a134bb...
guix_build.log 50c3d8042667f717... 991fe935dacfb37b...
guix_build.log.diff 090587a012de9f4a...

@maflcko
Copy link
Member

maflcko commented Apr 29, 2024

It would be good to mention that this drops support for Ubuntu Bionic 18.04 and RHEL-8 (and forks) completely, going forward.

@fanquake
Copy link
Member Author

That is shown in the changes in symbol-check, but I'll add it to the op, and can add a rel note.

(sha256
(base32
"0azpb9cvnbv25zg8019rqz48h8i2257ngyjg566dlnp74ivrs9vq"))
(patches (search-our-patches "glibc-2.27-riscv64-Use-__has_include-to-include-asm-syscalls.h.patch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to get rid of these libc patches, especially the rv64 one.

@fanquake
Copy link
Member Author

fanquake commented May 3, 2024

Guix Build (aarch64)

d5b65771bb9c1d2e4e49fbb78305e97a99ca43e608ced495f8c437855701d6af  guix-build-f5a949b90881/output/aarch64-linux-gnu/SHA256SUMS.part
113d77f864bac9382aa7598cb038a822aff2c961348ed9ca747a168ec87199bb  guix-build-f5a949b90881/output/aarch64-linux-gnu/bitcoin-f5a949b90881-aarch64-linux-gnu-debug.tar.gz
4a25c348e2921d27542f39cd5ccb6c7cf3aba72c89fecf69f4f66d63c4d5b623  guix-build-f5a949b90881/output/aarch64-linux-gnu/bitcoin-f5a949b90881-aarch64-linux-gnu.tar.gz
6157c1dc24f370b008c605cbb3ecffa1457b667673056d890833645547544482  guix-build-f5a949b90881/output/arm-linux-gnueabihf/SHA256SUMS.part
e02ef1dd8163ae03742bc80612574da4f23578b15b5902a7e76e74c90cbecc10  guix-build-f5a949b90881/output/arm-linux-gnueabihf/bitcoin-f5a949b90881-arm-linux-gnueabihf-debug.tar.gz
d0d249f86275b79b328525f2c30388a6ada66a82c37192bec48808d5d38343fe  guix-build-f5a949b90881/output/arm-linux-gnueabihf/bitcoin-f5a949b90881-arm-linux-gnueabihf.tar.gz
d6794a51de7d2dd025ead7056f6773da0b7a80178bf7d08a57d91590162792f8  guix-build-f5a949b90881/output/arm64-apple-darwin/SHA256SUMS.part
133bde0050ac3c6cee703129af75e0bc92936bce665a65f53e56238ebe248549  guix-build-f5a949b90881/output/arm64-apple-darwin/bitcoin-f5a949b90881-arm64-apple-darwin-unsigned.tar.gz
cc9d3c5e592e5de91f489be8c40575f90b7f288a9107bcd221ef47b7086d2f8c  guix-build-f5a949b90881/output/arm64-apple-darwin/bitcoin-f5a949b90881-arm64-apple-darwin-unsigned.zip
dca1a961714a91e5cabdb44b0faa47d74300a6c5ef9ee2ce6fb6e2275a59e810  guix-build-f5a949b90881/output/arm64-apple-darwin/bitcoin-f5a949b90881-arm64-apple-darwin.tar.gz
25b54cf81380bc68e9cba9416f68d1b0c2d4df1441b48f09d10ece07d70a3e5c  guix-build-f5a949b90881/output/dist-archive/bitcoin-f5a949b90881.tar.gz
49ae2bff0116a54cc70015ab05009b27b4173954c39873fa0836be6bf5a28ed8  guix-build-f5a949b90881/output/powerpc64-linux-gnu/SHA256SUMS.part
2f40f73f6cd49241a438d09e4efbd02d9893f4d53ae6a0f88487f6ea898dd8e4  guix-build-f5a949b90881/output/powerpc64-linux-gnu/bitcoin-f5a949b90881-powerpc64-linux-gnu-debug.tar.gz
b472a460abd20967df1d6c3b7d02dbf2fd539b10345abb1a7a3fd60d83b5d657  guix-build-f5a949b90881/output/powerpc64-linux-gnu/bitcoin-f5a949b90881-powerpc64-linux-gnu.tar.gz
64f33247b61e227d317b4da06b018ebbbdee296ea434b2c7512e929e9f7c51e7  guix-build-f5a949b90881/output/riscv64-linux-gnu/SHA256SUMS.part
610610460f9ec9f12751864eaee1dedfa7ff2ce9ce2b48dccc247ab8a3faa48c  guix-build-f5a949b90881/output/riscv64-linux-gnu/bitcoin-f5a949b90881-riscv64-linux-gnu-debug.tar.gz
271c55eb8fb0be2d8a426f8d9f62f706e5847a0fa9ddf8e358ab37292c5f8d35  guix-build-f5a949b90881/output/riscv64-linux-gnu/bitcoin-f5a949b90881-riscv64-linux-gnu.tar.gz
bfd6ec13657b37872bfccd75760ee8dd433853bb725fd4d4be0eba27b548b587  guix-build-f5a949b90881/output/x86_64-apple-darwin/SHA256SUMS.part
896d93cd00d9f6ffe21847f936544cf36d19f82d83807008ee152ce698f1e28f  guix-build-f5a949b90881/output/x86_64-apple-darwin/bitcoin-f5a949b90881-x86_64-apple-darwin-unsigned.tar.gz
0c1d29f669f2d343b3a263de9adb94da55c7c86517d568a79af462ad9516718a  guix-build-f5a949b90881/output/x86_64-apple-darwin/bitcoin-f5a949b90881-x86_64-apple-darwin-unsigned.zip
76a8d4718003430b26b8769c9326a5ed7b771fdb14fd5e9bb085dbcc84e19266  guix-build-f5a949b90881/output/x86_64-apple-darwin/bitcoin-f5a949b90881-x86_64-apple-darwin.tar.gz
033700117ea5d9553b8af3526acbead59f2ff35353f9842bc57987920a76add2  guix-build-f5a949b90881/output/x86_64-linux-gnu/SHA256SUMS.part
dfa35d5c203bd05823d4a4978b70ec4f21d3c6a5bab28f9e03befea67b7386e0  guix-build-f5a949b90881/output/x86_64-linux-gnu/bitcoin-f5a949b90881-x86_64-linux-gnu-debug.tar.gz
8ca02c111530e62a18a31d9aea92b0c7b0f4ec061a58b53f27d5e92c3974829c  guix-build-f5a949b90881/output/x86_64-linux-gnu/bitcoin-f5a949b90881-x86_64-linux-gnu.tar.gz
1b705f13584f9ad6dbd4a0fd3f51adb3302cb7da07cb0c115805628ccd57d981  guix-build-f5a949b90881/output/x86_64-w64-mingw32/SHA256SUMS.part
152aa747ad4a59882ce266a3958779b6fe49027ce5675789fb3a60777c30f56c  guix-build-f5a949b90881/output/x86_64-w64-mingw32/bitcoin-f5a949b90881-win64-debug.zip
a6fd72d4a5f4518e927ca871d88594adeb6a95fcfe76e395352e5d35d52c56ec  guix-build-f5a949b90881/output/x86_64-w64-mingw32/bitcoin-f5a949b90881-win64-setup-unsigned.exe
46ef6ed1d165ac6699c293a8c7c36d8f6f97c4d0e960f255b8ca4e0e1639fd60  guix-build-f5a949b90881/output/x86_64-w64-mingw32/bitcoin-f5a949b90881-win64-unsigned.tar.gz
90f92900af3b39e3c0a629b4ad279e793427f68da0930472487468408fb469ca  guix-build-f5a949b90881/output/x86_64-w64-mingw32/bitcoin-f5a949b90881-win64.zip

@fanquake
Copy link
Member Author

fanquake commented May 4, 2024

Rebased and pulled in 1 more commit from the 2.31 branch.

@laanwj
Copy link
Member

laanwj commented May 5, 2024

Same output as @fanquake (just stock ubuntu 24.04 amd64)

d5b65771bb9c1d2e4e49fbb78305e97a99ca43e608ced495f8c437855701d6af  guix-build-f5a949b90881/output/aarch64-linux-gnu/SHA256SUMS.part
113d77f864bac9382aa7598cb038a822aff2c961348ed9ca747a168ec87199bb  guix-build-f5a949b90881/output/aarch64-linux-gnu/bitcoin-f5a949b90881-aarch64-linux-gnu-debug.tar.gz
4a25c348e2921d27542f39cd5ccb6c7cf3aba72c89fecf69f4f66d63c4d5b623  guix-build-f5a949b90881/output/aarch64-linux-gnu/bitcoin-f5a949b90881-aarch64-linux-gnu.tar.gz
6157c1dc24f370b008c605cbb3ecffa1457b667673056d890833645547544482  guix-build-f5a949b90881/output/arm-linux-gnueabihf/SHA256SUMS.part
e02ef1dd8163ae03742bc80612574da4f23578b15b5902a7e76e74c90cbecc10  guix-build-f5a949b90881/output/arm-linux-gnueabihf/bitcoin-f5a949b90881-arm-linux-gnueabihf-debug.tar.gz
d0d249f86275b79b328525f2c30388a6ada66a82c37192bec48808d5d38343fe  guix-build-f5a949b90881/output/arm-linux-gnueabihf/bitcoin-f5a949b90881-arm-linux-gnueabihf.tar.gz
d6794a51de7d2dd025ead7056f6773da0b7a80178bf7d08a57d91590162792f8  guix-build-f5a949b90881/output/arm64-apple-darwin/SHA256SUMS.part
133bde0050ac3c6cee703129af75e0bc92936bce665a65f53e56238ebe248549  guix-build-f5a949b90881/output/arm64-apple-darwin/bitcoin-f5a949b90881-arm64-apple-darwin-unsigned.tar.gz
cc9d3c5e592e5de91f489be8c40575f90b7f288a9107bcd221ef47b7086d2f8c  guix-build-f5a949b90881/output/arm64-apple-darwin/bitcoin-f5a949b90881-arm64-apple-darwin-unsigned.zip
dca1a961714a91e5cabdb44b0faa47d74300a6c5ef9ee2ce6fb6e2275a59e810  guix-build-f5a949b90881/output/arm64-apple-darwin/bitcoin-f5a949b90881-arm64-apple-darwin.tar.gz
25b54cf81380bc68e9cba9416f68d1b0c2d4df1441b48f09d10ece07d70a3e5c  guix-build-f5a949b90881/output/dist-archive/bitcoin-f5a949b90881.tar.gz
49ae2bff0116a54cc70015ab05009b27b4173954c39873fa0836be6bf5a28ed8  guix-build-f5a949b90881/output/powerpc64-linux-gnu/SHA256SUMS.part
2f40f73f6cd49241a438d09e4efbd02d9893f4d53ae6a0f88487f6ea898dd8e4  guix-build-f5a949b90881/output/powerpc64-linux-gnu/bitcoin-f5a949b90881-powerpc64-linux-gnu-debug.tar.gz
b472a460abd20967df1d6c3b7d02dbf2fd539b10345abb1a7a3fd60d83b5d657  guix-build-f5a949b90881/output/powerpc64-linux-gnu/bitcoin-f5a949b90881-powerpc64-linux-gnu.tar.gz
64f33247b61e227d317b4da06b018ebbbdee296ea434b2c7512e929e9f7c51e7  guix-build-f5a949b90881/output/riscv64-linux-gnu/SHA256SUMS.part
610610460f9ec9f12751864eaee1dedfa7ff2ce9ce2b48dccc247ab8a3faa48c  guix-build-f5a949b90881/output/riscv64-linux-gnu/bitcoin-f5a949b90881-riscv64-linux-gnu-debug.tar.gz
271c55eb8fb0be2d8a426f8d9f62f706e5847a0fa9ddf8e358ab37292c5f8d35  guix-build-f5a949b90881/output/riscv64-linux-gnu/bitcoin-f5a949b90881-riscv64-linux-gnu.tar.gz
bfd6ec13657b37872bfccd75760ee8dd433853bb725fd4d4be0eba27b548b587  guix-build-f5a949b90881/output/x86_64-apple-darwin/SHA256SUMS.part
896d93cd00d9f6ffe21847f936544cf36d19f82d83807008ee152ce698f1e28f  guix-build-f5a949b90881/output/x86_64-apple-darwin/bitcoin-f5a949b90881-x86_64-apple-darwin-unsigned.tar.gz
0c1d29f669f2d343b3a263de9adb94da55c7c86517d568a79af462ad9516718a  guix-build-f5a949b90881/output/x86_64-apple-darwin/bitcoin-f5a949b90881-x86_64-apple-darwin-unsigned.zip
76a8d4718003430b26b8769c9326a5ed7b771fdb14fd5e9bb085dbcc84e19266  guix-build-f5a949b90881/output/x86_64-apple-darwin/bitcoin-f5a949b90881-x86_64-apple-darwin.tar.gz
033700117ea5d9553b8af3526acbead59f2ff35353f9842bc57987920a76add2  guix-build-f5a949b90881/output/x86_64-linux-gnu/SHA256SUMS.part
dfa35d5c203bd05823d4a4978b70ec4f21d3c6a5bab28f9e03befea67b7386e0  guix-build-f5a949b90881/output/x86_64-linux-gnu/bitcoin-f5a949b90881-x86_64-linux-gnu-debug.tar.gz
8ca02c111530e62a18a31d9aea92b0c7b0f4ec061a58b53f27d5e92c3974829c  guix-build-f5a949b90881/output/x86_64-linux-gnu/bitcoin-f5a949b90881-x86_64-linux-gnu.tar.gz
1b705f13584f9ad6dbd4a0fd3f51adb3302cb7da07cb0c115805628ccd57d981  guix-build-f5a949b90881/output/x86_64-w64-mingw32/SHA256SUMS.part
152aa747ad4a59882ce266a3958779b6fe49027ce5675789fb3a60777c30f56c  guix-build-f5a949b90881/output/x86_64-w64-mingw32/bitcoin-f5a949b90881-win64-debug.zip
a6fd72d4a5f4518e927ca871d88594adeb6a95fcfe76e395352e5d35d52c56ec  guix-build-f5a949b90881/output/x86_64-w64-mingw32/bitcoin-f5a949b90881-win64-setup-unsigned.exe
46ef6ed1d165ac6699c293a8c7c36d8f6f97c4d0e960f255b8ca4e0e1639fd60  guix-build-f5a949b90881/output/x86_64-w64-mingw32/bitcoin-f5a949b90881-win64-unsigned.tar.gz
90f92900af3b39e3c0a629b4ad279e793427f68da0930472487468408fb469ca  guix-build-f5a949b90881/output/x86_64-w64-mingw32/bitcoin-f5a949b90881-win64.zip

@luke-jr
Copy link
Member

luke-jr commented May 7, 2024

Is there a benefit to this? Just dropping patches?

@fanquake
Copy link
Member Author

fanquake commented May 8, 2024

Is there a benefit to this? Just dropping patches?

No, it's not just dropping patches. It's about us not having to maintain an EOL branch of glibc, us getting bugfixes (if relevant) to the branch we are using, us getting closer to properly supporting hardening features, fully static builds etc, by using a glibc that supports them.

@laanwj
Copy link
Member

laanwj commented May 8, 2024

New used symbols since 2.28:

 81: 0000000000000000     0 FUNC    GLOBAL DEFAULT  UND fcntl64@GLIBC_2.28 (15)

fcntl function that can handle large file offsets on 32 bit platforms. Used in unixFileLock. unixShmLock and other posix/unix file functions.

195: 0000000000000000     0 FUNC    GLOBAL DEFAULT  UND statx@GLIBC_2.28 (15)

Extended file stat. Used in QFileSystemEngine::fillMetaData.

533: 0000000000000000     0 FUNC    GLOBAL DEFAULT  UND renameat2@GLIBC_2.28 (15

Renaming function with flag for atomic exchange and no-overwrite. Used in QFileSystemEngine::renameFile.

 85: 0000000000000000     0 FUNC    GLOBAL DEFAULT  UND log@GLIBC_2.29 (12)
750: 0000000000116400     0 FUNC    GLOBAL DEFAULT  UND exp@GLIBC_2.29 (12)
776: 0000000000116c50     0 FUNC    GLOBAL DEFAULT  UND pow@GLIBC_2.29 (12)

Newer libm symbols (apparently more optimized, i can't find much about it).

485: 0000000000000000     0 FUNC    GLOBAL DEFAULT  UND pthread_cond_clockwait@GLIBC_2.30 (32)

Wait on a condition variable until a specific clock (eg the monotonic one) reaches a certain value. Used in std::cv_status std::condition_variable::wait_for.

@fanquake fanquake force-pushed the build_with_glibc_2_31 branch from 39e6c7a to 8706069 Compare May 14, 2024 06:25
@fanquake
Copy link
Member Author

Pulled in the most recent commits to the 2.31 branch. Mostly make 4.4 compat.

@fanquake fanquake force-pushed the build_with_glibc_2_31 branch from 8706069 to 99b1130 Compare May 22, 2024 10:04
@fanquake fanquake force-pushed the build_with_glibc_2_31 branch from 99b1130 to b60294b Compare May 29, 2024 10:37
@fanquake
Copy link
Member Author

Guix Build (aarch64):

aa0ac90d4abc930dee2327985fafdbee9c40c8eeea5738383e798f076db36766  guix-build-b5fc6d46a385/output/aarch64-linux-gnu/SHA256SUMS.part
c25dec340e71ba13b238cc743cb86cb6ee564b05f47a1d3df2240f90b8cdf1cd  guix-build-b5fc6d46a385/output/aarch64-linux-gnu/bitcoin-b5fc6d46a385-aarch64-linux-gnu-debug.tar.gz
b7e9627b89d06e2646fcc5430f2eb08ab920039cfa9d4ce14917830bc48ba129  guix-build-b5fc6d46a385/output/aarch64-linux-gnu/bitcoin-b5fc6d46a385-aarch64-linux-gnu.tar.gz
3afe6f97bc085bad28555430131f56a50e15820f00d77db9d4cbe463f451c06e  guix-build-b5fc6d46a385/output/arm-linux-gnueabihf/SHA256SUMS.part
4ee08a0aaa779319020c12b5a3c556bc835e038097bd9f665b1c6df9a2732799  guix-build-b5fc6d46a385/output/arm-linux-gnueabihf/bitcoin-b5fc6d46a385-arm-linux-gnueabihf-debug.tar.gz
cf015fa6f9f0c12ef90ae451c910736ea96ac221a63466cd30256fa8f201e0fa  guix-build-b5fc6d46a385/output/arm-linux-gnueabihf/bitcoin-b5fc6d46a385-arm-linux-gnueabihf.tar.gz
d4d2d6a525aa5fcda4d67d3024d2601068a8712ce718de173e0cdaf0742ba079  guix-build-b5fc6d46a385/output/arm64-apple-darwin/SHA256SUMS.part
40135d226b4900cabbcc74fe0d0e35b3129aa2d6367dda7179fffd672228ac03  guix-build-b5fc6d46a385/output/arm64-apple-darwin/bitcoin-b5fc6d46a385-arm64-apple-darwin-unsigned.tar.gz
a073e52f6c8d5d80ff596160d387c1ad273fcc63eeeb7c3ac63183c5422ffa49  guix-build-b5fc6d46a385/output/arm64-apple-darwin/bitcoin-b5fc6d46a385-arm64-apple-darwin-unsigned.zip
7692dc9a09cac770686d6a6fe60a15e4f403cbad201383ef2ea92abba7734e17  guix-build-b5fc6d46a385/output/arm64-apple-darwin/bitcoin-b5fc6d46a385-arm64-apple-darwin.tar.gz
a6118cf3bff90fe330f45020330bf53f981d311a63d9c2c216f7a514f881b93a  guix-build-b5fc6d46a385/output/dist-archive/bitcoin-b5fc6d46a385.tar.gz
d864e5dffe1cd2bf6219e51d9282719e0bd47cceb1f44efa25debe7e472ef4cd  guix-build-b5fc6d46a385/output/powerpc64-linux-gnu/SHA256SUMS.part
6806307932421ba0149b8a8c342d504a31fc92b3e03e9e8ac807aba37e6ac9cd  guix-build-b5fc6d46a385/output/powerpc64-linux-gnu/bitcoin-b5fc6d46a385-powerpc64-linux-gnu-debug.tar.gz
c0b2a3fa16121784098d58dbc0942e5ae12ce61857b60262b3ad4b53ac2e3403  guix-build-b5fc6d46a385/output/powerpc64-linux-gnu/bitcoin-b5fc6d46a385-powerpc64-linux-gnu.tar.gz
9463a083b6066d2047a361a77543e6902bdbcb245e9b760d3922c14f72654514  guix-build-b5fc6d46a385/output/riscv64-linux-gnu/SHA256SUMS.part
a0469c0350134fbf8a3401e9d4b6e211c749febe27f33a2ad5d2f8fe8af6db82  guix-build-b5fc6d46a385/output/riscv64-linux-gnu/bitcoin-b5fc6d46a385-riscv64-linux-gnu-debug.tar.gz
0bd0dc42678639e7f48538af52b72cf50b49b0eceede8f5a68cdd54f2f04e38b  guix-build-b5fc6d46a385/output/riscv64-linux-gnu/bitcoin-b5fc6d46a385-riscv64-linux-gnu.tar.gz
268304a2d7876b6f24896b8fa05b0bd69bdb1e8cc2ef192d229419dcf227b73e  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/SHA256SUMS.part
580bea16e8b9337ae3547f477917091d2e1a886ba45ad616bd814c964e4aaa06  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/bitcoin-b5fc6d46a385-x86_64-apple-darwin-unsigned.tar.gz
4f7fe24916888cda3c20c8278e897df1f13c99b3c5a7b5f4b9b0cb09adbe2dde  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/bitcoin-b5fc6d46a385-x86_64-apple-darwin-unsigned.zip
16391b2ca27573a033d79f5bf180530f8cf11b0f2309d6b24b95fc39b358d1f7  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/bitcoin-b5fc6d46a385-x86_64-apple-darwin.tar.gz
8379647cfcfd3b95a6356da8dd4faa05cd7be7d59ec31d105db5cba8f94ccba8  guix-build-b5fc6d46a385/output/x86_64-linux-gnu/SHA256SUMS.part
3bac7cec89159d7eba4fcbfcae5f561cb6b19963d6fc64e616307dcaaa37d2d6  guix-build-b5fc6d46a385/output/x86_64-linux-gnu/bitcoin-b5fc6d46a385-x86_64-linux-gnu-debug.tar.gz
43af7d4377177d6251f7f3eea7d5261aaf649502c41d9466cccbb48a5d955887  guix-build-b5fc6d46a385/output/x86_64-linux-gnu/bitcoin-b5fc6d46a385-x86_64-linux-gnu.tar.gz
ebc05d82976a43cd54235474825c25478409d2b7a55284dfe6b5089cb0bc058c  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/SHA256SUMS.part
75d9d07b0c642f33729bbdd30a651103c4315d23a76e05e5651911fec27077c9  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64-debug.zip
5502afe88cc36fce4027e24fd0635350ca76cd291b511ab577c6e42fd2e520b0  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64-setup-unsigned.exe
1fc65d7c35393bd2c67b5e2ffe3621910ba662da5ed3d774c7739fdeba47ef58  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64-unsigned.tar.gz
02c433b5ff7fbb212bc1f3aba57f5ad8ddbec3d43ff3f31e356fd172b049fbe4  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64.zip

@fanquake fanquake requested a review from theuni June 20, 2024 15:41
Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guix build (riscv64)

aa0ac90d4abc930dee2327985fafdbee9c40c8eeea5738383e798f076db36766  guix-build-b5fc6d46a385/output/aarch64-linux-gnu/SHA256SUMS.part
c25dec340e71ba13b238cc743cb86cb6ee564b05f47a1d3df2240f90b8cdf1cd  guix-build-b5fc6d46a385/output/aarch64-linux-gnu/bitcoin-b5fc6d46a385-aarch64-linux-gnu-debug.tar.gz
b7e9627b89d06e2646fcc5430f2eb08ab920039cfa9d4ce14917830bc48ba129  guix-build-b5fc6d46a385/output/aarch64-linux-gnu/bitcoin-b5fc6d46a385-aarch64-linux-gnu.tar.gz
3afe6f97bc085bad28555430131f56a50e15820f00d77db9d4cbe463f451c06e  guix-build-b5fc6d46a385/output/arm-linux-gnueabihf/SHA256SUMS.part
4ee08a0aaa779319020c12b5a3c556bc835e038097bd9f665b1c6df9a2732799  guix-build-b5fc6d46a385/output/arm-linux-gnueabihf/bitcoin-b5fc6d46a385-arm-linux-gnueabihf-debug.tar.gz
cf015fa6f9f0c12ef90ae451c910736ea96ac221a63466cd30256fa8f201e0fa  guix-build-b5fc6d46a385/output/arm-linux-gnueabihf/bitcoin-b5fc6d46a385-arm-linux-gnueabihf.tar.gz
d4d2d6a525aa5fcda4d67d3024d2601068a8712ce718de173e0cdaf0742ba079  guix-build-b5fc6d46a385/output/arm64-apple-darwin/SHA256SUMS.part
40135d226b4900cabbcc74fe0d0e35b3129aa2d6367dda7179fffd672228ac03  guix-build-b5fc6d46a385/output/arm64-apple-darwin/bitcoin-b5fc6d46a385-arm64-apple-darwin-unsigned.tar.gz
a073e52f6c8d5d80ff596160d387c1ad273fcc63eeeb7c3ac63183c5422ffa49  guix-build-b5fc6d46a385/output/arm64-apple-darwin/bitcoin-b5fc6d46a385-arm64-apple-darwin-unsigned.zip
7692dc9a09cac770686d6a6fe60a15e4f403cbad201383ef2ea92abba7734e17  guix-build-b5fc6d46a385/output/arm64-apple-darwin/bitcoin-b5fc6d46a385-arm64-apple-darwin.tar.gz
a6118cf3bff90fe330f45020330bf53f981d311a63d9c2c216f7a514f881b93a  guix-build-b5fc6d46a385/output/dist-archive/bitcoin-b5fc6d46a385.tar.gz
d864e5dffe1cd2bf6219e51d9282719e0bd47cceb1f44efa25debe7e472ef4cd  guix-build-b5fc6d46a385/output/powerpc64-linux-gnu/SHA256SUMS.part
6806307932421ba0149b8a8c342d504a31fc92b3e03e9e8ac807aba37e6ac9cd  guix-build-b5fc6d46a385/output/powerpc64-linux-gnu/bitcoin-b5fc6d46a385-powerpc64-linux-gnu-debug.tar.gz
c0b2a3fa16121784098d58dbc0942e5ae12ce61857b60262b3ad4b53ac2e3403  guix-build-b5fc6d46a385/output/powerpc64-linux-gnu/bitcoin-b5fc6d46a385-powerpc64-linux-gnu.tar.gz
9463a083b6066d2047a361a77543e6902bdbcb245e9b760d3922c14f72654514  guix-build-b5fc6d46a385/output/riscv64-linux-gnu/SHA256SUMS.part
a0469c0350134fbf8a3401e9d4b6e211c749febe27f33a2ad5d2f8fe8af6db82  guix-build-b5fc6d46a385/output/riscv64-linux-gnu/bitcoin-b5fc6d46a385-riscv64-linux-gnu-debug.tar.gz
0bd0dc42678639e7f48538af52b72cf50b49b0eceede8f5a68cdd54f2f04e38b  guix-build-b5fc6d46a385/output/riscv64-linux-gnu/bitcoin-b5fc6d46a385-riscv64-linux-gnu.tar.gz
268304a2d7876b6f24896b8fa05b0bd69bdb1e8cc2ef192d229419dcf227b73e  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/SHA256SUMS.part
580bea16e8b9337ae3547f477917091d2e1a886ba45ad616bd814c964e4aaa06  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/bitcoin-b5fc6d46a385-x86_64-apple-darwin-unsigned.tar.gz
4f7fe24916888cda3c20c8278e897df1f13c99b3c5a7b5f4b9b0cb09adbe2dde  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/bitcoin-b5fc6d46a385-x86_64-apple-darwin-unsigned.zip
16391b2ca27573a033d79f5bf180530f8cf11b0f2309d6b24b95fc39b358d1f7  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/bitcoin-b5fc6d46a385-x86_64-apple-darwin.tar.gz
8379647cfcfd3b95a6356da8dd4faa05cd7be7d59ec31d105db5cba8f94ccba8  guix-build-b5fc6d46a385/output/x86_64-linux-gnu/SHA256SUMS.part
3bac7cec89159d7eba4fcbfcae5f561cb6b19963d6fc64e616307dcaaa37d2d6  guix-build-b5fc6d46a385/output/x86_64-linux-gnu/bitcoin-b5fc6d46a385-x86_64-linux-gnu-debug.tar.gz
43af7d4377177d6251f7f3eea7d5261aaf649502c41d9466cccbb48a5d955887  guix-build-b5fc6d46a385/output/x86_64-linux-gnu/bitcoin-b5fc6d46a385-x86_64-linux-gnu.tar.gz
ebc05d82976a43cd54235474825c25478409d2b7a55284dfe6b5089cb0bc058c  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/SHA256SUMS.part
75d9d07b0c642f33729bbdd30a651103c4315d23a76e05e5651911fec27077c9  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64-debug.zip
5502afe88cc36fce4027e24fd0635350ca76cd291b511ab577c6e42fd2e520b0  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64-setup-unsigned.exe
1fc65d7c35393bd2c67b5e2ffe3621910ba662da5ed3d774c7739fdeba47ef58  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64-unsigned.tar.gz
02c433b5ff7fbb212bc1f3aba57f5ad8ddbec3d43ff3f31e356fd172b049fbe4  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64.zip

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b5fc6d4

@DrahtBot DrahtBot requested review from laanwj and hebasto June 25, 2024 14:00
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Guix build:

x86_64
aa0ac90d4abc930dee2327985fafdbee9c40c8eeea5738383e798f076db36766  guix-build-b5fc6d46a385/output/aarch64-linux-gnu/SHA256SUMS.part
c25dec340e71ba13b238cc743cb86cb6ee564b05f47a1d3df2240f90b8cdf1cd  guix-build-b5fc6d46a385/output/aarch64-linux-gnu/bitcoin-b5fc6d46a385-aarch64-linux-gnu-debug.tar.gz
b7e9627b89d06e2646fcc5430f2eb08ab920039cfa9d4ce14917830bc48ba129  guix-build-b5fc6d46a385/output/aarch64-linux-gnu/bitcoin-b5fc6d46a385-aarch64-linux-gnu.tar.gz
3afe6f97bc085bad28555430131f56a50e15820f00d77db9d4cbe463f451c06e  guix-build-b5fc6d46a385/output/arm-linux-gnueabihf/SHA256SUMS.part
4ee08a0aaa779319020c12b5a3c556bc835e038097bd9f665b1c6df9a2732799  guix-build-b5fc6d46a385/output/arm-linux-gnueabihf/bitcoin-b5fc6d46a385-arm-linux-gnueabihf-debug.tar.gz
cf015fa6f9f0c12ef90ae451c910736ea96ac221a63466cd30256fa8f201e0fa  guix-build-b5fc6d46a385/output/arm-linux-gnueabihf/bitcoin-b5fc6d46a385-arm-linux-gnueabihf.tar.gz
d4d2d6a525aa5fcda4d67d3024d2601068a8712ce718de173e0cdaf0742ba079  guix-build-b5fc6d46a385/output/arm64-apple-darwin/SHA256SUMS.part
40135d226b4900cabbcc74fe0d0e35b3129aa2d6367dda7179fffd672228ac03  guix-build-b5fc6d46a385/output/arm64-apple-darwin/bitcoin-b5fc6d46a385-arm64-apple-darwin-unsigned.tar.gz
a073e52f6c8d5d80ff596160d387c1ad273fcc63eeeb7c3ac63183c5422ffa49  guix-build-b5fc6d46a385/output/arm64-apple-darwin/bitcoin-b5fc6d46a385-arm64-apple-darwin-unsigned.zip
7692dc9a09cac770686d6a6fe60a15e4f403cbad201383ef2ea92abba7734e17  guix-build-b5fc6d46a385/output/arm64-apple-darwin/bitcoin-b5fc6d46a385-arm64-apple-darwin.tar.gz
a6118cf3bff90fe330f45020330bf53f981d311a63d9c2c216f7a514f881b93a  guix-build-b5fc6d46a385/output/dist-archive/bitcoin-b5fc6d46a385.tar.gz
d864e5dffe1cd2bf6219e51d9282719e0bd47cceb1f44efa25debe7e472ef4cd  guix-build-b5fc6d46a385/output/powerpc64-linux-gnu/SHA256SUMS.part
6806307932421ba0149b8a8c342d504a31fc92b3e03e9e8ac807aba37e6ac9cd  guix-build-b5fc6d46a385/output/powerpc64-linux-gnu/bitcoin-b5fc6d46a385-powerpc64-linux-gnu-debug.tar.gz
c0b2a3fa16121784098d58dbc0942e5ae12ce61857b60262b3ad4b53ac2e3403  guix-build-b5fc6d46a385/output/powerpc64-linux-gnu/bitcoin-b5fc6d46a385-powerpc64-linux-gnu.tar.gz
9463a083b6066d2047a361a77543e6902bdbcb245e9b760d3922c14f72654514  guix-build-b5fc6d46a385/output/riscv64-linux-gnu/SHA256SUMS.part
a0469c0350134fbf8a3401e9d4b6e211c749febe27f33a2ad5d2f8fe8af6db82  guix-build-b5fc6d46a385/output/riscv64-linux-gnu/bitcoin-b5fc6d46a385-riscv64-linux-gnu-debug.tar.gz
0bd0dc42678639e7f48538af52b72cf50b49b0eceede8f5a68cdd54f2f04e38b  guix-build-b5fc6d46a385/output/riscv64-linux-gnu/bitcoin-b5fc6d46a385-riscv64-linux-gnu.tar.gz
268304a2d7876b6f24896b8fa05b0bd69bdb1e8cc2ef192d229419dcf227b73e  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/SHA256SUMS.part
580bea16e8b9337ae3547f477917091d2e1a886ba45ad616bd814c964e4aaa06  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/bitcoin-b5fc6d46a385-x86_64-apple-darwin-unsigned.tar.gz
4f7fe24916888cda3c20c8278e897df1f13c99b3c5a7b5f4b9b0cb09adbe2dde  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/bitcoin-b5fc6d46a385-x86_64-apple-darwin-unsigned.zip
16391b2ca27573a033d79f5bf180530f8cf11b0f2309d6b24b95fc39b358d1f7  guix-build-b5fc6d46a385/output/x86_64-apple-darwin/bitcoin-b5fc6d46a385-x86_64-apple-darwin.tar.gz
8379647cfcfd3b95a6356da8dd4faa05cd7be7d59ec31d105db5cba8f94ccba8  guix-build-b5fc6d46a385/output/x86_64-linux-gnu/SHA256SUMS.part
3bac7cec89159d7eba4fcbfcae5f561cb6b19963d6fc64e616307dcaaa37d2d6  guix-build-b5fc6d46a385/output/x86_64-linux-gnu/bitcoin-b5fc6d46a385-x86_64-linux-gnu-debug.tar.gz
43af7d4377177d6251f7f3eea7d5261aaf649502c41d9466cccbb48a5d955887  guix-build-b5fc6d46a385/output/x86_64-linux-gnu/bitcoin-b5fc6d46a385-x86_64-linux-gnu.tar.gz
ebc05d82976a43cd54235474825c25478409d2b7a55284dfe6b5089cb0bc058c  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/SHA256SUMS.part
75d9d07b0c642f33729bbdd30a651103c4315d23a76e05e5651911fec27077c9  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64-debug.zip
5502afe88cc36fce4027e24fd0635350ca76cd291b511ab577c6e42fd2e520b0  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64-setup-unsigned.exe
1fc65d7c35393bd2c67b5e2ffe3621910ba662da5ed3d774c7739fdeba47ef58  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64-unsigned.tar.gz
02c433b5ff7fbb212bc1f3aba57f5ad8ddbec3d43ff3f31e356fd172b049fbe4  guix-build-b5fc6d46a385/output/x86_64-w64-mingw32/bitcoin-b5fc6d46a385-win64.zip

@DrahtBot DrahtBot requested a review from hebasto June 26, 2024 00:19
@fanquake fanquake merged commit 0c57a79 into bitcoin:master Jun 26, 2024
@fanquake fanquake deleted the build_with_glibc_2_31 branch June 26, 2024 14:22
Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge utACK b5fc6d4

@maflcko maflcko mentioned this pull request Sep 30, 2024
kwvg added a commit to kwvg/dash that referenced this pull request Nov 4, 2024
kwvg added a commit to kwvg/dash that referenced this pull request Nov 5, 2024
kwvg added a commit to kwvg/dash that referenced this pull request Nov 5, 2024
kwvg added a commit to kwvg/dash that referenced this pull request Nov 6, 2024
PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Nov 10, 2024
, bitcoin#26470, bitcoin#27296, bitcoin#27179, bitcoin#27813, bitcoin#27811, bitcoin#28069, bitcoin#28294, bitcoin#28324, bitcoin#28328, bitcoin#29987 (guix backports: part 4)

1edd121 merge bitcoin#29987: build with glibc 2.31 (Kittywhiskers Van Gogh)
0949825 revert: add exception for 32-bit ARM builds which need glibc 2.28 (Kittywhiskers Van Gogh)
0ac2531 merge bitcoin#28328: update time-machine (Kittywhiskers Van Gogh)
ef9c4bd merge bitcoin#28324: pre time-machine bump changes (Linux) (Kittywhiskers Van Gogh)
b45a127 merge bitcoin#28294: pre time-machine bump changes (Windows) (Kittywhiskers Van Gogh)
ed1f7fe merge bitcoin#28069: Remove librt usage from release binaries (Kittywhiskers Van Gogh)
5d51aa9 merge bitcoin#27811: Clean up manifest (Kittywhiskers Van Gogh)
d439e46 merge bitcoin#27813: Update `python-lief` package to 0.13.2 (Kittywhiskers Van Gogh)
70e6283 merge bitcoin#27179: use osslsigncode 2.5 (Kittywhiskers Van Gogh)
3799509 merge bitcoin#27296: import/sync python-lief (0.12.3) package definition from upstream (Kittywhiskers Van Gogh)
ac8bd5a refactor: move lief definitions to expected location (Kittywhiskers Van Gogh)
eb0ae08 merge bitcoin#26470: Clean up `libexec/build.sh` (Kittywhiskers Van Gogh)
d3d7a05 merge bitcoin#24031: don't compress macOS DMG (Kittywhiskers Van Gogh)
6a54603 merge bitcoin#27670: remove redundant glibc patches (Kittywhiskers Van Gogh)
0c988f0 merge bitcoin#21089: Add support for powerpc64{,le} (Kittywhiskers Van Gogh)
808d215 fix: set correct locale in guix ci container (UdjinM6)

Pull request description:

  ## Motivation

  In preparation for migrating to C++20 and bumping our minimum required compiler to ensure that we have access to greater portions of the C++20 spec, this pull request first of two pull requests aiming to upgrade our Guix setup to use GCC 12 (and GCC 11 for the macOS toolchain).

  Upgrades to the Clang toolchain for macOS and moving to GCC 12 for the macOS toolchain will be addressed in a separate pull request as the latter requires [bitcoin#21778](bitcoin#21778), which is well outside the scope of this PR.

  ## Additional Notes

  * Dependency for #6383

  * Newer versions of GCC will not behave as expected with `test-security-check.py` as the stack protector (listed as `Canary` in the test) now behaves as expected and no longer fails. This causes an error when running it as the test expects failure (see below). This isn't an issue upstream as they backported [bitcoin#29987](bitcoin#29987), which gets rid of those tests ([source](bitcoin@b5fc6d4#diff-52aa0cda44721f089e53b128cb1232a876006ef257b211655456b17dfb2ec712)).

    Therefore, we have backported that pull request as well.

    <details>

    <summary>Build failure:</summary>

    ```
    ======================================================================
    FAIL: test_ELF (__main__.TestSecurityChecks)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/distsrc-base/distsrc-22.0.0-beta.1-70-g7907fab39c17-x86_64-linux-gnu/./contrib/devtools/test-security-check.py", line 61, in test_ELF
        self.assertEqual(call_security_check(cc, source, executable, ['-Wl,-zexecstack','-fno-stack-protector','-Wl,-znorelro','-no-pie','-fno-PIE', '-Wl,-z,separate-code']),
    AssertionError: Tuples differ: (1, 'test1: failed PIE NX RELRO CONTROL_FLOW') != (1, 'test1: failed PIE NX RELRO Canary CONTROL_FLOW')

    First differing element 1:
    'test1: failed PIE NX RELRO CONTROL_FLOW'
    'test1: failed PIE NX RELRO Canary CONTROL_FLOW'

    - (1, 'test1: failed PIE NX RELRO CONTROL_FLOW')
    + (1, 'test1: failed PIE NX RELRO Canary CONTROL_FLOW')
    ?                                +++++++

    ----------------------------------------------------------------------
    Ran 1 test in 0.126s

    FAILED (failures=1)
    ```

    </details>

    * The backport has the effect of bumping the target glibc version to 2.31, which as the release notes say, cuts off support for RHEL 8 and Ubuntu 18.04 LTS (`bionic`) (i.e. our Guix binaries won't run on these distros anymore, users running those distros will have to compile it themselves).

    This shouldn't be a problem as full support for RHEL 8 ended May 31, 2024 ([source](https://access.redhat.com/support/policy/updates/errata#Life_Cycle_Dates)) and standard support for `bionic` ended April 2023 ([source](https://ubuntu.com/about/release-cycle)).

    **Dash Core will still work on Ubuntu 20.04 LTS (`focal`) as it ships with glibc 2.31 ([source](https://packages.ubuntu.com/focal/glibc-doc))**

  ## Breaking Changes

  None expected

  ## Checklist:

  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**
  - [x] I have added or updated relevant unit/integration/functional/e2e tests
  - [x] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK 1edd121

Tree-SHA512: 194a35a72ede5fb5488cdc41eb15320df7a5fa1fb8815c7342dd15b3983efff417fb1a525fdf497a98ede91958d0a5ed18f3e5f0f27c5cbc5dc25eb58116dbd5
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 29, 2024
Summary:
```
Set minimum required glibc to 2.31.
The glibc 2.31 branch is still maintained:
https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/release/2.31/master.

Remove the stack-protector check from test-security-check, as the test
no-longer fails, and given the control we have of the end, the actual
security-check test seems sufficient (this might also be applied to some
of the other checks).

Drops runtime support for Ubuntu Bionic 18.04 and RHEL-8 from the release binaries.
```

Backport of [[bitcoin/bitcoin#29987 | core#29987]].

Depends on D17236.

Test Plan: Run the Linux Guix build.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D17237
roqqit pushed a commit to doged-io/doged that referenced this pull request Dec 2, 2024
Summary:
```
Set minimum required glibc to 2.31.
The glibc 2.31 branch is still maintained:
https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/release/2.31/master.

Remove the stack-protector check from test-security-check, as the test
no-longer fails, and given the control we have of the end, the actual
security-check test seems sufficient (this might also be applied to some
of the other checks).

Drops runtime support for Ubuntu Bionic 18.04 and RHEL-8 from the release binaries.
```

Backport of [[bitcoin/bitcoin#29987 | core#29987]].

Depends on D17236.

Test Plan: Run the Linux Guix build.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D17237
knst added a commit to knst/dash that referenced this pull request Dec 26, 2024
achow101 added a commit to bitcoin-core/packaging that referenced this pull request Apr 15, 2025
ebc7d2e snap: core20 (with ci) (maflcko)

Pull request description:

  The `core18` builder is insufficient, now that glibc in the release builds was bumped (bitcoin/bitcoin#29987).

  Fix it by bumping to `core20`, because `core18` is also deprecated and only available in the snapcraft `7.x` track according to https://snapcraft.io/docs/base-snaps#core18.

  The change comes with required fixups in the `snapcraft.yaml`.

  This change also comes with a required switch to lxd in the CI. This is, because "For core20, Multipass is the default provider on all platforms.", according to https://canonical-snapcraft.readthedocs-hosted.com/en/latest/howto/select-a-build-provider/#core20-override-methods. However, multipass by default uses a QEMU KVM driver, according to https://canonical.com/multipass/docs/driver#p-74200-default-drivers. So just use lxd in the CI, as KVM isn't available.

ACKs for top commit:
  achow101:
    ACK ebc7d2e
  hebasto:
    re-ACK ebc7d2e.

Tree-SHA512: 69b419fc397a37a3fbc54f4b999b9cb794fd8ff9d9b712e3ce87d11c3401e7723ab45a1198223bde4b284de09cb86ef5887fcdefbadbfb5af0e631bb1e963d85
@bitcoin bitcoin locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants