test: add missing comparison of node1's mempool in MempoolPackagesTest #29941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
glozow
reviewed
Apr 23, 2024
squashed. |
instagibbs
reviewed
Apr 23, 2024
test/functional/mempool_packages.py
Outdated
| assert_equal(mempool[tx]['unbroadcast'], False) | ||
|
|
||
| # TODO: test ancestor size limits | ||
| # Check more detailed check of node1's mempool |
There was a problem hiding this comment.
these comments are not needed(and indented wrong); I think they can just all be removed since the test is self-explanatory
There was a problem hiding this comment.
Could you please clarify what you meant by "indented wrong"? I believe these lines are intended to follow the same indentation pattern as the rest of the file. If there's a specific indentation style that should be applied here, I'd appreciate your guidance.
There was a problem hiding this comment.
But I agreed with you. Those lines are self explanatory. I removed the comments.
|
@glozow could you review again and see if it meets the requirements now ..? |
achow101
added a commit
that referenced
this pull request
May 10, 2024
…oolPackagesTest e912717 test: add missing comparison of node1's mempool in MempoolPackagesTest (umiumi) Pull request description: #29941 Recreated a pull request because there was a conflict. Trying to resolve the conflict but the old one automatically closed. Add missing comparison for TODO comments in `mempool_packages.py` Also, notice that the ancestor size limits and descendant size limits actually implemented in #21800 , so I removed the todo for those two size limits. ACKs for top commit: kevkevinpal: ACK [e912717](e912717) achow101: ACK e912717 alfonsoromanz: Tested ACK e912717. The code looks good to me and the test execution is successful. rkrux: tACK [e912717](e912717) Tree-SHA512: 8cb51746b0547369344c9ceef59599bfe9c91d424687af5e24dc6641f9e99fb433515d79c724e71fd3d5e02994f0cef623d3674367b8296b05c3c6fcdde282ef
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 25, 2024
…in MempoolPackagesTest e912717 test: add missing comparison of node1's mempool in MempoolPackagesTest (umiumi) Pull request description: bitcoin#29941 Recreated a pull request because there was a conflict. Trying to resolve the conflict but the old one automatically closed. Add missing comparison for TODO comments in `mempool_packages.py` Also, notice that the ancestor size limits and descendant size limits actually implemented in bitcoin#21800 , so I removed the todo for those two size limits. ACKs for top commit: kevkevinpal: ACK [e912717](bitcoin@e912717) achow101: ACK e912717 alfonsoromanz: Tested ACK e912717. The code looks good to me and the test execution is successful. rkrux: tACK [e912717](bitcoin@e912717) Tree-SHA512: 8cb51746b0547369344c9ceef59599bfe9c91d424687af5e24dc6641f9e99fb433515d79c724e71fd3d5e02994f0cef623d3674367b8296b05c3c6fcdde282ef
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 26, 2024
…in MempoolPackagesTest e912717 test: add missing comparison of node1's mempool in MempoolPackagesTest (umiumi) Pull request description: bitcoin#29941 Recreated a pull request because there was a conflict. Trying to resolve the conflict but the old one automatically closed. Add missing comparison for TODO comments in `mempool_packages.py` Also, notice that the ancestor size limits and descendant size limits actually implemented in bitcoin#21800 , so I removed the todo for those two size limits. ACKs for top commit: kevkevinpal: ACK [e912717](bitcoin@e912717) achow101: ACK e912717 alfonsoromanz: Tested ACK e912717. The code looks good to me and the test execution is successful. rkrux: tACK [e912717](bitcoin@e912717) Tree-SHA512: 8cb51746b0547369344c9ceef59599bfe9c91d424687af5e24dc6641f9e99fb433515d79c724e71fd3d5e02994f0cef623d3674367b8296b05c3c6fcdde282ef
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing comparison for TODO comments in
mempool_packages.pyAlso, notice that the ancestor size limits and descendant size limits actually implemented in #21800 , so I removed the todo for those two size limits.