-
Notifications
You must be signed in to change notification settings - Fork 37.7k
doc: Suggest only necessary Qt packages for installation on OpenBSD #29947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
cc @theStack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK b175ca9
Verified on a fresh install of OpenBSD 7.5 that these two packages are the minimum requirement to build the GUI:
- Without
qtbase
, the configure script invoked via./configure --with-gui=qt5 MAKE=gmake
fails withconfigure: error: Qt5Core >= 5.11.3 not found
. - Without
qttools
, the configure script fails withconfigure: error: LRELEASE not found
. - With both installed, the configure passes and the build succeeds.
Concept ACK. It's nice that OpenBSD provides separate modules for Qt nowadays. |
Please update the version number in line 3 of the doc as well. I don't know if there is a difference between 7.4 and 7.5, but it can't hurt to be accurate here. |
The currently suggested `qt5` installs many unneeded dependencies, for example, `qtsensors`, `qtspeech` etc.
b175ca9
to
970cbc3
Compare
Sure. Updated. |
Concept ACK I have no (easy) way to verify that exactly those packages suffice, thus not full ACK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-ACK 970cbc3
85e480a doc: Update NetBSD Build Guide (Hennadii Stepanov) Pull request description: This PR updates the NetBSD Build Guide to reflect: - the recent NetBSD Release - GCC minimum supported version update (#28348 and #29091) - Python minimum supported version update (#28211) Also a smaller package set has been suggested: - `boost-headers` instead of the full `boost` - `qt5-qtbase qt5-qttools` instead of the full `qt5` (similar to #29932 and #29947). ACKs for top commit: maflcko: utACK 85e480a Tree-SHA512: 0848b6f169a00f2da78eea452fd116193aece853680f4e615ba1df654246ec2a9d1600a4cfb238eb9305b72bbe4b2873519bf1e2987eaaf48aba900c64e85a48
The currently suggested
qt5
installs many unneeded dependencies, for example,qtsensors
,qtspeech
etc.Similar to #29932.