Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 23, 2024

The currently suggested qt5 installs many unneeded dependencies, for example, qtsensors, qtspeech etc.

Similar to #29932.

@hebasto hebasto added the Docs label Apr 23, 2024
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 23, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK theStack
Concept ACK laanwj, vasild

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto
Copy link
Member Author

hebasto commented Apr 23, 2024

cc @theStack

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK b175ca9

Verified on a fresh install of OpenBSD 7.5 that these two packages are the minimum requirement to build the GUI:

  • Without qtbase, the configure script invoked via ./configure --with-gui=qt5 MAKE=gmake fails with configure: error: Qt5Core >= 5.11.3 not found.
  • Without qttools, the configure script fails with configure: error: LRELEASE not found.
  • With both installed, the configure passes and the build succeeds.

@laanwj
Copy link
Member

laanwj commented Apr 24, 2024

Concept ACK. It's nice that OpenBSD provides separate modules for Qt nowadays.

@maflcko
Copy link
Member

maflcko commented Apr 24, 2024

Verified on a fresh install of OpenBSD 7.5 that these two packages are the minimum requirement to build the GUI:

Please update the version number in line 3 of the doc as well. I don't know if there is a difference between 7.4 and 7.5, but it can't hurt to be accurate here.

The currently suggested `qt5` installs many unneeded dependencies, for
example, `qtsensors`, `qtspeech` etc.
@hebasto hebasto force-pushed the 240423-openbsd-qt-deps branch from b175ca9 to 970cbc3 Compare April 24, 2024 08:18
@hebasto
Copy link
Member Author

hebasto commented Apr 24, 2024

Verified on a fresh install of OpenBSD 7.5 that these two packages are the minimum requirement to build the GUI:

Please update the version number in line 3 of the doc as well. I don't know if there is a difference between 7.4 and 7.5, but it can't hurt to be accurate here.

Sure. Updated.

@bitcoin bitcoin deleted a comment from Kellydutch1 Apr 24, 2024
@vasild
Copy link
Contributor

vasild commented Apr 24, 2024

Concept ACK

I have no (easy) way to verify that exactly those packages suffice, thus not full ACK.

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK 970cbc3

@DrahtBot DrahtBot requested review from laanwj and vasild April 24, 2024 12:11
@fanquake fanquake merged commit 631a2b5 into bitcoin:master Apr 24, 2024
@hebasto hebasto deleted the 240423-openbsd-qt-deps branch April 24, 2024 14:01
fanquake added a commit that referenced this pull request May 21, 2024
85e480a doc: Update NetBSD Build Guide (Hennadii Stepanov)

Pull request description:

  This PR updates the NetBSD Build Guide to reflect:
  - the recent NetBSD Release
  - GCC minimum supported version update (#28348 and #29091)
  - Python minimum supported version update (#28211)

  Also a smaller package set has been suggested:
  - `boost-headers` instead of the full `boost`
  - `qt5-qtbase qt5-qttools` instead of the full `qt5` (similar to #29932 and #29947).

ACKs for top commit:
  maflcko:
    utACK 85e480a

Tree-SHA512: 0848b6f169a00f2da78eea452fd116193aece853680f4e615ba1df654246ec2a9d1600a4cfb238eb9305b72bbe4b2873519bf1e2987eaaf48aba900c64e85a48
@bitcoin bitcoin locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants