Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 11, 2024

Resolves one item in the #28981 (review):

  • Remove linter exclusions and fix all issues.

Based on upstream arun11299/cpp-subprocess#101.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 11, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto
Copy link
Member Author

hebasto commented Apr 11, 2024

cc @theStack

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 13f5391

@fanquake fanquake merged commit 0de63b8 into bitcoin:master Apr 11, 2024
@hebasto hebasto deleted the 240411-subp-linter branch April 11, 2024 14:20
Pttn added a commit to RiecoinTeam/Riecoin that referenced this pull request Apr 13, 2024
# Conflicts:
#	test/lint/lint-spelling.py
@Jgoedhart1988

This comment was marked as spam.

Jgoedhart1988

This comment was marked as spam.

@bitcoin bitcoin locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants