assumeutxo: Add mainnet chainparams for block 830000 #29551
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Hm, moving to draft since there seems to be an open question if we want to wait for #26045. |
|
Just realised this is also a duplicate of #28553. So closing this. |
There was a problem hiding this comment.
I think the biggest issue the open question about distribution.
Would it be ok to just add an entry to chainparams and let the wider space figure it out (maybe someone out there will put the utxo set dump on a website or start a torrent)? Or should we come up with some kind of distribution mechanism before that?
…ptxoutset output 542e13b rpc: Enhance metadata of the dumptxoutset output (Fabian Jahr) 4d8e5ed assumeutxo: Add documentation on dumptxoutset serialization format (Fabian Jahr) c14ed7f assumeutxo: Add test for changed coin size value (Fabian Jahr) de95953 rpc: Optimize serialization disk space of dumptxoutset (Fabian Jahr) Pull request description: The second attempt at implementing the `dumptxoutset` space optimization as suggested in #25675. Closes #25675. This builds on the work done in #26045, addresses open feedback, adds some further improvements (most importantly usage of compact size), documentation, and an additional test. The [original snapshot at height 830,000](#29551) came in at 10.82 GB. With this change, the same snapshot is 8.94 GB, a reduction of 17.4%. This also enhances the metadata of the output file and adds the following data to allow for better error handling and make future upgrades easier: - A newly introduced utxo set magic - A version number - The network magic - The block height ACKs for top commit: achow101: ACK 542e13b TheCharlatan: Re-ACK 542e13b theStack: ACK 542e13b Tree-SHA512: 0825d30e5c3c364062db3c6cbca4e3c680e6e6d3e259fa70c0c2b2a7020f24a47406a623582040988d5c7745b08649c31110df4c10656aa25f3f27eb35843d99
This seems to have fallen a bit by the wayside (or I missed the conversation) but I don't see a blocker to not have them. I will share a link to the file shortly txoutsetfile.