test, assumeutxo: Add test to ensure failure when mempool not empty #29394
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
9d17e19 to
8021940
Compare
8021940 to
da13cc2
Compare
|
lgtm ACK da13cc2 Thanks |
Thanks for mentioning that, I think that leaving node 2 was a better alternative becuase it makes this a cleaner and more test , and avoids the errors that might arise in future code changes (mentioned by @maflcko and others that might arise) but i was struggling to find a solution and / or follow your suggestion somehow. It's nice that we can all agree in this way, thanks. |
da13cc2 to
8d20602
Compare
|
Fixed the last nit: Pushed to remove the extra space mentioned by @fjahr |
|
Please don't invalidate two ACKs for a single space style issue. If you care about the style, it is your responsibility to take care of before opening the pull request, or before pushing the code. You can use any auto-formatter of your choice. re-ACK 8d20602 |
…e loaded df6dc2a test: Assumeutxo: snapshots with less work should not be loaded (Hernan Marino) Pull request description: This PR adds a test which checks that snapshots with less accumulated work than the node's active chain, should not be loaded and return with an error. Although in a different context of discussion the missing test was detect in a thread in #29394 (see #29394 (comment)) ACKs for top commit: maflcko: utACK df6dc2a kevkevinpal: utACK [df6dc2a](df6dc2a) achow101: ACK df6dc2a alfonsoromanz: Re ACK df6dc2a. Make is successful and the test passes. Tree-SHA512: 07a394b4b288cc8ad3f66ed4e70dcda468db18113e9442eb7215cf491768432d55efaaa5b79d633094917e05475a30f0c5e4f64f8f2da293ba306891b4485560
Add a test to ensure that loadtxoutset fails when the node's mempool is not empty, as suggested by maflcko here: #27596 (comment)