rpc: Fix race in loadtxoutset #29262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2024 16:48
The tip may have advanced, also if it did not, there is no reason to have two variables point to the same block.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Approach ACK, thanks. |
BrandonOdiwuor
approved these changes
Jan 18, 2024
|
Should this be backported? |
|
ACK 5555d8d |
I don't think assumeutxo params were specified for the main chain, and a wrong RPC result output in some test cases seems harmless. |
Retropex
pushed a commit
to Retropex/bitcoin
that referenced
this pull request
Mar 28, 2024
The tip may have advanced, also if it did not, there is no reason to have two variables point to the same block. Github-Pull: bitcoin#29262 Rebased-From: fa91089
Retropex
pushed a commit
to Retropex/bitcoin
that referenced
this pull request
Mar 28, 2024
Github-Pull: bitcoin#29262 Rebased-From: 5555d8d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tip may have advanced, also if it did not, there is no reason to
have two variables point to the same block.
Fixes #27596 (comment)