Skip to content

Conversation

reardencode
Copy link

@reardencode reardencode commented Jan 18, 2024

This pull request forks from #29198 and includes only OP_INTERNALKEY and its tests.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 18, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
Concept ACK moonsettler

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #31519 (refactor: Use std::span over Span by maflcko)
  • #31460 (fuzz: Expand script verification flag testing to segwit v0 and tapscript by dergoegge)
  • #29270 (Implement OP_CHECKSIGFROMSTACK(VERIFY) by reardencode)
  • #29247 (CAT in Tapscript (BIP-347) by 0xBEEFCAF3)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@moonsettler
Copy link

Concept ACK!

Testing is minimal, but so is the code.
@fanquake
Copy link
Member

Closing for now, given #29198 was closed.

@fanquake fanquake closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants