ci: Use Ubuntu 24.04 Noble for asan,tsan,tidy,fuzz #28992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
fanquake
approved these changes
Dec 6, 2023
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Dec 6, 2023
Github-Pull: bitcoin#28992 Rebased-From: fad2392
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Dec 6, 2023
Github-Pull: bitcoin#28992 Rebased-From: fad2392
Merged
|
Will be backported in #29011. |
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Dec 8, 2023
Github-Pull: bitcoin#28992 Rebased-From: fad2392
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Dec 8, 2023
Github-Pull: bitcoin#28992 Rebased-From: fad2392
|
When I apply this patch and run |
|
Looks like something similar (for LLVM 18) is being worked around upstream, by just creating the missing file: include-what-you-use/include-what-you-use#1350. |
|
Will be fixed in |
This has shipped, and |
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 4, 2024
Github-Pull: bitcoin#28992 Rebased-From: fa83b65
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 4, 2024
Github-Pull: bitcoin#28992 Rebased-From: fad2392
glozow
added a commit
that referenced
this pull request
Jan 9, 2024
7b79e54 doc: update release notes for 26.x (fanquake) ccf00b1 wallet: Fix use-after-free in WalletBatch::EraseRecords (MarcoFalke) 40252e1 ci: Set `HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK` to avoid failures (Hennadii Stepanov) b06b14e rpc: getwalletinfo, return wallet 'birthtime' (furszy) 1283401 test: coverage for wallet birth time interaction with -reindex (furszy) 0fa47e2 wallet: fix legacy spkm default birth time (furszy) 84f4a6c wallet: birth time update during tx scanning (furszy) 074296d refactor: rename FirstKeyTimeChanged to MaybeUpdateBirthTime (furszy) 35039ac fuzz: disable BnB when SFFO is enabled (furszy) 903b462 test: add coverage for BnB-SFFO restriction (furszy) 05d0576 wallet: create tx, log resulting coin selection info (furszy) 5493ebb wallet: skip BnB when SFFO is active (Murch) b15e2e2 test: add regression test for the getrawtransaction segfault (Martin Zumsande) 5097bb3 rpc: fix getrawtransaction segfault (Martin Zumsande) 81e744a ci: Use Ubuntu 24.04 Noble for asan (MarcoFalke) 69e53d1 ci: Use Ubuntu 24.04 Noble for tsan,tidy,fuzz (MarcoFalke) d2c80b6 doc: Missing additions to 26.0 release notes (fanquake) 8dc2c75 doc: add historical release notes for 26.0 (fanquake) Pull request description: Backports for `26.x`. Currently: * #28920 * #28992 * #28994 * #29003 * #29023 * #29080 * #29176 ACKs for top commit: TheCharlatan: ACK 7b79e54 glozow: ACK 7b79e54, matches mine Tree-SHA512: 898aec76ed3ad35e0edd0980af5bcc21bd60003bbf69e0b4f473ed2aa38c4e3b360b930bc3747cf798195906a8f9fe66417524f5e5ef40fa68f1c1aaceebdeb0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
23.10 will be EOL mid next year, so a bump is needed before then for the
masterbranch (and possibly the26.xbranch).Doing the bump now is fine, because the clang version is pinned to 17 inside the CI tasks. So a default clang version change in the system image should not affect the tasks. Once clang-18 is available and the default in April next year (https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649#planned-and-potentially-disruptive-archive-wide-activities-2), the pinned version could be bumped (for CI tasks that require a pin, like tidy), or the pin can be removed (for CI tasks that usually do not require a pin, like fuzz or the sanitizers).