depends: remove PYTHONPATH from config.site
#28845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
When was this last used? |
When we were building DMGs for macOS. |
|
Concept ACK |
TheCharlatan
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
ACK 95aab1f
There is nothing in that path anymore.
Guix builds (x86_64)
92c922498b9d7e68742355653cc84317d0f0947e8fdd012488c9875e8b54e03c guix-build-95aab1f02784/output/aarch64-linux-gnu/SHA256SUMS.part
634a6a7a82efcb86eb7e875aa4534bd5646e80ee21e951d9624ca7ff78fc82f5 guix-build-95aab1f02784/output/aarch64-linux-gnu/bitcoin-95aab1f02784-aarch64-linux-gnu-debug.tar.gz
2dd4305e325723cac4b0b8e1803d48f3d7eb6fa2fd49c0a980ff907bb3e5da2b guix-build-95aab1f02784/output/aarch64-linux-gnu/bitcoin-95aab1f02784-aarch64-linux-gnu.tar.gz
b530c235e15adefc8b70dd2eabc158b68f04a21c015a84f4af71a9764a39b683 guix-build-95aab1f02784/output/arm-linux-gnueabihf/SHA256SUMS.part
cfc9b374c4bf32eb98dfb162d8425e10fa4f061434d61e889d2314c3c44aab2b guix-build-95aab1f02784/output/arm-linux-gnueabihf/bitcoin-95aab1f02784-arm-linux-gnueabihf-debug.tar.gz
853b6f53a33158cccc12dac7233ab61300ea04af101757fa8e3d8fbcc77c51f6 guix-build-95aab1f02784/output/arm-linux-gnueabihf/bitcoin-95aab1f02784-arm-linux-gnueabihf.tar.gz
fe27470edb16d97eb19d9003b2cabad25c39d74080ce661dd4bf44f00318ca39 guix-build-95aab1f02784/output/arm64-apple-darwin/SHA256SUMS.part
33db851a372b2a3d29b4699f84601b88f7bfb3c036413072f56a6d5c07c0876f guix-build-95aab1f02784/output/arm64-apple-darwin/bitcoin-95aab1f02784-arm64-apple-darwin-unsigned.tar.gz
bb1abc9b23830e9954d195859d73ea495a7995e3aafa7d1199146191ea9fe6e7 guix-build-95aab1f02784/output/arm64-apple-darwin/bitcoin-95aab1f02784-arm64-apple-darwin-unsigned.zip
8e811bffca09d5ab4301591c7442e6f38a49050635dc7a986dcd7007f763007f guix-build-95aab1f02784/output/arm64-apple-darwin/bitcoin-95aab1f02784-arm64-apple-darwin.tar.gz
ced6b51c3a91d518ee0c7d0370d5fc6a60edc30f2f937722e9cf8bb853756c53 guix-build-95aab1f02784/output/dist-archive/bitcoin-95aab1f02784.tar.gz
ca79b0d6cb803d66b166f2a1ea66bc1ad7eff7cbddb73b301de23e4919bdb883 guix-build-95aab1f02784/output/powerpc64-linux-gnu/SHA256SUMS.part
dd77383315e31fdafbde03667c223e45130b5259202dd728d26fa8a3580860dd guix-build-95aab1f02784/output/powerpc64-linux-gnu/bitcoin-95aab1f02784-powerpc64-linux-gnu-debug.tar.gz
6e2d39badf21c2a33e93ac8b3822d3b87c71e94acf5b27ece628d6c1d77bd43d guix-build-95aab1f02784/output/powerpc64-linux-gnu/bitcoin-95aab1f02784-powerpc64-linux-gnu.tar.gz
8f4cdd590d95ac77123f534fa645a1f0c3f03b802d76c4640d6af36b910acf53 guix-build-95aab1f02784/output/powerpc64le-linux-gnu/SHA256SUMS.part
14aafcdfdecccbe835307ae29c5d2738d43d5c56aece4627373abd364e6c2559 guix-build-95aab1f02784/output/powerpc64le-linux-gnu/bitcoin-95aab1f02784-powerpc64le-linux-gnu-debug.tar.gz
f8c8f4580fb3d6a0ca97616fc9f2fbc26a3c261cc37973118da6716351228db2 guix-build-95aab1f02784/output/powerpc64le-linux-gnu/bitcoin-95aab1f02784-powerpc64le-linux-gnu.tar.gz
d3e6fc531acc03b86e88d33f7d883b7dec9cc8c32b9c0e7e15fe8b296c85c573 guix-build-95aab1f02784/output/riscv64-linux-gnu/SHA256SUMS.part
fe207acd6990c5e8c72a7f5c9265121eb050e60a013830893d25e05a6d169913 guix-build-95aab1f02784/output/riscv64-linux-gnu/bitcoin-95aab1f02784-riscv64-linux-gnu-debug.tar.gz
b24d49c5187a4ff6336a929f690b1adff5e6c4ad96559cee21f306dc26284bbe guix-build-95aab1f02784/output/riscv64-linux-gnu/bitcoin-95aab1f02784-riscv64-linux-gnu.tar.gz
f3eeb01f1ee971b6a9c1c95836e6f80121581655def2b4be526c5bea64ae1ee8 guix-build-95aab1f02784/output/x86_64-apple-darwin/SHA256SUMS.part
6b5eb41172ba7785bb7e40a043c7d4a5e9bb96c1ccf57c33c186ec1664921cca guix-build-95aab1f02784/output/x86_64-apple-darwin/bitcoin-95aab1f02784-x86_64-apple-darwin-unsigned.tar.gz
4eaf25ae92e4f99ded3eef7597810f0ac014cb38475fd5f5f7e4ad8ba4ac9a68 guix-build-95aab1f02784/output/x86_64-apple-darwin/bitcoin-95aab1f02784-x86_64-apple-darwin-unsigned.zip
3869b295f6a8a18f051c9dbc6523042c720b1a49afaf93aaa5413968b80505ee guix-build-95aab1f02784/output/x86_64-apple-darwin/bitcoin-95aab1f02784-x86_64-apple-darwin.tar.gz
931ea9b3e30fc6ab87f2b15c8d58318a7b4502facf95c36d216dd1caa73df1c8 guix-build-95aab1f02784/output/x86_64-linux-gnu/SHA256SUMS.part
4b87abccd525cedcb779d1ecd24a3377835bd5d798f8ebec44c9c797d40e9c5e guix-build-95aab1f02784/output/x86_64-linux-gnu/bitcoin-95aab1f02784-x86_64-linux-gnu-debug.tar.gz
7a22a7177e7b180f9743a51cc14af733e1b7e0c88e78f02197266c0465dbf242 guix-build-95aab1f02784/output/x86_64-linux-gnu/bitcoin-95aab1f02784-x86_64-linux-gnu.tar.gz
0d36919922f54e89bf027564d357a4ef92e4c0f99348335c8f101c3a61beb67c guix-build-95aab1f02784/output/x86_64-w64-mingw32/SHA256SUMS.part
247ab95a62305c7ff5822b2cacdf19e761522b7c67673d3f658693f907f1cda2 guix-build-95aab1f02784/output/x86_64-w64-mingw32/bitcoin-95aab1f02784-win64-debug.zip
3724ef35751af1a48bf64566beea7962eedc36a7402fbf98790c8bc956835dbd guix-build-95aab1f02784/output/x86_64-w64-mingw32/bitcoin-95aab1f02784-win64-setup-unsigned.exe
b8f4d04977743b3fd9050f8a0bdd4559a3beec00cfcb9196256a56b97590d760 guix-build-95aab1f02784/output/x86_64-w64-mingw32/bitcoin-95aab1f02784-win64-unsigned.tar.gz
2e4895aaf0c4baafd69d11b111e447dce4d9d649057e8488a145560b2b34bc5a guix-build-95aab1f02784/output/x86_64-w64-mingw32/bitcoin-95aab1f02784-win64.zip
|
My Guix builds: |
|
Could the de619a3 be reverted? |
We no-longer need this, as we no-longer build python packages. Effectively reverts de619a3.
95aab1f to
3b19100
Compare
|
I think we can drop everything. Pushed that up. |
hebasto
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
ACK 3b19100, this PR effectively reverts no longer needed de619a3.
My Guix builds:
x86_64
bf25f00a359238ccb479a780d3feca454a91503d11fafb5250bfba382451349f guix-build-3b19100303e7/output/aarch64-linux-gnu/SHA256SUMS.part
47a456af1b2fbd4233c7feb97a42313908e235a587991f654aa8fadc0e517a0d guix-build-3b19100303e7/output/aarch64-linux-gnu/bitcoin-3b19100303e7-aarch64-linux-gnu-debug.tar.gz
cf7007c15990a96c8a32155b6b96f9a1dac9f350730231d431a9ae236216d93b guix-build-3b19100303e7/output/aarch64-linux-gnu/bitcoin-3b19100303e7-aarch64-linux-gnu.tar.gz
b8a6eb5ca53dcffc86eb4dabec0aee08c189c481fa069a97ae9586c557f1beb6 guix-build-3b19100303e7/output/arm-linux-gnueabihf/SHA256SUMS.part
438a7d5b079794fd8d3ee6df09dac65955aa10105080564fb7f0e5281f4e8f7b guix-build-3b19100303e7/output/arm-linux-gnueabihf/bitcoin-3b19100303e7-arm-linux-gnueabihf-debug.tar.gz
6701c007b475bd1d7529e2457ad95ec3748b1c4c2d9cc52f336c8b2690f25131 guix-build-3b19100303e7/output/arm-linux-gnueabihf/bitcoin-3b19100303e7-arm-linux-gnueabihf.tar.gz
b48127c89e14ab01f6f1526d3de987aca7edd9fb95676a8b7edb2dbaf8e0ebaf guix-build-3b19100303e7/output/arm64-apple-darwin/SHA256SUMS.part
caab83a1dfdf055ac19ea922d4e0731fb0bc10ed46f10b335d54be3b227dc8f3 guix-build-3b19100303e7/output/arm64-apple-darwin/bitcoin-3b19100303e7-arm64-apple-darwin-unsigned.tar.gz
ad5a39a251606ea83ff33b1b114628a7d7188019591493cddaa9d61d9b12b964 guix-build-3b19100303e7/output/arm64-apple-darwin/bitcoin-3b19100303e7-arm64-apple-darwin-unsigned.zip
2bc729a8746c3293c524f7e268a832d195053f94280aff185289be04164eaf47 guix-build-3b19100303e7/output/arm64-apple-darwin/bitcoin-3b19100303e7-arm64-apple-darwin.tar.gz
d2c1e488d0abbe25d6a969ba2dd0fbd02a90d27cdfba15f36dc8045748473225 guix-build-3b19100303e7/output/dist-archive/bitcoin-3b19100303e7.tar.gz
faef9afcee7486316c3b7ba41987b1a2f79f18e389ffab53a3e3e3ba89acde98 guix-build-3b19100303e7/output/powerpc64-linux-gnu/SHA256SUMS.part
824912b377b5ef872b8f624154ab28eb3a03cc4ca6d760c875f1a05a6a204689 guix-build-3b19100303e7/output/powerpc64-linux-gnu/bitcoin-3b19100303e7-powerpc64-linux-gnu-debug.tar.gz
85c1e76628fac93d69d45f7eb8e1ea328ff0379186017879314a360d7d976818 guix-build-3b19100303e7/output/powerpc64-linux-gnu/bitcoin-3b19100303e7-powerpc64-linux-gnu.tar.gz
65329bf9a86472f08bfb32e5925d958de9d0279e1312689931728d0bfabc0deb guix-build-3b19100303e7/output/powerpc64le-linux-gnu/SHA256SUMS.part
223ede3477f820a5074dfe1a8598c1319c76151396a8c54ad9995c16f9d0dfcd guix-build-3b19100303e7/output/powerpc64le-linux-gnu/bitcoin-3b19100303e7-powerpc64le-linux-gnu-debug.tar.gz
6b20a38f61bac372b0f49f86b2f99feac2fb3fb7a170199cc11b1de3e07d7cac guix-build-3b19100303e7/output/powerpc64le-linux-gnu/bitcoin-3b19100303e7-powerpc64le-linux-gnu.tar.gz
8a6957e6398c9e3bf688acb20e0569895f97e6981e8853bb677482cb3f019492 guix-build-3b19100303e7/output/riscv64-linux-gnu/SHA256SUMS.part
12fc9a81811da5255bcbfbaa2e4e6fa20a0fba0ca01698c860e6ad8f44ac2620 guix-build-3b19100303e7/output/riscv64-linux-gnu/bitcoin-3b19100303e7-riscv64-linux-gnu-debug.tar.gz
093ddca4d13e214b67ec47dbdcb4ad7a9ac414017d2fef2d8035bf7d9abefdb1 guix-build-3b19100303e7/output/riscv64-linux-gnu/bitcoin-3b19100303e7-riscv64-linux-gnu.tar.gz
2af351912ae60d0226fc669fb92f853e6915fc4cd7aaaea05c6cfa3932928f53 guix-build-3b19100303e7/output/x86_64-apple-darwin/SHA256SUMS.part
ad5a052935bc1c13fc2362cf04658bb9aef6cfcc831490790575ec3619717e99 guix-build-3b19100303e7/output/x86_64-apple-darwin/bitcoin-3b19100303e7-x86_64-apple-darwin-unsigned.tar.gz
889977bc9b722c0e3323afe48971ab90b07d98a93bf00442d7541c0b36e75a6f guix-build-3b19100303e7/output/x86_64-apple-darwin/bitcoin-3b19100303e7-x86_64-apple-darwin-unsigned.zip
38fb8536ed19e89507db54f0b411c00c954a4695a982985c505982e5466c9d49 guix-build-3b19100303e7/output/x86_64-apple-darwin/bitcoin-3b19100303e7-x86_64-apple-darwin.tar.gz
7cbd7273cbc66fc3ceac6548a5852717c217ad8d091d6c6e59a1f502cc7e79a5 guix-build-3b19100303e7/output/x86_64-linux-gnu/SHA256SUMS.part
c7ed312e89e7f905963f4c4e979bb60eed47645018cac4994645f408c91ecc69 guix-build-3b19100303e7/output/x86_64-linux-gnu/bitcoin-3b19100303e7-x86_64-linux-gnu-debug.tar.gz
6ce4250ad54e4fbe30fa3fae58840c295d0b2622cc4ef09642f4021f513f492e guix-build-3b19100303e7/output/x86_64-linux-gnu/bitcoin-3b19100303e7-x86_64-linux-gnu.tar.gz
2cf19e028ea92cb8d48b1484c79699888cabd798bc9d079cb08b9f26869f1507 guix-build-3b19100303e7/output/x86_64-w64-mingw32/SHA256SUMS.part
db7fe6a2b3ae6cfc9f0be86f82d5dbe76239c6cde1030e77ae9f2aa032773e24 guix-build-3b19100303e7/output/x86_64-w64-mingw32/bitcoin-3b19100303e7-win64-debug.zip
09ca93465525bce921c64b42ba7a80552994ff5703675b132947bd6b3b677a3c guix-build-3b19100303e7/output/x86_64-w64-mingw32/bitcoin-3b19100303e7-win64-setup-unsigned.exe
117e60f0cbd3bdd1b3b6637e52e8af7cc88b180fdbc02e55ef316c1e594db4dd guix-build-3b19100303e7/output/x86_64-w64-mingw32/bitcoin-3b19100303e7-win64-unsigned.tar.gz
25f683174e4ff367d732e7f187e562e3b90bee4bb561827f3dc8678f4f6401b2 guix-build-3b19100303e7/output/x86_64-w64-mingw32/bitcoin-3b19100303e7-win64.zip
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Nov 20, 2023
78d410d fixup! build: Generate `share/toolchain.cmake` in depends (Hennadii Stepanov) Pull request description: This PR mirrors bitcoin#28845. ACKs for top commit: TheCharlatan: ACK 78d410d Tree-SHA512: 1b52a079541ad84f43a7894f667a183ac4fabb6e6102214c96ae800cf53dec6322cc25919af185111daf427f0c2a0d035872029a8b644ba61e05e126e17d3a09
fanquake
added a commit
that referenced
this pull request
Nov 24, 2023
0ffcc5b ci: remove python3-setuptools from mac build deps (fanquake) Pull request description: Remove no-longer used python-setuptools. Followup to #28432. Related to #28845. ACKs for top commit: hebasto: ACK 0ffcc5b, I have reviewed the code and it looks OK. TheCharlatan: ACK 0ffcc5b Tree-SHA512: c3ac441c85f6f203414e5e2ad0c453ee35fa4765c72c5ff79699aa622c0db767651890ac0c8507f5ed18e18e3b0e23f2952f677476424cfda4df93647a367c26
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 6, 2024
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 7, 2024
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no-longer need this, as we no-longer build python packages.