guix: Zip needs to include all files and set time to SOURCE_DATE_EPOCH #28757
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Did you test reproducibility? |
Not yet |
a8690ff to
83dd3d0
Compare
|
Updated to be reproducible and follow the same pattern done for all of the other zip files guix produces. |
|
Results for 26.0rc1: |
|
I replaced the two files from the commit, on top of v26.0rc1, and ran codesign. This gave the same output: Have also verified that all the files are in there. I have however not tested on MacOS. |
There was a problem hiding this comment.
ACK 83dd3d0
Tested on a macbook and I get the same checksums as posted above.
|
Concept ACK. Still testing. |
There was a problem hiding this comment.
I've got the same hashes as in #28757 (comment) and #28757 (comment).
The dist top directory is redundant and should be avoided:
Also see: #27099 (comment)
|
Yea, we should nuke the |
The zip for codesigned MacOS distribution needs to have all files have the same timestamp. These files also need to be included in the zip as zip is not automatically recursive. We use the same pattern for zip as is done for the other zip files produced by guix.
83dd3d0 to
f6f18ee
Compare
Should be done, testing now (need to rebuild, so could be a little bit). Hashes for 26.0rc1: |
|
My hashes for f6f18ee: |
The zip for codesigned MacOS distribution needs to have all files have the same timestamp. These files also need to be included in the zip as zip is not automatically recursive. We use the same pattern for zip as is done for the other zip files produced by guix. Github-Pull: bitcoin#28757 Rebased-From: f6f18ee
|
Added to #28754. |
The zip for codesigned MacOS distribution needs to have all files have the same timestamp. These files also need to be included in the zip as zip is not automatically recursive. We use the same pattern for zip as is done for the other zip files produced by guix. Github-Pull: bitcoin#28757 Rebased-From: f6f18ee
e4e8479 doc: update manual pages for v26.0rc2 (fanquake) 0b189a9 build: bump version to v26.0rc2 (fanquake) e097d4c gui: fix crash on selecting "Mask values" in transaction view (Sebastian Falbesoner) 05e8874 guix: update signapple (fanquake) deccc50 guix: Zip needs to include all files with time as SOURCE_DATE_EPOCH (Andrew Chow) fe57abd test: add coverage for snapshot chainstate not matching AssumeUTXO parameters (pablomartin4btc) b761a58 assumeutxo, blockstorage: prevent core dump on invalid hash (pablomartin4btc) d3ebf6e [test] Test i2p private key constraints (Vasil Dimov) 1f11784 [net] Check i2p private key constraints (dergoegge) 6544ffa bugfix: Mark CNoDestination and PubKeyDestination constructor explicit (MarcoFalke) Pull request description: Backports for v26.0rc2: * #28695 * #28698 * #28728 * #28757 * #28759 * bitcoin-core/gui#774 ACKs for top commit: josibake: ACK e4e8479 hebasto: re-ACK e4e8479, only a backport of bitcoin-core/gui#774 added since my [recent](#28754 (review)) review. TheCharlatan: Re-ACK e4e8479 Tree-SHA512: 4b95afd26b8bf91250cb883423de8b274cefa48dc474734f5900aeb756eee3a6c656116efcfa2caff3c250678c16b70cc6b7a5d840018dc7e2c1e8161622cd61
The zip for codesigned MacOS distribution needs to have all files included and have their timestamps set to the same value (
SOURCE_DATE_EPOCH).This uses the same pattern for zip as is done for the other zip files produced by guix.